You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by GitBox <gi...@apache.org> on 2020/09/21 07:29:35 UTC
[GitHub] [brooklyn-server] duncangrant opened a new pull request #1110: There are shared utility functions no longer public
duncangrant opened a new pull request #1110:
URL: https://github.com/apache/brooklyn-server/pull/1110
This makes AddEffectorInitializerAbstractProto public as a recent change
had made it private. Alternatively we could have pushed the utility
functions to the implementation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-server] duncangrant merged pull request #1110: There are shared utility functions no longer public
Posted by GitBox <gi...@apache.org>.
duncangrant merged pull request #1110:
URL: https://github.com/apache/brooklyn-server/pull/1110
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-server] duncangrant merged pull request #1110: There are shared utility functions no longer public
Posted by GitBox <gi...@apache.org>.
duncangrant merged pull request #1110:
URL: https://github.com/apache/brooklyn-server/pull/1110
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-server] ahgittin commented on pull request #1110: There are shared utility functions no longer public
Posted by GitBox <gi...@apache.org>.
ahgittin commented on pull request #1110:
URL: https://github.com/apache/brooklyn-server/pull/1110#issuecomment-695995682
Can we do the same for the other new `*Proto` classes (if needed) and make any private or package-private functions `protected` (eg `newEffectorBuilder`).
Otherwise LGTM - good catch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-server] ahgittin commented on pull request #1110: There are shared utility functions no longer public
Posted by GitBox <gi...@apache.org>.
ahgittin commented on pull request #1110:
URL: https://github.com/apache/brooklyn-server/pull/1110#issuecomment-695995682
Can we do the same for the other new `*Proto` classes (if needed) and make any private or package-private functions `protected` (eg `newEffectorBuilder`).
Otherwise LGTM - good catch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org