You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "codecov-commenter (via GitHub)" <gi...@apache.org> on 2023/05/11 09:39:13 UTC

[GitHub] [shardingsphere-on-cloud] codecov-commenter commented on pull request #359: refactor(storage-node): refactor delete storage node logic

codecov-commenter commented on PR #359:
URL: https://github.com/apache/shardingsphere-on-cloud/pull/359#issuecomment-1543673182

   ## [Codecov](https://app.codecov.io/gh/apache/shardingsphere-on-cloud/pull/359?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#359](https://app.codecov.io/gh/apache/shardingsphere-on-cloud/pull/359?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cdee0bc) into [main](https://app.codecov.io/gh/apache/shardingsphere-on-cloud/commit/073095776d1b16442d0a5ebc7e34d72c7d45bf36?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0730957) will **increase** coverage by `0.17%`.
   > The diff coverage is `45.26%`.
   
   ```diff
   @@            Coverage Diff             @@
   ##             main     #359      +/-   ##
   ==========================================
   + Coverage   41.67%   41.85%   +0.17%     
   ==========================================
     Files          44       44              
     Lines        4773     4767       -6     
   ==========================================
   + Hits         1989     1995       +6     
   + Misses       2631     2616      -15     
   - Partials      153      156       +3     
   ```
   
   
   | [Impacted Files](https://app.codecov.io/gh/apache/shardingsphere-on-cloud/pull/359?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...ator/cmd/shardingsphere-operator/manager/option.go](https://app.codecov.io/gh/apache/shardingsphere-on-cloud/pull/359?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtb3BlcmF0b3IvY21kL3NoYXJkaW5nc3BoZXJlLW9wZXJhdG9yL21hbmFnZXIvb3B0aW9uLmdv) | `50.48% <0.00%> (+3.63%)` | :arrow_up: |
   | [...rator/pkg/reconcile/storagenode/aws/rdsinstance.go](https://app.codecov.io/gh/apache/shardingsphere-on-cloud/pull/359?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtb3BlcmF0b3IvcGtnL3JlY29uY2lsZS9zdG9yYWdlbm9kZS9hd3MvcmRzaW5zdGFuY2UuZ28=) | `22.79% <ø> (+0.33%)` | :arrow_up: |
   | [...perator/pkg/controllers/storage\_node\_controller.go](https://app.codecov.io/gh/apache/shardingsphere-on-cloud/pull/359?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtb3BlcmF0b3IvcGtnL2NvbnRyb2xsZXJzL3N0b3JhZ2Vfbm9kZV9jb250cm9sbGVyLmdv) | `42.07% <45.74%> (+1.41%)` | :arrow_up: |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org