You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/12/10 21:39:20 UTC
[GitHub] [arrow] kou commented on a change in pull request #8885: ARROW-10871: [Julia][CI] Setup Julia testing via Github Actions
kou commented on a change in pull request #8885:
URL: https://github.com/apache/arrow/pull/8885#discussion_r540511836
##########
File path: .github/workflows/julia.yml
##########
@@ -0,0 +1,57 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: Julia
+on:
+ push:
+ paths:
+ - '.github/workflows/julia.yml'
+ - 'ci/docker/*_julia.dockerfile'
+ - 'julia/**'
+ pull_request:
+ paths:
+ - '.github/workflows/julia.yml'
+ - 'ci/docker/*_julia.dockerfile'
+ - 'ci/docker/**'
+ - 'julia/**'
+
+jobs:
+ test:
+ name: Julia ${{ matrix.version }} - ${{ matrix.os }} - ${{ matrix.arch }} - ${{ github.event_name }}
Review comment:
We use `${CPU} ${PLATFORM} ${LANGUAGE} ${OPTIONAL_NOTE}` format in our jobs.
For example:
* `AMD64 Ubuntu 18.04 C++ ASAN UBSAN` where `${CPU}=AMD64`, `${PLATFORM}=Ubuntu 18.04`, `${LANGUAGE}=C++` and `${OPTIONAL_NOTE}=ASAN UBSAN`
* `AMD64 Conda Python 3.8 Without Pandas` where `${CPU}=AMD64`, `${PLATFORM=Conda`, `${LANGUAGE}=Python 3.8` and `${OPTIONAL_NOTE}=WIthout Pandas`
Can we follow the style?
##########
File path: .github/workflows/julia.yml
##########
@@ -0,0 +1,57 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: Julia
+on:
+ push:
+ paths:
+ - '.github/workflows/julia.yml'
+ - 'ci/docker/*_julia.dockerfile'
+ - 'julia/**'
+ pull_request:
+ paths:
+ - '.github/workflows/julia.yml'
+ - 'ci/docker/*_julia.dockerfile'
+ - 'ci/docker/**'
+ - 'julia/**'
+
+jobs:
+ test:
+ name: Julia ${{ matrix.version }} - ${{ matrix.os }} - ${{ matrix.arch }} - ${{ github.event_name }}
+ env:
+ JULIA_NUM_THREADS: 2
+ runs-on: ${{ matrix.os }}
+ strategy:
+ fail-fast: false
+ matrix:
+ version:
+ - '1.3'
+ - '1' # automatically expands to the latest stable 1.x release of Julia
+ - 'nightly'
+ os:
+ - ubuntu-latest
+ arch:
+ - x64
Review comment:
If we don't have a plan to add more `arch` (`x86`) in near future, how about removing this matrix item?
##########
File path: .github/workflows/julia.yml
##########
@@ -0,0 +1,57 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: Julia
+on:
+ push:
+ paths:
+ - '.github/workflows/julia.yml'
+ - 'ci/docker/*_julia.dockerfile'
+ - 'julia/**'
+ pull_request:
+ paths:
+ - '.github/workflows/julia.yml'
+ - 'ci/docker/*_julia.dockerfile'
+ - 'ci/docker/**'
+ - 'julia/**'
+
+jobs:
+ test:
+ name: Julia ${{ matrix.version }} - ${{ matrix.os }} - ${{ matrix.arch }} - ${{ github.event_name }}
+ env:
+ JULIA_NUM_THREADS: 2
+ runs-on: ${{ matrix.os }}
+ strategy:
+ fail-fast: false
+ matrix:
+ version:
+ - '1.3'
+ - '1' # automatically expands to the latest stable 1.x release of Julia
+ - 'nightly'
+ os:
+ - ubuntu-latest
Review comment:
Is it enough to run this job only on Ubuntu?
Do we need to run this job on macOS and Windows too?
##########
File path: .github/workflows/julia.yml
##########
@@ -0,0 +1,57 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: Julia
+on:
+ push:
+ paths:
+ - '.github/workflows/julia.yml'
+ - 'ci/docker/*_julia.dockerfile'
Review comment:
```suggestion
```
##########
File path: .github/workflows/julia.yml
##########
@@ -0,0 +1,57 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: Julia
+on:
+ push:
+ paths:
+ - '.github/workflows/julia.yml'
+ - 'ci/docker/*_julia.dockerfile'
+ - 'julia/**'
+ pull_request:
+ paths:
+ - '.github/workflows/julia.yml'
+ - 'ci/docker/*_julia.dockerfile'
+ - 'ci/docker/**'
Review comment:
```suggestion
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org