[jira] Commented: (ZOOKEEPER-408) address all findbugs warnings in persistence classes

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12715735#action_12715735 ] 

Hadoop QA commented on ZOOKEEPER-408:
-------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12409680/ZOOKEEPER-408.patch
  against trunk revision 781173.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 27 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/99/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/99/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/99/console

This message is automatically generated.

> address all findbugs warnings in persistence classes
> ----------------------------------------------------
>
>                 Key: ZOOKEEPER-408
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-408
>             Project: Zookeeper
>          Issue Type: Sub-task
>            Reporter: Patrick Hunt
>            Assignee: Mahadev konar
>             Fix For: 3.2.0
>
>         Attachments: ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, ZOOKEEPER-408.patch
>
>
> trunk/src/java/main/org/apache/zookeeper/server/DataTree.java
> trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java
> trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java
> trunk/src/java/main/org/apache/zookeeper/server/persistence/Util.java
> trunk/src/java/main/org/apache/zookeeper/server/DataNode.java
> trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataNodeV1.java
> trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataTreeV1.java

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.