You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2019/12/07 16:18:41 UTC

[GitHub] [skywalking] kezhenxu94 edited a comment on issue #4024: Add Armeria Java agent plugin

kezhenxu94 edited a comment on issue #4024: Add Armeria Java agent plugin
URL: https://github.com/apache/skywalking/pull/4024#issuecomment-562864669
 
 
   > Why tests cancelled?
   
   I cancelled the tests before I update the commit, to save unnecessary tests.
   
   > I knew America auther. I will try to invite him to review after we think this PR is ready.
   
   Hah, that makes me nervous, I knew him too but this may be too trivial for him 😄 
   
   > 
   > One question, how it works when grpc plugin is there top?
   
   This plugin just supports http protocol for now, nothing to do with GRPC

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services