You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/06/09 15:19:37 UTC

[GitHub] [arrow] zeroshade commented on a diff in pull request #13310: ARROW-16749: [Go] Fix pqarrow writer for null array

zeroshade commented on code in PR #13310:
URL: https://github.com/apache/arrow/pull/13310#discussion_r893640554


##########
go/parquet/file/column_writer_types.gen.go.tmpl:
##########
@@ -137,13 +137,13 @@ func (w *{{.Name}}ColumnChunkWriter) WriteBatchSpaced(values []{{.name}}, defLev
 
     w.writeLevelsSpaced(batch, levelSliceOrNil(defLevels, offset, batch), levelSliceOrNil(repLevels, offset, batch))
     if values != nil {
-      vals = values[valueOffset:]
+      vals = values[valueOffset:][:info.numSpaced()]

Review Comment:
   why was this needed? also, if you're going to add this it should be `vals = values[valueOffset : info.numSpaced()]` no need for the extra set of brackets.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org