You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/08/19 10:04:50 UTC

[GitHub] [cloudstack] ravening opened a new pull request #4275: Display hypervisor type for VM snapshot

ravening opened a new pull request #4275:
URL: https://github.com/apache/cloudstack/pull/4275


   ## Description
   <!--- Describe your changes in detail -->
   The "hypervisor" field in listvmsnapshot response will
   be used in primate to enable/disable creating a snapshot
   from VM snapshot functionality.
   
   Creating snapshot from VM snapshot will be enabled only if
   the hypervisor is KVM
   
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
   - [X] Enhancement (improves an existing feature and functionality)
   
   
   ## Screenshots (if appropriate):
   
   ## How Has This Been Tested?
   <!-- Please describe in detail how you tested your changes. -->
   <!-- Include details of your testing environment, and the tests you ran to -->
   <!-- see how your change affects other areas of the code, etc. -->
   Cloudmonkey output
   
   ```
   (local) 🐵 > list vmsnapshot
   {
     "count": 2,
     "vmSnapshot": [
       {
         "account": "admin",
         "created": "2020-08-18T11:12:11+0000",
         "current": true,
         "displayname": "i-2-5-VM_VS_20200818111211",
         "domain": "ROOT",
         "domainid": "f47-c10d-11ea-8715-063381",
         "hypervisor": "KVM",
         "id": "d34f9-df5a-4510-985a-e7f508ad",
         "name": "i-2-5-VM_VS_20200818111211",
         "state": "Ready",
         "tags": [],
         "type": "DiskAndMemory",
         "virtualmachineid": "52cfd-e8d6-4c85-a7e0-f603f151",
         "zoneid": "d0802-be7b-4345-8b55-1612c0b"
       },
       {
         "account": "admin",
         "created": "2020-08-17T15:48:08+0000",
         "current": true,
         "description": "second",
         "displayname": "second",
         "domain": "ROOT",
         "domainid": "f4702-c10d-11ea-8715-0623381",
         "hypervisor": "KVM",
         "id": "c953-0836-4d75-83a7-f805f8ad",
         "name": "i-2-8-VM_VS_20200817154808",
         "state": "Ready",
         "tags": [],
         "type": "DiskAndMemory",
         "virtualmachineid": "3c34-99d2-491c-b1a1-228ec87cb",
         "zoneid": "d0802-be7b-4345-8b55-1612fe0b"
       }
     ]
   }
   ```
   
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd merged pull request #4275: Display hypervisor type for VM snapshot

Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #4275:
URL: https://github.com/apache/cloudstack/pull/4275


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4275: Display hypervisor type for VM snapshot

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4275:
URL: https://github.com/apache/cloudstack/pull/4275#issuecomment-676126096


   Packaging result: ✔centos7 ✖centos8 ✔debian. JID-1787


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] ravening commented on pull request #4275: Display hypervisor type for VM snapshot

Posted by GitBox <gi...@apache.org>.
ravening commented on pull request #4275:
URL: https://github.com/apache/cloudstack/pull/4275#issuecomment-676073007


   @rhtyd @davidjumani Please review


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4275: Display hypervisor type for VM snapshot

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4275:
URL: https://github.com/apache/cloudstack/pull/4275#issuecomment-676074325


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4275: Display hypervisor type for VM snapshot

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4275:
URL: https://github.com/apache/cloudstack/pull/4275#issuecomment-676161106


   (centos8 failure is ignorable as 4.14 does not support centos8 pkg support)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4275: Display hypervisor type for VM snapshot

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4275:
URL: https://github.com/apache/cloudstack/pull/4275#issuecomment-676075945


   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4275: Display hypervisor type for VM snapshot

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4275:
URL: https://github.com/apache/cloudstack/pull/4275#issuecomment-676161605


   Explicit smoketest is not needed as fix is presentation on API layer and we can merge as soon as Travis passes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org