You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/08/15 22:22:13 UTC

[GitHub] [arrow-datafusion] houqp opened a new pull request #891: add cross join support to ballista

houqp opened a new pull request #891:
URL: https://github.com/apache/arrow-datafusion/pull/891


   # Rationale for this change
   
   Ballista should support cross join.
   
   # What changes are included in this PR?
   
   Added ser/de for cross join logical and physical nodes.
   
   # Are there any user-facing changes?
   no


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb commented on a change in pull request #891: add cross join support to ballista

Posted by GitBox <gi...@apache.org>.
alamb commented on a change in pull request #891:
URL: https://github.com/apache/arrow-datafusion/pull/891#discussion_r689856694



##########
File path: ballista/rust/core/proto/ballista.proto
##########
@@ -249,9 +249,10 @@ message LogicalPlanNode {
     RepartitionNode repartition = 9;
     EmptyRelationNode empty_relation = 10;
     CreateExternalTableNode create_external_table = 11;
-    AnalyzeNode analyze = 14;
     ExplainNode explain = 12;
     WindowNode window = 13;
+    AnalyzeNode analyze = 14;

Review comment:
       I don't have a strong preference. `rust` will tell us when the cases are missing so the order in which they are defined is not all that critical in my opinion




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] houqp commented on a change in pull request #891: add cross join support to ballista

Posted by GitBox <gi...@apache.org>.
houqp commented on a change in pull request #891:
URL: https://github.com/apache/arrow-datafusion/pull/891#discussion_r689151562



##########
File path: ballista/rust/core/proto/ballista.proto
##########
@@ -249,9 +249,10 @@ message LogicalPlanNode {
     RepartitionNode repartition = 9;
     EmptyRelationNode empty_relation = 10;
     CreateExternalTableNode create_external_table = 11;
-    AnalyzeNode analyze = 14;
     ExplainNode explain = 12;
     WindowNode window = 13;
+    AnalyzeNode analyze = 14;

Review comment:
       @alamb i reordered the node down here so it's easier to do the counting. I am guessing you put it next to `ExplainNode` because that's how they should be logically grouped? If so, maybe we could keep it next to `ExplainNode` and reorder the subsequent fields.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb commented on pull request #891: add cross join support to ballista

Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #891:
URL: https://github.com/apache/arrow-datafusion/pull/891#issuecomment-899815370


   Thanks @houqp  -- looks nive


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb edited a comment on pull request #891: add cross join support to ballista

Posted by GitBox <gi...@apache.org>.
alamb edited a comment on pull request #891:
URL: https://github.com/apache/arrow-datafusion/pull/891#issuecomment-899815370


   Thanks @houqp  -- looks nice


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb merged pull request #891: add cross join support to ballista

Posted by GitBox <gi...@apache.org>.
alamb merged pull request #891:
URL: https://github.com/apache/arrow-datafusion/pull/891


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org