You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alex Clemmer <cl...@gmail.com> on 2016/11/28 17:55:02 UTC
Re: Review Request 53756: CMake: Added logrotate container logger
module to the build.
> On Nov. 17, 2016, 5:19 p.m., Alex Clemmer wrote:
> > src/slave/container_loggers/CMakeLists.txt, line 30
> > <https://reviews.apache.org/r/53756/diff/2/?file=1564715#file1564715line30>
> >
> > Seems like it might be easier to just `if` out the line that includes this `CMakeLists.txt`?
>
> Joseph Wu wrote:
> It's easier to reason about the build structure if all the `CMakeLists.txt` files are included. i.e. Anyone working on source code in the same directory just has to modify this one CMakeLists.txt, instead of checking in all parent directories for potential inclusion.
>
> The one exception for this is if there are platform specific folders, such as the `stout/os/windows/*` folders. (We'll be removing the Windows-only exclusion of tests shortly after this review chain too.)
Ok, let's mark this as "dropped", I find this point compelling.
- Alex
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53756/#review156217
-----------------------------------------------------------
On Nov. 15, 2016, 10:56 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53756/
> -----------------------------------------------------------
>
> (Updated Nov. 15, 2016, 10:56 p.m.)
>
>
> Review request for mesos, Alex Clemmer and Joris Van Remoortere.
>
>
> Bugs: MESOS-5792
> https://issues.apache.org/jira/browse/MESOS-5792
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This review replaces: https://reviews.apache.org/r/49874/
>
>
> Diffs
> -----
>
> src/slave/CMakeLists.txt 33120ace79bce449329a7cc4b7ef264d2867fc13
> src/slave/cmake/SlaveConfigure.cmake b339239761a5de321d65b92376dae69c339bee5c
> src/slave/container_loggers/CMakeLists.txt PRE-CREATION
>
> Diff: https://reviews.apache.org/r/53756/diff/
>
>
> Testing
> -------
>
> cmake ..
> make
>
>
> Thanks,
>
> Joseph Wu
>
>