You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Rohini Palaniswamy <ro...@gmail.com> on 2013/03/05 20:23:34 UTC
Review Request: [OOZIE-1250] - Coord action timeout not happening when there
is a exception
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9756/
-----------------------------------------------------------
Review request for oozie.
Description
-------
Fixed queueing timeout on exception
This addresses bug OOZIE-1250.
https://issues.apache.org/jira/browse/OOZIE-1250
Diffs
-----
http://svn.apache.org/repos/asf/oozie/branches/branch-4.0/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 1452922
http://svn.apache.org/repos/asf/oozie/branches/branch-4.0/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java 1452922
http://svn.apache.org/repos/asf/oozie/branches/branch-4.0/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionInputCheckXCommand.java 1452922
http://svn.apache.org/repos/asf/oozie/branches/branch-4.0/core/src/test/java/org/apache/oozie/command/coord/TestCoordPushDependencyCheckXCommand.java 1452922
http://svn.apache.org/repos/asf/oozie/branches/branch-4.0/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1452922
Diff: https://reviews.apache.org/r/9756/diff/
Testing
-------
Unit tests added
Thanks,
Rohini Palaniswamy
Re: Review Request: [OOZIE-1250] - Coord action timeout not happening when
there is a exception
Posted by Rohini Palaniswamy <ro...@gmail.com>.
> On March 5, 2013, 8:08 p.m., Mona Chitnis wrote:
> > http://svn.apache.org/repos/asf/oozie/branches/branch-4.0/core/src/test/java/org/apache/oozie/test/XDataTestCase.java, line 1360
> > <https://reviews.apache.org/r/9756/diff/1/?file=266282#file266282line1360>
> >
> > any particular reason behind using StoreService here instead of JPAService used generally?
UPDATE_COORD_ACTION is only available through store. No existing JPA command for that.
> On March 5, 2013, 8:08 p.m., Mona Chitnis wrote:
> > http://svn.apache.org/repos/asf/oozie/branches/branch-4.0/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionInputCheckXCommand.java, line 803
> > <https://reviews.apache.org/r/9756/diff/1/?file=266280#file266280line803>
> >
> > add a fail() here if exception is encountered. Else the test will record as passed
Will not pass as it is throwing the exception.
> On March 5, 2013, 8:08 p.m., Mona Chitnis wrote:
> > http://svn.apache.org/repos/asf/oozie/branches/branch-4.0/core/src/test/java/org/apache/oozie/command/coord/TestCoordPushDependencyCheckXCommand.java, line 273
> > <https://reviews.apache.org/r/9756/diff/1/?file=266281#file266281line273>
> >
> > check for unregistered missing deps is missing
In this case where DB and table don't exist from the beginning, dependencies would not have been registered.
- Rohini
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9756/#review17420
-----------------------------------------------------------
On March 5, 2013, 7:23 p.m., Rohini Palaniswamy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9756/
> -----------------------------------------------------------
>
> (Updated March 5, 2013, 7:23 p.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> Fixed queueing timeout on exception
>
>
> This addresses bug OOZIE-1250.
> https://issues.apache.org/jira/browse/OOZIE-1250
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/oozie/branches/branch-4.0/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 1452922
> http://svn.apache.org/repos/asf/oozie/branches/branch-4.0/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java 1452922
> http://svn.apache.org/repos/asf/oozie/branches/branch-4.0/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionInputCheckXCommand.java 1452922
> http://svn.apache.org/repos/asf/oozie/branches/branch-4.0/core/src/test/java/org/apache/oozie/command/coord/TestCoordPushDependencyCheckXCommand.java 1452922
> http://svn.apache.org/repos/asf/oozie/branches/branch-4.0/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1452922
>
> Diff: https://reviews.apache.org/r/9756/diff/
>
>
> Testing
> -------
>
> Unit tests added
>
>
> Thanks,
>
> Rohini Palaniswamy
>
>
Re: Review Request: [OOZIE-1250] - Coord action timeout not happening when
there is a exception
Posted by Mona Chitnis <mo...@yahoo.in>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9756/#review17420
-----------------------------------------------------------
http://svn.apache.org/repos/asf/oozie/branches/branch-4.0/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionInputCheckXCommand.java
<https://reviews.apache.org/r/9756/#comment36948>
add a fail() here if exception is encountered. Else the test will record as passed
http://svn.apache.org/repos/asf/oozie/branches/branch-4.0/core/src/test/java/org/apache/oozie/command/coord/TestCoordPushDependencyCheckXCommand.java
<https://reviews.apache.org/r/9756/#comment36949>
check for unregistered missing deps is missing
http://svn.apache.org/repos/asf/oozie/branches/branch-4.0/core/src/test/java/org/apache/oozie/test/XDataTestCase.java
<https://reviews.apache.org/r/9756/#comment36950>
any particular reason behind using StoreService here instead of JPAService used generally?
- Mona Chitnis
On March 5, 2013, 7:23 p.m., Rohini Palaniswamy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9756/
> -----------------------------------------------------------
>
> (Updated March 5, 2013, 7:23 p.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> Fixed queueing timeout on exception
>
>
> This addresses bug OOZIE-1250.
> https://issues.apache.org/jira/browse/OOZIE-1250
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/oozie/branches/branch-4.0/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 1452922
> http://svn.apache.org/repos/asf/oozie/branches/branch-4.0/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java 1452922
> http://svn.apache.org/repos/asf/oozie/branches/branch-4.0/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionInputCheckXCommand.java 1452922
> http://svn.apache.org/repos/asf/oozie/branches/branch-4.0/core/src/test/java/org/apache/oozie/command/coord/TestCoordPushDependencyCheckXCommand.java 1452922
> http://svn.apache.org/repos/asf/oozie/branches/branch-4.0/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1452922
>
> Diff: https://reviews.apache.org/r/9756/diff/
>
>
> Testing
> -------
>
> Unit tests added
>
>
> Thanks,
>
> Rohini Palaniswamy
>
>
Re: Review Request: [OOZIE-1250] - Coord action timeout not happening when
there is a exception
Posted by Mona Chitnis <mo...@yahoo.in>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9756/#review17429
-----------------------------------------------------------
Ship it!
Ship It!
- Mona Chitnis
On March 5, 2013, 7:23 p.m., Rohini Palaniswamy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9756/
> -----------------------------------------------------------
>
> (Updated March 5, 2013, 7:23 p.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> Fixed queueing timeout on exception
>
>
> This addresses bug OOZIE-1250.
> https://issues.apache.org/jira/browse/OOZIE-1250
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/oozie/branches/branch-4.0/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 1452922
> http://svn.apache.org/repos/asf/oozie/branches/branch-4.0/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java 1452922
> http://svn.apache.org/repos/asf/oozie/branches/branch-4.0/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionInputCheckXCommand.java 1452922
> http://svn.apache.org/repos/asf/oozie/branches/branch-4.0/core/src/test/java/org/apache/oozie/command/coord/TestCoordPushDependencyCheckXCommand.java 1452922
> http://svn.apache.org/repos/asf/oozie/branches/branch-4.0/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1452922
>
> Diff: https://reviews.apache.org/r/9756/diff/
>
>
> Testing
> -------
>
> Unit tests added
>
>
> Thanks,
>
> Rohini Palaniswamy
>
>