You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by pr...@apache.org on 2017/07/08 09:25:06 UTC

svn commit: r1801269 - /ofbiz/ofbiz-framework/trunk/applications/order/src/main/java/org/apache/ofbiz/order/shoppingcart/ShoppingCartHelper.java

Author: pranayp
Date: Sat Jul  8 09:25:06 2017
New Revision: 1801269

URL: http://svn.apache.org/viewvc?rev=1801269&view=rev
Log:
Fixed: Product specific quantity condition price rule application when quantity is changed in cart (OFBIZ-7263) Changing item quantity in cart was setting the flag isModifiedPrice true which is conflicting with updatePrice condition and hence price recalculation was not being triggered. Thanks Aditi Patidar for reporting the issue and providing patch. Thanks Paul Foxworthy for reviewing the issue and providing the research details.

Modified:
    ofbiz/ofbiz-framework/trunk/applications/order/src/main/java/org/apache/ofbiz/order/shoppingcart/ShoppingCartHelper.java

Modified: ofbiz/ofbiz-framework/trunk/applications/order/src/main/java/org/apache/ofbiz/order/shoppingcart/ShoppingCartHelper.java
URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/order/src/main/java/org/apache/ofbiz/order/shoppingcart/ShoppingCartHelper.java?rev=1801269&r1=1801268&r2=1801269&view=diff
==============================================================================
--- ofbiz/ofbiz-framework/trunk/applications/order/src/main/java/org/apache/ofbiz/order/shoppingcart/ShoppingCartHelper.java (original)
+++ ofbiz/ofbiz-framework/trunk/applications/order/src/main/java/org/apache/ofbiz/order/shoppingcart/ShoppingCartHelper.java Sat Jul  8 09:25:06 2017
@@ -879,7 +879,6 @@ public class ShoppingCartHelper {
                                 if (item != null) {
                                     item.setBasePrice(quantity); // this is quantity because the parsed number variable is the same as quantity
                                     item.setDisplayPrice(quantity); // or the amount shown the cart items page won't be right
-                                    item.setIsModifiedPrice(true); // flag as a modified price
                                 }
                             }
                         }