[GitHub] [apisix] spacewander commented on a diff in pull request #9068: feat: oidc auth

["spacewander (via GitHub)" <gi...@apache.org>]

spacewander commented on code in PR #9068:
URL: https://github.com/apache/apisix/pull/9068#discussion_r1138007148


##########
apisix/plugins/schema.lua:
##########
@@ -0,0 +1,18 @@
+local typedefs = require "kong.db.schema.typedefs"

Review Comment:
   Why this PR contains Kong's schema?



##########
t/spec/test_oidc.lua:
##########
@@ -0,0 +1,36 @@
+describe("OIDC auth plugin", function()

Review Comment:
   We use a different way to test. You can check it out in https://github.com/apache/apisix/blob/master/docs/en/latest/internal/testing-framework.md
   
   The test code needs to be added in https://github.com/apache/apisix/blob/master/t/plugin/openid-connect2.t
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org