[GitHub] [cordova-js] raphinesse commented on issue #222: Stable error handling for loaded Cordova plugins

[GitBox <gi...@apache.org>]

raphinesse commented on issue #222: Stable error handling for loaded Cordova plugins
URL: https://github.com/apache/cordova-js/pull/222#issuecomment-611489850
 
 
   @mathiasscheffe Good points about the error messages. I think having separate messages should be fine then.
   
   > Do you have any suggestions on how to hook into the functionality? This will save me some debugging. The existing unit tests are of higher level.
   
   I think you should be able to define a fake `cordova/plugin_list` module via `cordova.define` (see `test.require.js` for examples) with some faulty plugin modules, spy on `window.alert` and `console.error` and check that they get called when loading plugin modules.
   
   > I can make time in 2 weeks to implement unit tests.
   
   No hurry. All in due time.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org