[GitHub] bhavinthaker commented on a change in pull request #9169: Make versions of python dependencies like numpy, deterministic.

[GitBox <gi...@apache.org>]

bhavinthaker commented on a change in pull request #9169: Make versions of python dependencies like numpy, deterministic.
URL: https://github.com/apache/incubator-mxnet/pull/9169#discussion_r158417058
 
 

 ##########
 File path: python/setup.py
 ##########
 @@ -28,7 +28,7 @@
 else:
     from setuptools import setup
     from setuptools.extension import Extension
-    kwargs = {'install_requires': ['numpy', 'requests', 'graphviz'], 'zip_safe': False}
+    kwargs = {'install_requires': ['numpy<=1.13.3', 'requests==2.18.4', 'graphviz==0.8.1'], 'zip_safe': False}
 
 Review comment:
   While the dependency string "numpy<=1.13.3" is more flexible in supporting a variety of numpy versions, the drawback/tradeoff is that if a particular lower version of numpy is NOT tested then the combinations of numpy versions may make it hard to test and support. I think that the default version should be what the MXNet CI tests and then users can change the script to make it flexible if required.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services