You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@apr.apache.org by yl...@apache.org on 2021/11/19 13:26:18 UTC

svn propchange: r1895175 - svn:log

Author: ylavic
Revision: 1895175
Modified property: svn:log

Modified: svn:log at Fri Nov 19 13:26:18 2021
------------------------------------------------------------------------------
--- svn:log (original)
+++ svn:log Fri Nov 19 13:26:18 2021
@@ -1,11 +1,11 @@
 Follow up to r1895106: Use less expensive atomics for wakeup.
 
-If pipe writers (wakeup) put a single byte until consume it's consumed by the
-reader (drain), an atomic cas for the writers (still) and an atomic (re)set
-for the reader is enough (not need to cas on the reader side).
+If pipe writers (wakeup) put a single byte until it's consumed by the
+reader (drain), it's enough to use an atomic cas for the writers (still) and
+an atomic (re)set for the reader (no more cas here).
 
 This requires that the reader never blocks on read though (e.g. spurious return
-from poll), so (re)make the read side on the pipe non-blocking (finally).
+from poll), so make the read side on the pipe non-blocking again/finally.
 
 Since synchronous non-blocking read is not a thing for Windows' Readfile(), add
 a ->socket flag this arch's to apr_file_t (like the existing ->pipe one) which