You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Joe Smith <ya...@gmail.com> on 2015/05/09 18:57:08 UTC
Review Request 34015: Improve client update json output to
consistently use lastModified
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34015/
-----------------------------------------------------------
Review request for Aurora and Bill Farner.
Bugs: AURORA-1316
https://issues.apache.org/jira/browse/AURORA-1316
Repository: aurora
Description
-------
Improve client update json output to consistently use lastModified
Diffs
-----
src/main/python/apache/aurora/client/cli/update.py 58f0db0988911858156aa086ba9fea8ecfe99143
src/test/python/apache/aurora/client/cli/test_supdate.py 158d3305c5ce5f1de5e3f4f771f318cff9bf7914
Diff: https://reviews.apache.org/r/34015/diff/
Testing
-------
$ ./pants test.pytest --no-fast ./src/test/python/apache/aurora/client:all
src.test.python.apache.aurora.client.api.api ..... SUCCESS
src.test.python.apache.aurora.client.api.instance_watcher ..... SUCCESS
src.test.python.apache.aurora.client.api.job_monitor ..... SUCCESS
src.test.python.apache.aurora.client.api.mux ..... SUCCESS
src.test.python.apache.aurora.client.api.quota_check ..... SUCCESS
src.test.python.apache.aurora.client.api.restarter ..... SUCCESS
src.test.python.apache.aurora.client.api.scheduler_client ..... SUCCESS
src.test.python.apache.aurora.client.api.sla ..... SUCCESS
src.test.python.apache.aurora.client.api.task_util ..... SUCCESS
src.test.python.apache.aurora.client.api.updater ..... SUCCESS
src.test.python.apache.aurora.client.api.updater_util ..... SUCCESS
src.test.python.apache.aurora.client.base ..... SUCCESS
src.test.python.apache.aurora.client.binding_helper ..... SUCCESS
src.test.python.apache.aurora.client.cli.api ..... SUCCESS
src.test.python.apache.aurora.client.cli.client ..... SUCCESS
src.test.python.apache.aurora.client.cli.command_hooks ..... SUCCESS
src.test.python.apache.aurora.client.cli.config ..... SUCCESS
src.test.python.apache.aurora.client.cli.context ..... SUCCESS
src.test.python.apache.aurora.client.cli.cron ..... SUCCESS
src.test.python.apache.aurora.client.cli.inspect ..... SUCCESS
src.test.python.apache.aurora.client.cli.job ..... SUCCESS
src.test.python.apache.aurora.client.cli.plugins ..... SUCCESS
src.test.python.apache.aurora.client.cli.quota ..... SUCCESS
src.test.python.apache.aurora.client.cli.sla ..... SUCCESS
src.test.python.apache.aurora.client.cli.supdate ..... SUCCESS
src.test.python.apache.aurora.client.cli.task ..... SUCCESS
src.test.python.apache.aurora.client.cli.update ..... SUCCESS
src.test.python.apache.aurora.client.cli.version ..... SUCCESS
src.test.python.apache.aurora.client.config ..... SUCCESS
src.test.python.apache.aurora.client.hooks.hooked_api ..... SUCCESS
src.test.python.apache.aurora.client.hooks.non_hooked_api ..... SUCCESS
Thanks,
Joe Smith
Re: Review Request 34015: Improve client update json output to
consistently use lastModified
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34015/#review83155
-----------------------------------------------------------
Ship it!
Master (1c09d58) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On May 9, 2015, 4:57 p.m., Joe Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34015/
> -----------------------------------------------------------
>
> (Updated May 9, 2015, 4:57 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-1316
> https://issues.apache.org/jira/browse/AURORA-1316
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Improve client update json output to consistently use lastModified
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/update.py 58f0db0988911858156aa086ba9fea8ecfe99143
> src/test/python/apache/aurora/client/cli/test_supdate.py 158d3305c5ce5f1de5e3f4f771f318cff9bf7914
>
> Diff: https://reviews.apache.org/r/34015/diff/
>
>
> Testing
> -------
>
> $ ./pants test.pytest --no-fast ./src/test/python/apache/aurora/client:all
> src.test.python.apache.aurora.client.api.api ..... SUCCESS
> src.test.python.apache.aurora.client.api.instance_watcher ..... SUCCESS
> src.test.python.apache.aurora.client.api.job_monitor ..... SUCCESS
> src.test.python.apache.aurora.client.api.mux ..... SUCCESS
> src.test.python.apache.aurora.client.api.quota_check ..... SUCCESS
> src.test.python.apache.aurora.client.api.restarter ..... SUCCESS
> src.test.python.apache.aurora.client.api.scheduler_client ..... SUCCESS
> src.test.python.apache.aurora.client.api.sla ..... SUCCESS
> src.test.python.apache.aurora.client.api.task_util ..... SUCCESS
> src.test.python.apache.aurora.client.api.updater ..... SUCCESS
> src.test.python.apache.aurora.client.api.updater_util ..... SUCCESS
> src.test.python.apache.aurora.client.base ..... SUCCESS
> src.test.python.apache.aurora.client.binding_helper ..... SUCCESS
> src.test.python.apache.aurora.client.cli.api ..... SUCCESS
> src.test.python.apache.aurora.client.cli.client ..... SUCCESS
> src.test.python.apache.aurora.client.cli.command_hooks ..... SUCCESS
> src.test.python.apache.aurora.client.cli.config ..... SUCCESS
> src.test.python.apache.aurora.client.cli.context ..... SUCCESS
> src.test.python.apache.aurora.client.cli.cron ..... SUCCESS
> src.test.python.apache.aurora.client.cli.inspect ..... SUCCESS
> src.test.python.apache.aurora.client.cli.job ..... SUCCESS
> src.test.python.apache.aurora.client.cli.plugins ..... SUCCESS
> src.test.python.apache.aurora.client.cli.quota ..... SUCCESS
> src.test.python.apache.aurora.client.cli.sla ..... SUCCESS
> src.test.python.apache.aurora.client.cli.supdate ..... SUCCESS
> src.test.python.apache.aurora.client.cli.task ..... SUCCESS
> src.test.python.apache.aurora.client.cli.update ..... SUCCESS
> src.test.python.apache.aurora.client.cli.version ..... SUCCESS
> src.test.python.apache.aurora.client.config ..... SUCCESS
> src.test.python.apache.aurora.client.hooks.hooked_api ..... SUCCESS
> src.test.python.apache.aurora.client.hooks.non_hooked_api ..... SUCCESS
>
>
> Thanks,
>
> Joe Smith
>
>
Re: Review Request 34015: Improve client update json output to
consistently use last_modified
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34015/#review83331
-----------------------------------------------------------
Ship it!
Ship It!
- Bill Farner
On May 11, 2015, 10:19 p.m., Joe Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34015/
> -----------------------------------------------------------
>
> (Updated May 11, 2015, 10:19 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-1316
> https://issues.apache.org/jira/browse/AURORA-1316
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Improve client update json output to consistently use last_modified
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/update.py 58f0db0988911858156aa086ba9fea8ecfe99143
> src/test/python/apache/aurora/client/cli/test_supdate.py 158d3305c5ce5f1de5e3f4f771f318cff9bf7914
>
> Diff: https://reviews.apache.org/r/34015/diff/
>
>
> Testing
> -------
>
> $ ./pants test.pytest --no-fast ./src/test/python/apache/aurora/client:all
> src.test.python.apache.aurora.client.api.api ..... SUCCESS
> src.test.python.apache.aurora.client.api.instance_watcher ..... SUCCESS
> src.test.python.apache.aurora.client.api.job_monitor ..... SUCCESS
> src.test.python.apache.aurora.client.api.mux ..... SUCCESS
> src.test.python.apache.aurora.client.api.quota_check ..... SUCCESS
> src.test.python.apache.aurora.client.api.restarter ..... SUCCESS
> src.test.python.apache.aurora.client.api.scheduler_client ..... SUCCESS
> src.test.python.apache.aurora.client.api.sla ..... SUCCESS
> src.test.python.apache.aurora.client.api.task_util ..... SUCCESS
> src.test.python.apache.aurora.client.api.updater ..... SUCCESS
> src.test.python.apache.aurora.client.api.updater_util ..... SUCCESS
> src.test.python.apache.aurora.client.base ..... SUCCESS
> src.test.python.apache.aurora.client.binding_helper ..... SUCCESS
> src.test.python.apache.aurora.client.cli.api ..... SUCCESS
> src.test.python.apache.aurora.client.cli.client ..... SUCCESS
> src.test.python.apache.aurora.client.cli.command_hooks ..... SUCCESS
> src.test.python.apache.aurora.client.cli.config ..... SUCCESS
> src.test.python.apache.aurora.client.cli.context ..... SUCCESS
> src.test.python.apache.aurora.client.cli.cron ..... SUCCESS
> src.test.python.apache.aurora.client.cli.inspect ..... SUCCESS
> src.test.python.apache.aurora.client.cli.job ..... SUCCESS
> src.test.python.apache.aurora.client.cli.plugins ..... SUCCESS
> src.test.python.apache.aurora.client.cli.quota ..... SUCCESS
> src.test.python.apache.aurora.client.cli.sla ..... SUCCESS
> src.test.python.apache.aurora.client.cli.supdate ..... SUCCESS
> src.test.python.apache.aurora.client.cli.task ..... SUCCESS
> src.test.python.apache.aurora.client.cli.update ..... SUCCESS
> src.test.python.apache.aurora.client.cli.version ..... SUCCESS
> src.test.python.apache.aurora.client.config ..... SUCCESS
> src.test.python.apache.aurora.client.hooks.hooked_api ..... SUCCESS
> src.test.python.apache.aurora.client.hooks.non_hooked_api ..... SUCCESS
>
>
> Thanks,
>
> Joe Smith
>
>
Re: Review Request 34015: Improve client update json output to
consistently use last_modified
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34015/#review83301
-----------------------------------------------------------
Ship it!
Master (aabb692) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On May 11, 2015, 10:19 p.m., Joe Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34015/
> -----------------------------------------------------------
>
> (Updated May 11, 2015, 10:19 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-1316
> https://issues.apache.org/jira/browse/AURORA-1316
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Improve client update json output to consistently use last_modified
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/update.py 58f0db0988911858156aa086ba9fea8ecfe99143
> src/test/python/apache/aurora/client/cli/test_supdate.py 158d3305c5ce5f1de5e3f4f771f318cff9bf7914
>
> Diff: https://reviews.apache.org/r/34015/diff/
>
>
> Testing
> -------
>
> $ ./pants test.pytest --no-fast ./src/test/python/apache/aurora/client:all
> src.test.python.apache.aurora.client.api.api ..... SUCCESS
> src.test.python.apache.aurora.client.api.instance_watcher ..... SUCCESS
> src.test.python.apache.aurora.client.api.job_monitor ..... SUCCESS
> src.test.python.apache.aurora.client.api.mux ..... SUCCESS
> src.test.python.apache.aurora.client.api.quota_check ..... SUCCESS
> src.test.python.apache.aurora.client.api.restarter ..... SUCCESS
> src.test.python.apache.aurora.client.api.scheduler_client ..... SUCCESS
> src.test.python.apache.aurora.client.api.sla ..... SUCCESS
> src.test.python.apache.aurora.client.api.task_util ..... SUCCESS
> src.test.python.apache.aurora.client.api.updater ..... SUCCESS
> src.test.python.apache.aurora.client.api.updater_util ..... SUCCESS
> src.test.python.apache.aurora.client.base ..... SUCCESS
> src.test.python.apache.aurora.client.binding_helper ..... SUCCESS
> src.test.python.apache.aurora.client.cli.api ..... SUCCESS
> src.test.python.apache.aurora.client.cli.client ..... SUCCESS
> src.test.python.apache.aurora.client.cli.command_hooks ..... SUCCESS
> src.test.python.apache.aurora.client.cli.config ..... SUCCESS
> src.test.python.apache.aurora.client.cli.context ..... SUCCESS
> src.test.python.apache.aurora.client.cli.cron ..... SUCCESS
> src.test.python.apache.aurora.client.cli.inspect ..... SUCCESS
> src.test.python.apache.aurora.client.cli.job ..... SUCCESS
> src.test.python.apache.aurora.client.cli.plugins ..... SUCCESS
> src.test.python.apache.aurora.client.cli.quota ..... SUCCESS
> src.test.python.apache.aurora.client.cli.sla ..... SUCCESS
> src.test.python.apache.aurora.client.cli.supdate ..... SUCCESS
> src.test.python.apache.aurora.client.cli.task ..... SUCCESS
> src.test.python.apache.aurora.client.cli.update ..... SUCCESS
> src.test.python.apache.aurora.client.cli.version ..... SUCCESS
> src.test.python.apache.aurora.client.config ..... SUCCESS
> src.test.python.apache.aurora.client.hooks.hooked_api ..... SUCCESS
> src.test.python.apache.aurora.client.hooks.non_hooked_api ..... SUCCESS
>
>
> Thanks,
>
> Joe Smith
>
>
Re: Review Request 34015: Improve client update json output to
consistently use last_modified
Posted by Joe Smith <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34015/
-----------------------------------------------------------
(Updated May 11, 2015, 3:19 p.m.)
Review request for Aurora and Bill Farner.
Bugs: AURORA-1316
https://issues.apache.org/jira/browse/AURORA-1316
Repository: aurora
Description (updated)
-------
Improve client update json output to consistently use last_modified
Diffs
-----
src/main/python/apache/aurora/client/cli/update.py 58f0db0988911858156aa086ba9fea8ecfe99143
src/test/python/apache/aurora/client/cli/test_supdate.py 158d3305c5ce5f1de5e3f4f771f318cff9bf7914
Diff: https://reviews.apache.org/r/34015/diff/
Testing
-------
$ ./pants test.pytest --no-fast ./src/test/python/apache/aurora/client:all
src.test.python.apache.aurora.client.api.api ..... SUCCESS
src.test.python.apache.aurora.client.api.instance_watcher ..... SUCCESS
src.test.python.apache.aurora.client.api.job_monitor ..... SUCCESS
src.test.python.apache.aurora.client.api.mux ..... SUCCESS
src.test.python.apache.aurora.client.api.quota_check ..... SUCCESS
src.test.python.apache.aurora.client.api.restarter ..... SUCCESS
src.test.python.apache.aurora.client.api.scheduler_client ..... SUCCESS
src.test.python.apache.aurora.client.api.sla ..... SUCCESS
src.test.python.apache.aurora.client.api.task_util ..... SUCCESS
src.test.python.apache.aurora.client.api.updater ..... SUCCESS
src.test.python.apache.aurora.client.api.updater_util ..... SUCCESS
src.test.python.apache.aurora.client.base ..... SUCCESS
src.test.python.apache.aurora.client.binding_helper ..... SUCCESS
src.test.python.apache.aurora.client.cli.api ..... SUCCESS
src.test.python.apache.aurora.client.cli.client ..... SUCCESS
src.test.python.apache.aurora.client.cli.command_hooks ..... SUCCESS
src.test.python.apache.aurora.client.cli.config ..... SUCCESS
src.test.python.apache.aurora.client.cli.context ..... SUCCESS
src.test.python.apache.aurora.client.cli.cron ..... SUCCESS
src.test.python.apache.aurora.client.cli.inspect ..... SUCCESS
src.test.python.apache.aurora.client.cli.job ..... SUCCESS
src.test.python.apache.aurora.client.cli.plugins ..... SUCCESS
src.test.python.apache.aurora.client.cli.quota ..... SUCCESS
src.test.python.apache.aurora.client.cli.sla ..... SUCCESS
src.test.python.apache.aurora.client.cli.supdate ..... SUCCESS
src.test.python.apache.aurora.client.cli.task ..... SUCCESS
src.test.python.apache.aurora.client.cli.update ..... SUCCESS
src.test.python.apache.aurora.client.cli.version ..... SUCCESS
src.test.python.apache.aurora.client.config ..... SUCCESS
src.test.python.apache.aurora.client.hooks.hooked_api ..... SUCCESS
src.test.python.apache.aurora.client.hooks.non_hooked_api ..... SUCCESS
Thanks,
Joe Smith
Re: Review Request 34015: Improve client update json output to
consistently use last_modified
Posted by Joe Smith <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34015/
-----------------------------------------------------------
(Updated May 11, 2015, 3:19 p.m.)
Review request for Aurora and Bill Farner.
Changes
-------
Use snake_case
Summary (updated)
-----------------
Improve client update json output to consistently use last_modified
Bugs: AURORA-1316
https://issues.apache.org/jira/browse/AURORA-1316
Repository: aurora
Description
-------
Improve client update json output to consistently use lastModified
Diffs (updated)
-----
src/main/python/apache/aurora/client/cli/update.py 58f0db0988911858156aa086ba9fea8ecfe99143
src/test/python/apache/aurora/client/cli/test_supdate.py 158d3305c5ce5f1de5e3f4f771f318cff9bf7914
Diff: https://reviews.apache.org/r/34015/diff/
Testing
-------
$ ./pants test.pytest --no-fast ./src/test/python/apache/aurora/client:all
src.test.python.apache.aurora.client.api.api ..... SUCCESS
src.test.python.apache.aurora.client.api.instance_watcher ..... SUCCESS
src.test.python.apache.aurora.client.api.job_monitor ..... SUCCESS
src.test.python.apache.aurora.client.api.mux ..... SUCCESS
src.test.python.apache.aurora.client.api.quota_check ..... SUCCESS
src.test.python.apache.aurora.client.api.restarter ..... SUCCESS
src.test.python.apache.aurora.client.api.scheduler_client ..... SUCCESS
src.test.python.apache.aurora.client.api.sla ..... SUCCESS
src.test.python.apache.aurora.client.api.task_util ..... SUCCESS
src.test.python.apache.aurora.client.api.updater ..... SUCCESS
src.test.python.apache.aurora.client.api.updater_util ..... SUCCESS
src.test.python.apache.aurora.client.base ..... SUCCESS
src.test.python.apache.aurora.client.binding_helper ..... SUCCESS
src.test.python.apache.aurora.client.cli.api ..... SUCCESS
src.test.python.apache.aurora.client.cli.client ..... SUCCESS
src.test.python.apache.aurora.client.cli.command_hooks ..... SUCCESS
src.test.python.apache.aurora.client.cli.config ..... SUCCESS
src.test.python.apache.aurora.client.cli.context ..... SUCCESS
src.test.python.apache.aurora.client.cli.cron ..... SUCCESS
src.test.python.apache.aurora.client.cli.inspect ..... SUCCESS
src.test.python.apache.aurora.client.cli.job ..... SUCCESS
src.test.python.apache.aurora.client.cli.plugins ..... SUCCESS
src.test.python.apache.aurora.client.cli.quota ..... SUCCESS
src.test.python.apache.aurora.client.cli.sla ..... SUCCESS
src.test.python.apache.aurora.client.cli.supdate ..... SUCCESS
src.test.python.apache.aurora.client.cli.task ..... SUCCESS
src.test.python.apache.aurora.client.cli.update ..... SUCCESS
src.test.python.apache.aurora.client.cli.version ..... SUCCESS
src.test.python.apache.aurora.client.config ..... SUCCESS
src.test.python.apache.aurora.client.hooks.hooked_api ..... SUCCESS
src.test.python.apache.aurora.client.hooks.non_hooked_api ..... SUCCESS
Thanks,
Joe Smith
Re: Review Request 34015: Improve client update json output to
consistently use last_modified
Posted by Joe Smith <ya...@gmail.com>.
> On May 11, 2015, 2:29 p.m., Bill Farner wrote:
> > src/main/python/apache/aurora/client/cli/update.py, line 473
> > <https://reviews.apache.org/r/34015/diff/1/?file=954522#file954522line473>
> >
> > IMHO it's the other side that should conform to `last_modified` since snake case is used in ~all other fields.
Transitioned to `last_modified`
- Joe
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34015/#review83290
-----------------------------------------------------------
On May 11, 2015, 3:19 p.m., Joe Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34015/
> -----------------------------------------------------------
>
> (Updated May 11, 2015, 3:19 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-1316
> https://issues.apache.org/jira/browse/AURORA-1316
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Improve client update json output to consistently use last_modified
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/update.py 58f0db0988911858156aa086ba9fea8ecfe99143
> src/test/python/apache/aurora/client/cli/test_supdate.py 158d3305c5ce5f1de5e3f4f771f318cff9bf7914
>
> Diff: https://reviews.apache.org/r/34015/diff/
>
>
> Testing
> -------
>
> $ ./pants test.pytest --no-fast ./src/test/python/apache/aurora/client:all
> src.test.python.apache.aurora.client.api.api ..... SUCCESS
> src.test.python.apache.aurora.client.api.instance_watcher ..... SUCCESS
> src.test.python.apache.aurora.client.api.job_monitor ..... SUCCESS
> src.test.python.apache.aurora.client.api.mux ..... SUCCESS
> src.test.python.apache.aurora.client.api.quota_check ..... SUCCESS
> src.test.python.apache.aurora.client.api.restarter ..... SUCCESS
> src.test.python.apache.aurora.client.api.scheduler_client ..... SUCCESS
> src.test.python.apache.aurora.client.api.sla ..... SUCCESS
> src.test.python.apache.aurora.client.api.task_util ..... SUCCESS
> src.test.python.apache.aurora.client.api.updater ..... SUCCESS
> src.test.python.apache.aurora.client.api.updater_util ..... SUCCESS
> src.test.python.apache.aurora.client.base ..... SUCCESS
> src.test.python.apache.aurora.client.binding_helper ..... SUCCESS
> src.test.python.apache.aurora.client.cli.api ..... SUCCESS
> src.test.python.apache.aurora.client.cli.client ..... SUCCESS
> src.test.python.apache.aurora.client.cli.command_hooks ..... SUCCESS
> src.test.python.apache.aurora.client.cli.config ..... SUCCESS
> src.test.python.apache.aurora.client.cli.context ..... SUCCESS
> src.test.python.apache.aurora.client.cli.cron ..... SUCCESS
> src.test.python.apache.aurora.client.cli.inspect ..... SUCCESS
> src.test.python.apache.aurora.client.cli.job ..... SUCCESS
> src.test.python.apache.aurora.client.cli.plugins ..... SUCCESS
> src.test.python.apache.aurora.client.cli.quota ..... SUCCESS
> src.test.python.apache.aurora.client.cli.sla ..... SUCCESS
> src.test.python.apache.aurora.client.cli.supdate ..... SUCCESS
> src.test.python.apache.aurora.client.cli.task ..... SUCCESS
> src.test.python.apache.aurora.client.cli.update ..... SUCCESS
> src.test.python.apache.aurora.client.cli.version ..... SUCCESS
> src.test.python.apache.aurora.client.config ..... SUCCESS
> src.test.python.apache.aurora.client.hooks.hooked_api ..... SUCCESS
> src.test.python.apache.aurora.client.hooks.non_hooked_api ..... SUCCESS
>
>
> Thanks,
>
> Joe Smith
>
>
Re: Review Request 34015: Improve client update json output to
consistently use lastModified
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34015/#review83290
-----------------------------------------------------------
src/main/python/apache/aurora/client/cli/update.py
<https://reviews.apache.org/r/34015/#comment134201>
IMHO it's the other side that should conform to `last_modified` since snake case is used in ~all other fields.
- Bill Farner
On May 9, 2015, 4:57 p.m., Joe Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34015/
> -----------------------------------------------------------
>
> (Updated May 9, 2015, 4:57 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-1316
> https://issues.apache.org/jira/browse/AURORA-1316
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Improve client update json output to consistently use lastModified
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/update.py 58f0db0988911858156aa086ba9fea8ecfe99143
> src/test/python/apache/aurora/client/cli/test_supdate.py 158d3305c5ce5f1de5e3f4f771f318cff9bf7914
>
> Diff: https://reviews.apache.org/r/34015/diff/
>
>
> Testing
> -------
>
> $ ./pants test.pytest --no-fast ./src/test/python/apache/aurora/client:all
> src.test.python.apache.aurora.client.api.api ..... SUCCESS
> src.test.python.apache.aurora.client.api.instance_watcher ..... SUCCESS
> src.test.python.apache.aurora.client.api.job_monitor ..... SUCCESS
> src.test.python.apache.aurora.client.api.mux ..... SUCCESS
> src.test.python.apache.aurora.client.api.quota_check ..... SUCCESS
> src.test.python.apache.aurora.client.api.restarter ..... SUCCESS
> src.test.python.apache.aurora.client.api.scheduler_client ..... SUCCESS
> src.test.python.apache.aurora.client.api.sla ..... SUCCESS
> src.test.python.apache.aurora.client.api.task_util ..... SUCCESS
> src.test.python.apache.aurora.client.api.updater ..... SUCCESS
> src.test.python.apache.aurora.client.api.updater_util ..... SUCCESS
> src.test.python.apache.aurora.client.base ..... SUCCESS
> src.test.python.apache.aurora.client.binding_helper ..... SUCCESS
> src.test.python.apache.aurora.client.cli.api ..... SUCCESS
> src.test.python.apache.aurora.client.cli.client ..... SUCCESS
> src.test.python.apache.aurora.client.cli.command_hooks ..... SUCCESS
> src.test.python.apache.aurora.client.cli.config ..... SUCCESS
> src.test.python.apache.aurora.client.cli.context ..... SUCCESS
> src.test.python.apache.aurora.client.cli.cron ..... SUCCESS
> src.test.python.apache.aurora.client.cli.inspect ..... SUCCESS
> src.test.python.apache.aurora.client.cli.job ..... SUCCESS
> src.test.python.apache.aurora.client.cli.plugins ..... SUCCESS
> src.test.python.apache.aurora.client.cli.quota ..... SUCCESS
> src.test.python.apache.aurora.client.cli.sla ..... SUCCESS
> src.test.python.apache.aurora.client.cli.supdate ..... SUCCESS
> src.test.python.apache.aurora.client.cli.task ..... SUCCESS
> src.test.python.apache.aurora.client.cli.update ..... SUCCESS
> src.test.python.apache.aurora.client.cli.version ..... SUCCESS
> src.test.python.apache.aurora.client.config ..... SUCCESS
> src.test.python.apache.aurora.client.hooks.hooked_api ..... SUCCESS
> src.test.python.apache.aurora.client.hooks.non_hooked_api ..... SUCCESS
>
>
> Thanks,
>
> Joe Smith
>
>