You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Nitin Galave <ni...@gmail.com> on 2019/12/09 11:54:42 UTC
Re: Review Request 71896: RANGER-2655 : Ranger UI improvement
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71896/
-----------------------------------------------------------
(Updated Dec. 9, 2019, 11:54 a.m.)
Review request for ranger, Gautam Borad, Mehul Parikh, and Velmurugan Periasamy.
Bugs: RANGER-2655
https://issues.apache.org/jira/browse/RANGER-2655
Repository: ranger
Description
-------
Audit page has multiple tabs (6). It will be very useful to be able to bookmark a specific tab – like pluginStatus, plugins, etc. In addition, it will be useful to include filter criteria as well. Perhaps using query params like
index.html#!/reports/audit/bigData?Result=Allowed&Service Type=HIVE
index.html#!/reports/audit/admin?Actions=Create&User=admin
index.html#!/reports/audit/loginSession?Result=Success
index.html#!/reports/audit/agent?Service Name=hdfs_service1
index.html#!/reports/audit/pluginStatus?Service Type=hdfs
Similarly for AccessManager pages as well
index.html#!/policymanager/resource?Security Zone=Production
index.html#!/policymanager/tag?Security Zone=Staging
index.html#!/service/1/policies?Security Zone=Production
Please review other tabs/pages as well for similar updates
Diffs
-----
security-admin/src/main/webapp/scripts/controllers/Controller.js 072323a
security-admin/src/main/webapp/scripts/model_bases/UserPermissionBase.js 3751362
security-admin/src/main/webapp/scripts/modules/XALinks.js 5420f11
security-admin/src/main/webapp/scripts/routers/Router.js b9ea66b
security-admin/src/main/webapp/scripts/utils/XAUtils.js f0e0be0
security-admin/src/main/webapp/scripts/views/kms/KMSTableLayout.js d6521c6
security-admin/src/main/webapp/scripts/views/permissions/ModulePermissionCreate.js 2a66312
security-admin/src/main/webapp/scripts/views/permissions/ModulePermsTableLayout.js 9db72a7
security-admin/src/main/webapp/scripts/views/policies/RangerPolicyTableLayout.js 1209c6d
security-admin/src/main/webapp/scripts/views/policymanager/ServiceLayout.js d190686
security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js b0cb508
security-admin/src/main/webapp/scripts/views/users/UserTableLayout.js 4050849
security-admin/src/main/webapp/templates/common/TopNav_tmpl.html 8ed90aa
Diff: https://reviews.apache.org/r/71896/diff/1/
Testing
-------
1.Checked search functionality in all search fields.
2.Checked search functionality for URL based search bookmark.
3.Checked search functionality for role based users.
Thanks,
Nitin Galave
Re: Review Request 71896: RANGER-2655 : Ranger UI improvement
Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71896/#review219003
-----------------------------------------------------------
Ship it!
Ship It!
- Velmurugan Periasamy
On Dec. 9, 2019, 11:54 a.m., Nitin Galave wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71896/
> -----------------------------------------------------------
>
> (Updated Dec. 9, 2019, 11:54 a.m.)
>
>
> Review request for ranger, Gautam Borad, Mehul Parikh, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-2655
> https://issues.apache.org/jira/browse/RANGER-2655
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Audit page has multiple tabs (6). It will be very useful to be able to bookmark a specific tab – like pluginStatus, plugins, etc. In addition, it will be useful to include filter criteria as well. Perhaps using query params like
>
> index.html#!/reports/audit/bigData?Result=Allowed&Service Type=HIVE
> index.html#!/reports/audit/admin?Actions=Create&User=admin
> index.html#!/reports/audit/loginSession?Result=Success
> index.html#!/reports/audit/agent?Service Name=hdfs_service1
> index.html#!/reports/audit/pluginStatus?Service Type=hdfs
> Similarly for AccessManager pages as well
>
> index.html#!/policymanager/resource?Security Zone=Production
> index.html#!/policymanager/tag?Security Zone=Staging
> index.html#!/service/1/policies?Security Zone=Production
> Please review other tabs/pages as well for similar updates
>
>
> Diffs
> -----
>
> security-admin/src/main/webapp/scripts/controllers/Controller.js 072323a
> security-admin/src/main/webapp/scripts/model_bases/UserPermissionBase.js 3751362
> security-admin/src/main/webapp/scripts/modules/XALinks.js 5420f11
> security-admin/src/main/webapp/scripts/routers/Router.js b9ea66b
> security-admin/src/main/webapp/scripts/utils/XAUtils.js f0e0be0
> security-admin/src/main/webapp/scripts/views/kms/KMSTableLayout.js d6521c6
> security-admin/src/main/webapp/scripts/views/permissions/ModulePermissionCreate.js 2a66312
> security-admin/src/main/webapp/scripts/views/permissions/ModulePermsTableLayout.js 9db72a7
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyTableLayout.js 1209c6d
> security-admin/src/main/webapp/scripts/views/policymanager/ServiceLayout.js d190686
> security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js b0cb508
> security-admin/src/main/webapp/scripts/views/users/UserTableLayout.js 4050849
> security-admin/src/main/webapp/templates/common/TopNav_tmpl.html 8ed90aa
>
>
> Diff: https://reviews.apache.org/r/71896/diff/1/
>
>
> Testing
> -------
>
> 1.Checked search functionality in all search fields.
> 2.Checked search functionality for URL based search bookmark.
> 3.Checked search functionality for role based users.
>
>
> Thanks,
>
> Nitin Galave
>
>
Re: Review Request 71896: RANGER-2655 : Ranger UI improvement
Posted by Mehul Parikh <me...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71896/#review218997
-----------------------------------------------------------
Ship it!
Ship It!
- Mehul Parikh
On Dec. 9, 2019, 11:54 a.m., Nitin Galave wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71896/
> -----------------------------------------------------------
>
> (Updated Dec. 9, 2019, 11:54 a.m.)
>
>
> Review request for ranger, Gautam Borad, Mehul Parikh, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-2655
> https://issues.apache.org/jira/browse/RANGER-2655
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Audit page has multiple tabs (6). It will be very useful to be able to bookmark a specific tab – like pluginStatus, plugins, etc. In addition, it will be useful to include filter criteria as well. Perhaps using query params like
>
> index.html#!/reports/audit/bigData?Result=Allowed&Service Type=HIVE
> index.html#!/reports/audit/admin?Actions=Create&User=admin
> index.html#!/reports/audit/loginSession?Result=Success
> index.html#!/reports/audit/agent?Service Name=hdfs_service1
> index.html#!/reports/audit/pluginStatus?Service Type=hdfs
> Similarly for AccessManager pages as well
>
> index.html#!/policymanager/resource?Security Zone=Production
> index.html#!/policymanager/tag?Security Zone=Staging
> index.html#!/service/1/policies?Security Zone=Production
> Please review other tabs/pages as well for similar updates
>
>
> Diffs
> -----
>
> security-admin/src/main/webapp/scripts/controllers/Controller.js 072323a
> security-admin/src/main/webapp/scripts/model_bases/UserPermissionBase.js 3751362
> security-admin/src/main/webapp/scripts/modules/XALinks.js 5420f11
> security-admin/src/main/webapp/scripts/routers/Router.js b9ea66b
> security-admin/src/main/webapp/scripts/utils/XAUtils.js f0e0be0
> security-admin/src/main/webapp/scripts/views/kms/KMSTableLayout.js d6521c6
> security-admin/src/main/webapp/scripts/views/permissions/ModulePermissionCreate.js 2a66312
> security-admin/src/main/webapp/scripts/views/permissions/ModulePermsTableLayout.js 9db72a7
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyTableLayout.js 1209c6d
> security-admin/src/main/webapp/scripts/views/policymanager/ServiceLayout.js d190686
> security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js b0cb508
> security-admin/src/main/webapp/scripts/views/users/UserTableLayout.js 4050849
> security-admin/src/main/webapp/templates/common/TopNav_tmpl.html 8ed90aa
>
>
> Diff: https://reviews.apache.org/r/71896/diff/1/
>
>
> Testing
> -------
>
> 1.Checked search functionality in all search fields.
> 2.Checked search functionality for URL based search bookmark.
> 3.Checked search functionality for role based users.
>
>
> Thanks,
>
> Nitin Galave
>
>