You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Paulex Yang (JIRA)" <ji...@apache.org> on 2006/03/30 04:13:28 UTC
[jira] Created: (HARMONY-275) o.a.h.nio.internal should not be
exported
o.a.h.nio.internal should not be exported
-----------------------------------------
Key: HARMONY-275
URL: http://issues.apache.org/jira/browse/HARMONY-275
Project: Harmony
Type: Improvement
Components: Classlib
Reporter: Paulex Yang
Priority: Minor
The o.a.h.nio.internal is exported by NIO and imported by LUNI, which violates Harmony package naming convention. Look deeper into the dependency, only java.io.FileChannelFactory refers three classes in this package. So I suggest to move this class to o.a.h.nio, and export this class only.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (HARMONY-275) o.a.h.nio.internal should not be
exported
Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-275?page=all ]
Tim Ellison closed HARMONY-275:
-------------------------------
Verified by Paulex
> o.a.h.nio.internal should not be exported
> -----------------------------------------
>
> Key: HARMONY-275
> URL: http://issues.apache.org/jira/browse/HARMONY-275
> Project: Harmony
> Type: Improvement
> Components: Classlib
> Reporter: Paulex Yang
> Assignee: Tim Ellison
> Priority: Minor
> Attachments: jira-275.zip
>
> The o.a.h.nio.internal is exported by NIO and imported by LUNI, which violates Harmony package naming convention. Look deeper into the dependency, only java.io.FileChannelFactory refers three classes in this package. So I suggest to move this class to o.a.h.nio, and export this class only.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Assigned: (HARMONY-275) o.a.h.nio.internal should not be
exported
Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-275?page=all ]
Tim Ellison reassigned HARMONY-275:
-----------------------------------
Assign To: Tim Ellison
> o.a.h.nio.internal should not be exported
> -----------------------------------------
>
> Key: HARMONY-275
> URL: http://issues.apache.org/jira/browse/HARMONY-275
> Project: Harmony
> Type: Improvement
> Components: Classlib
> Reporter: Paulex Yang
> Assignee: Tim Ellison
> Priority: Minor
> Attachments: jira-275.zip
>
> The o.a.h.nio.internal is exported by NIO and imported by LUNI, which violates Harmony package naming convention. Look deeper into the dependency, only java.io.FileChannelFactory refers three classes in this package. So I suggest to move this class to o.a.h.nio, and export this class only.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Resolved: (HARMONY-275) o.a.h.nio.internal should not be
exported
Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-275?page=all ]
Tim Ellison resolved HARMONY-275:
---------------------------------
Resolution: Fixed
Thanks Paulex,
Patch applied to LUNI and NIO modules plus patternsets at repo revision 390171.
Please check that the patch was applied as you expected.
> o.a.h.nio.internal should not be exported
> -----------------------------------------
>
> Key: HARMONY-275
> URL: http://issues.apache.org/jira/browse/HARMONY-275
> Project: Harmony
> Type: Improvement
> Components: Classlib
> Reporter: Paulex Yang
> Assignee: Tim Ellison
> Priority: Minor
> Attachments: jira-275.zip
>
> The o.a.h.nio.internal is exported by NIO and imported by LUNI, which violates Harmony package naming convention. Look deeper into the dependency, only java.io.FileChannelFactory refers three classes in this package. So I suggest to move this class to o.a.h.nio, and export this class only.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-275) o.a.h.nio.internal should not be
exported
Posted by "Paulex Yang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-275?page=comments#action_12372637 ]
Paulex Yang commented on HARMONY-275:
-------------------------------------
looks good, thank you, Tim.
> o.a.h.nio.internal should not be exported
> -----------------------------------------
>
> Key: HARMONY-275
> URL: http://issues.apache.org/jira/browse/HARMONY-275
> Project: Harmony
> Type: Improvement
> Components: Classlib
> Reporter: Paulex Yang
> Assignee: Tim Ellison
> Priority: Minor
> Attachments: jira-275.zip
>
> The o.a.h.nio.internal is exported by NIO and imported by LUNI, which violates Harmony package naming convention. Look deeper into the dependency, only java.io.FileChannelFactory refers three classes in this package. So I suggest to move this class to o.a.h.nio, and export this class only.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-275) o.a.h.nio.internal should not be
exported
Posted by "Paulex Yang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-275?page=all ]
Paulex Yang updated HARMONY-275:
--------------------------------
Attachment: jira-275.zip
pls. try movefiles.sh and apply FileChannelFactory.diff at first, then apply other patches to nio, luni and patternsets respectively.
> o.a.h.nio.internal should not be exported
> -----------------------------------------
>
> Key: HARMONY-275
> URL: http://issues.apache.org/jira/browse/HARMONY-275
> Project: Harmony
> Type: Improvement
> Components: Classlib
> Reporter: Paulex Yang
> Priority: Minor
> Attachments: jira-275.zip
>
> The o.a.h.nio.internal is exported by NIO and imported by LUNI, which violates Harmony package naming convention. Look deeper into the dependency, only java.io.FileChannelFactory refers three classes in this package. So I suggest to move this class to o.a.h.nio, and export this class only.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira