You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "anniejili (via GitHub)" <gi...@apache.org> on 2024/01/09 04:00:02 UTC
[PR] Adding uuid as part of error response when vm create fails [cloudstack]
anniejili opened a new pull request, #8471:
URL: https://github.com/apache/cloudstack/pull/8471
### Description
This PR fixes: https://github.com/shapeblue/cloudstack-apple/issues/298
If there is a failure during VM create after vm entity is persisted, Vm UUID will be included as part of the error response.
{
"deployvirtualmachineresponse": {
"uuidList": [
{
**"serialVersionUID": -7514266713085362000,
"uuid": "f1a9a209-20a8-42ce-8f5c-457f2f560e95",
"description": "vmId"**
}
],
"errorcode": 530,
"cserrorcode": 4250,
"errortext": “Error text”
}
}
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [X] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [X] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
DeployVm API response without fix:
{
"deployvirtualmachineresponse": {
"uuidList": [],
"errorcode": 530,
"cserrorcode": 4250,
"errortext": “Error text”
}
}
After Fix:
{
"deployvirtualmachineresponse": {
"uuidList": [
{
**"serialVersionUID": -7514266713085362000,
"uuid": "f1a9a209-20a8-42ce-8f5c-457f2f560e95",
"description": "vmId"**
}
],
"errorcode": 530,
"cserrorcode": 4250,
"errortext": “Error text”
}
}
### How Has This Been Tested?
Change was tested in my own development environment.
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Adding uuid as part of error response when vm create fails [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8471:
URL: https://github.com/apache/cloudstack/pull/8471#issuecomment-1882475017
@kiranchavala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Adding uuid as part of error response when vm create fails [cloudstack]
Posted by "kiranchavala (via GitHub)" <gi...@apache.org>.
kiranchavala commented on PR #8471:
URL: https://github.com/apache/cloudstack/pull/8471#issuecomment-1882473609
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Adding uuid as part of error response when vm create fails [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8471:
URL: https://github.com/apache/cloudstack/pull/8471#issuecomment-1882659132
Packaging result [SF]: ✖️ el7 ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 8247
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Adding uuid as part of error response when vm create fails [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8471:
URL: https://github.com/apache/cloudstack/pull/8471#issuecomment-1882528373
Packaging result [SF]: ✖️ el7 ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 8243
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Adding uuid as part of error response when vm create fails [cloudstack]
Posted by "anniejili (via GitHub)" <gi...@apache.org>.
anniejili closed pull request #8471: Adding uuid as part of error response when vm create fails
URL: https://github.com/apache/cloudstack/pull/8471
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Adding uuid as part of error response when vm create fails [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #8471:
URL: https://github.com/apache/cloudstack/pull/8471#issuecomment-1882771329
@anniejili , please have a look at https://github.com/apache/cloudstack/actions/runs/7456453740/job/20293014262?pr=8471#step:7:9128
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org