You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2023/02/02 17:02:40 UTC
[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #5155: chore: add object_name_to_table_reference in SqlToRel
alamb commented on code in PR #5155:
URL: https://github.com/apache/arrow-datafusion/pull/5155#discussion_r1094817267
##########
datafusion/sql/src/relation/mod.rs:
##########
@@ -33,10 +31,7 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
let (plan, alias) = match relation {
TableFactor::Table { name, alias, .. } => {
// normalize name and alias
- let table_ref = object_name_to_table_reference(
- name,
- self.options.enable_ident_normalization,
- )?;
+ let table_ref = self.object_name_to_table_reference(name)?;
Review Comment:
👍
##########
docs/source/user-guide/configs.md:
##########
@@ -69,3 +69,5 @@ Environment variables are read during `SessionConfig` initialisation so they mus
| datafusion.optimizer.hash_join_single_partition_threshold | 1048576 | The maximum estimated size in bytes for one input side of a HashJoin will be collected into a single partition |
| datafusion.explain.logical_plan_only | false | When set to true, the explain statement will only print logical plans |
| datafusion.explain.physical_plan_only | false | When set to true, the explain statement will only print physical plans |
+| datafusion.sql_parser.parse_float_as_decimal | false | When set to true, sql parser will parse float as decimal type |
Review Comment:
Thank you for this too 👍
##########
datafusion/common/src/config.rs:
##########
@@ -181,10 +181,10 @@ config_namespace! {
config_namespace! {
/// Options related to SQL parser
pub struct SqlParserOptions {
- /// Whether to parse float as decimal
+ /// When set to true, sql parser will parse float as decimal type
pub parse_float_as_decimal: bool, default = false
- /// Whether to normalize ident
+ /// When set to true, sql parser will normalize ident(convert ident to lowercase when not quoted)
Review Comment:
❤️
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org