[GitHub] [pulsar] jiazhai commented on a change in pull request #4331: Feature - reset cursor on Reader to current position

[GitBox <gi...@apache.org>]

jiazhai commented on a change in pull request #4331: Feature - reset cursor on Reader to current position
URL: https://github.com/apache/pulsar/pull/4331#discussion_r287245543
 
 

 ##########
 File path: pulsar-broker/src/test/java/org/apache/pulsar/client/api/TopicReaderTest.java
 ##########
 @@ -650,4 +647,44 @@ public void testReaderIsAbleToSeekWithTimeOnMiddleOfTopic() throws Exception {
         reader.close();
         producer.close();
     }
+
+    @Test
+    public void testReaderStartMessageIdInclusiveCurrentPos() throws Exception {
+        final int numOfMessage = 10;
+        final String topicName = "persistent://my-property/my-ns/testReaderStartMessageIdInclusiveCurrentPos";
+        final int resetIndex = new Random().nextInt(numOfMessage); // Choose some random index to reset
+
+        Producer<byte[]> producer = pulsarClient.newProducer()
 
 Review comment:
   Seems default producer is batch enabled, How about also add a test for batch disable? @lovelle 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services