You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2021/04/08 12:15:43 UTC
[GitHub] [zeppelin] PrarthiJain opened a new pull request #4089: [ZEPPELIN-5314]. Upgrade thrift to 0.14.1
PrarthiJain opened a new pull request #4089:
URL: https://github.com/apache/zeppelin/pull/4089
### What is this PR for?
• This PR is to upgrade thrift to 0.14.1
### What type of PR is it?
• [Improvement]
### Todos
• [ ] - Task
### What is the Jira issue?
• https://issues.apache.org/jira/browse/ZEPPELIN-5314
### How should this be tested?
• CI pass
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] zjffdu commented on pull request #4089: [ZEPPELIN-5249]. Update to thrift 0.14.1
Posted by GitBox <gi...@apache.org>.
zjffdu commented on pull request #4089:
URL: https://github.com/apache/zeppelin/pull/4089#issuecomment-849325647
@PrarthiJain I made a hotfix for the CI, please rebase your PR and trigger the CI again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] PrarthiJain commented on pull request #4089: [ZEPPELIN-5249]. Update to thrift 0.14.1
Posted by GitBox <gi...@apache.org>.
PrarthiJain commented on pull request #4089:
URL: https://github.com/apache/zeppelin/pull/4089#issuecomment-858489147
It seems the Alluxio Interpreter Test is failing, should be fixed with- #2900.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] PrarthiJain commented on pull request #4089: [ZEPPELIN-5249]. Update to thrift 0.14.1
Posted by GitBox <gi...@apache.org>.
PrarthiJain commented on pull request #4089:
URL: https://github.com/apache/zeppelin/pull/4089#issuecomment-829880959
@Reamer The checks are unexpectedly failing. Could you please help with this, along with the code review? Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] PrarthiJain commented on pull request #4089: [ZEPPELIN-5249]. Update to thrift 0.14.1
Posted by GitBox <gi...@apache.org>.
PrarthiJain commented on pull request #4089:
URL: https://github.com/apache/zeppelin/pull/4089#issuecomment-849673788
Thanks @zjffdu
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Reamer commented on pull request #4089: [ZEPPELIN-5249]. Update to thrift 0.14.1
Posted by GitBox <gi...@apache.org>.
Reamer commented on pull request #4089:
URL: https://github.com/apache/zeppelin/pull/4089#issuecomment-831313150
CI is currently broken.
Please rebase after #4107 is merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] PrarthiJain commented on pull request #4089: [ZEPPELIN-5314]. Upgrade thrift to 0.14.1
Posted by GitBox <gi...@apache.org>.
PrarthiJain commented on pull request #4089:
URL: https://github.com/apache/zeppelin/pull/4089#issuecomment-816593386
Thanks, @Reamer. Could you please help with the steps to test for a successful shutdown of the Zeppelin interpreter?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] PrarthiJain commented on pull request #4089: [ZEPPELIN-5249]. Update to thrift 0.14.1
Posted by GitBox <gi...@apache.org>.
PrarthiJain commented on pull request #4089:
URL: https://github.com/apache/zeppelin/pull/4089#issuecomment-842189288
@Reamer @zjffdu @prabhjyotsingh. I have uploaded a new patch with thrift dependency addition. We can remove that later on the 4.0 version upgrade. Let me know your thoughts. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] zjffdu commented on pull request #4089: [ZEPPELIN-5249]. Update to thrift 0.14.1
Posted by GitBox <gi...@apache.org>.
zjffdu commented on pull request #4089:
URL: https://github.com/apache/zeppelin/pull/4089#issuecomment-857666057
@PrarthiJain Could you check the failed test ? AFAIK, `frontend / test-selenium-with-spark-module-for-spark-2-3` and `core / jdbcIntegrationTest-and-unit-test-of-Spark-2-4-with-Scala-2-11` has flaky tests, others should be successful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] PrarthiJain commented on pull request #4089: [ZEPPELIN-5314]. Upgrade thrift to 0.14.1
Posted by GitBox <gi...@apache.org>.
PrarthiJain commented on pull request #4089:
URL: https://github.com/apache/zeppelin/pull/4089#issuecomment-815744305
@prabhjyotsingh @VipinRathor @zjffdu, Could you please help in reviewing? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] PrarthiJain commented on pull request #4089: [ZEPPELIN-5249]. Update to thrift 0.14.1
Posted by GitBox <gi...@apache.org>.
PrarthiJain commented on pull request #4089:
URL: https://github.com/apache/zeppelin/pull/4089#issuecomment-859394558
@zjffdu Those were succeeded after re-triggering on my forked repo. However, I think I don't have permission to re-trigger and check the failed tests here. Do I need to upload a new patch again? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] PrarthiJain commented on pull request #4089: [ZEPPELIN-5249]. Update to thrift 0.14.2
Posted by GitBox <gi...@apache.org>.
PrarthiJain commented on pull request #4089:
URL: https://github.com/apache/zeppelin/pull/4089#issuecomment-880505563
@Reamer @zjffdu @prabhjyotsingh, I have updated the patch. Could you please help to review it? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] zjffdu commented on pull request #4089: [ZEPPELIN-5249]. Update to thrift 0.14.1
Posted by GitBox <gi...@apache.org>.
zjffdu commented on pull request #4089:
URL: https://github.com/apache/zeppelin/pull/4089#issuecomment-841599554
ping @PrarthiJain
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Reamer commented on pull request #4089: [ZEPPELIN-5314]. Upgrade thrift to 0.14.1
Posted by GitBox <gi...@apache.org>.
Reamer commented on pull request #4089:
URL: https://github.com/apache/zeppelin/pull/4089#issuecomment-816508269
This PR also affects #4072, which still uses the old Thrift version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] zjffdu commented on pull request #4089: [ZEPPELIN-5249]. Update to thrift 0.14.1
Posted by GitBox <gi...@apache.org>.
zjffdu commented on pull request #4089:
URL: https://github.com/apache/zeppelin/pull/4089#issuecomment-842418305
It looks like cause spark/flink tests fail
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Reamer commented on pull request #4089: [ZEPPELIN-5249]. Update to thrift 0.14.1
Posted by GitBox <gi...@apache.org>.
Reamer commented on pull request #4089:
URL: https://github.com/apache/zeppelin/pull/4089#issuecomment-838263771
Please take a look at the Cassandra interpreter. I think the following stack trace relates to your change.
```
WARN [07:27:58,378][] org.apache.cassandra.db.SystemKeyspace@:getLocalHostId No host ID found, created 729402a1-a3b2-482a-aeb7-7238ab0f53ff (Note: This should happen exactly once per node).
Exception (java.lang.NoClassDefFoundError) encountered during startup: org/apache/thrift/transport/TFramedTransport$Factory
java.lang.NoClassDefFoundError: org/apache/thrift/transport/TFramedTransport$Factory
at org.apache.cassandra.service.CassandraDaemon.setup(CassandraDaemon.java:435)
at org.apache.cassandra.service.CassandraDaemon.activate(CassandraDaemon.java:620)
at org.cassandraunit.utils.EmbeddedCassandraServerHelper.lambda$startEmbeddedCassandra$1(EmbeddedCassandraServerHelper.java:152)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
Caused by: java.lang.ClassNotFoundException: org.apache.thrift.transport.TFramedTransport$Factory
at java.net.URLClassLoader.findClass(URLClassLoader.java:382)
at java.lang.ClassLoader.loadClass(ClassLoader.java:419)
at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:352)
at java.lang.ClassLoader.loadClass(ClassLoader.java:352)
... 6 more
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Reamer edited a comment on pull request #4089: [ZEPPELIN-5314]. Upgrade thrift to 0.14.1
Posted by GitBox <gi...@apache.org>.
Reamer edited a comment on pull request #4089:
URL: https://github.com/apache/zeppelin/pull/4089#issuecomment-815769361
Please remove your changes in the zeppelin-web submodule. I closed your JIRA ticket because it duplicates another one. Please change your PR title and link in your PR text.
Maybe we can remove the `System.exit(0)` for a clean shutdown of the Zeppelin interpreter. It would be nice if you could test this. See https://issues.apache.org/jira/browse/ZEPPELIN-5249
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Reamer commented on pull request #4089: [ZEPPELIN-5314]. Upgrade thrift to 0.14.1
Posted by GitBox <gi...@apache.org>.
Reamer commented on pull request #4089:
URL: https://github.com/apache/zeppelin/pull/4089#issuecomment-815769361
Please remove your changes in the zeppelin-web submodule. I closed your JIRA ticket because it duplicates another one. Please change your PR title and link to your PR text.
Maybe we can remove the `System.exit(0)` for a clean shutdown of the Zeppelin interpreter. It would be nice if you could test this. See https://issues.apache.org/jira/browse/ZEPPELIN-5249
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] PrarthiJain commented on pull request #4089: [ZEPPELIN-5249]. Update to thrift 0.14.2
Posted by GitBox <gi...@apache.org>.
PrarthiJain commented on pull request #4089:
URL: https://github.com/apache/zeppelin/pull/4089#issuecomment-886389279
Thanks, @Reamer. Sure will wait till the next release of [maven-shade-plugin](https://github.com/apache/maven-shade-plugin/releases)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Reamer commented on pull request #4089: [ZEPPELIN-5249]. Update to thrift 0.14.1
Posted by GitBox <gi...@apache.org>.
Reamer commented on pull request #4089:
URL: https://github.com/apache/zeppelin/pull/4089#issuecomment-863830861
Thrift 0.14.2 has been released.
This version also fixed a [regression in the Java library](https://github.com/apache/thrift/commit/d604602064e9218cc1f0153a4f83dff22fa1b44e).
Maybe we should wait for this version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] zjffdu commented on pull request #4089: [ZEPPELIN-5249]. Update to thrift 0.14.1
Posted by GitBox <gi...@apache.org>.
zjffdu commented on pull request #4089:
URL: https://github.com/apache/zeppelin/pull/4089#issuecomment-862140754
@PrarthiJain AlluxioInterpreterTest is failed https://github.com/apache/zeppelin/pull/4089/checks?check_run_id=2801927837
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] zjffdu commented on pull request #4089: [ZEPPELIN-5249]. Update to thrift 0.14.1
Posted by GitBox <gi...@apache.org>.
zjffdu commented on pull request #4089:
URL: https://github.com/apache/zeppelin/pull/4089#issuecomment-842418305
It looks like cause spark/flink tests fail
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Reamer commented on pull request #4089: [ZEPPELIN-5249]. Update to thrift 0.14.2
Posted by GitBox <gi...@apache.org>.
Reamer commented on pull request #4089:
URL: https://github.com/apache/zeppelin/pull/4089#issuecomment-882361700
> @Reamer @zjffdu @prabhjyotsingh, I have updated the patch. Could you please help to review it? Thanks.
I think your problems with updating the Thrift version are due to the ugly use of the interpreter shade jar.
https://github.com/apache/zeppelin/blob/0ec89755d3155c254bdf33cb7e9603f10708af65/zeppelin-interpreter-parent/pom.xml#L35-L46
I am trying to solve the problem in my [interpreter_shade](https://github.com/Reamer/zeppelin/tree/interpreter_shade) branch. . But the changes depend on an update of the shade-plugin (https://github.com/apache/maven-shade-plugin/pull/100 or https://github.com/apache/maven-shade-plugin/pull/105) because Intellji does not use the shading jars [IDEA-93855](https://youtrack.jetbrains.com/issue/IDEA-93855) correctly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Reamer commented on pull request #4089: [ZEPPELIN-5249]. Update to thrift 0.14.1
Posted by GitBox <gi...@apache.org>.
Reamer commented on pull request #4089:
URL: https://github.com/apache/zeppelin/pull/4089#issuecomment-832547830
#4107 was merged. Please rebase to current master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] zjffdu commented on pull request #4089: [ZEPPELIN-5249]. Update to thrift 0.14.1
Posted by GitBox <gi...@apache.org>.
zjffdu commented on pull request #4089:
URL: https://github.com/apache/zeppelin/pull/4089#issuecomment-868963265
ping @PrarthiJain
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Reamer commented on pull request #4089: [ZEPPELIN-5249]. Update to thrift 0.14.2
Posted by GitBox <gi...@apache.org>.
Reamer commented on pull request #4089:
URL: https://github.com/apache/zeppelin/pull/4089#issuecomment-882361700
> @Reamer @zjffdu @prabhjyotsingh, I have updated the patch. Could you please help to review it? Thanks.
I think your problems with updating the Thrift version are due to the ugly use of the interpreter shade jar.
https://github.com/apache/zeppelin/blob/0ec89755d3155c254bdf33cb7e9603f10708af65/zeppelin-interpreter-parent/pom.xml#L35-L46
I am trying to solve the problem in my [interpreter_shade](https://github.com/Reamer/zeppelin/tree/interpreter_shade) branch. . But the changes depend on an update of the shade-plugin (https://github.com/apache/maven-shade-plugin/pull/100 or https://github.com/apache/maven-shade-plugin/pull/105) because Intellji does not use the shading jars [IDEA-93855](https://youtrack.jetbrains.com/issue/IDEA-93855) correctly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Reamer commented on pull request #4089: [ZEPPELIN-5314]. Upgrade thrift to 0.14.1
Posted by GitBox <gi...@apache.org>.
Reamer commented on pull request #4089:
URL: https://github.com/apache/zeppelin/pull/4089#issuecomment-816623685
> Thanks, @Reamer. Could you please help with the steps to test for a successful shutdown of the Zeppelin interpreter?
After #4072 has been merged, I can help you,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] PrarthiJain commented on pull request #4089: [ZEPPELIN-5249]. Update to thrift 0.14.1
Posted by GitBox <gi...@apache.org>.
PrarthiJain commented on pull request #4089:
URL: https://github.com/apache/zeppelin/pull/4089#issuecomment-848525337
@Reamer @zjffdu @prabhjyotsingh, The build failed with `Could not resolve dependencies for...from/to maven-default-http-blocker (http://0.0.0.0/): Blocked mirror for repositories: ...`. Could you please help? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] zjffdu commented on pull request #4089: [ZEPPELIN-5249]. Update to thrift 0.14.1
Posted by GitBox <gi...@apache.org>.
zjffdu commented on pull request #4089:
URL: https://github.com/apache/zeppelin/pull/4089#issuecomment-848528028
@PrarthiJain I also notice that today, I am looking into this issue, will keep you updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] PrarthiJain commented on pull request #4089: [ZEPPELIN-5249]. Update to thrift 0.14.1
Posted by GitBox <gi...@apache.org>.
PrarthiJain commented on pull request #4089:
URL: https://github.com/apache/zeppelin/pull/4089#issuecomment-842189288
@Reamer @zjffdu @prabhjyotsingh. I have uploaded a new patch with thrift dependency addition. We can remove that later on the 4.0 version upgrade. Let me know your thoughts. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] zjffdu commented on pull request #4089: [ZEPPELIN-5249]. Update to thrift 0.14.1
Posted by GitBox <gi...@apache.org>.
zjffdu commented on pull request #4089:
URL: https://github.com/apache/zeppelin/pull/4089#issuecomment-859235027
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org