You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by "ShawnJim (via GitHub)" <gi...@apache.org> on 2023/11/02 09:36:29 UTC

[PR] [BUG #5268] Fix bug when registering with Eureka through EurekaInstanceRegisterRepository#persistInstance. [shenyu]

ShawnJim opened a new pull request, #5269:
URL: https://github.com/apache/shenyu/pull/5269

   ref #5268.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [BUG #5268] Fix bug when registering with Eureka through EurekaInstanceRegisterRepository#persistInstance. [shenyu]

Posted by "ShawnJim (via GitHub)" <gi...@apache.org>.
ShawnJim commented on code in PR #5269:
URL: https://github.com/apache/shenyu/pull/5269#discussion_r1381296561


##########
shenyu-registry/shenyu-registry-eureka/src/main/java/org/apache/shenyu/registry/eureka/EurekaInstanceRegisterRepository.java:
##########
@@ -50,36 +50,120 @@ public class EurekaInstanceRegisterRepository implements ShenyuInstanceRegisterR
 
     private EurekaClient eurekaClient;
 
-    private EurekaHttpClient eurekaHttpClient;
+    private DefaultEurekaClientConfig eurekaClientConfig;
+
+    private EurekaInstanceConfig eurekaInstanceConfig;
+
+    @Inject(optional = true)
+    private VipAddressResolver vipAddressResolver;
 
     @Override
     public void init(final RegisterConfig config) {
-        ConfigurationManager.getConfigInstance().setProperty("eureka.client.service-url.defaultZone", config.getServerLists());
-        ConfigurationManager.getConfigInstance().setProperty("eureka.serviceUrl.default", config.getServerLists());
-        ApplicationInfoManager applicationInfoManager = initializeApplicationInfoManager(new MyDataCenterInstanceConfig());
-        eurekaClient = new DiscoveryClient(applicationInfoManager, new DefaultEurekaClientConfig());
-        eurekaHttpClient = new JerseyApplicationClient(new ApacheHttpClient4(), config.getServerLists(), null);
-    }
-
-    private ApplicationInfoManager initializeApplicationInfoManager(final EurekaInstanceConfig instanceConfig) {
-        InstanceInfo instanceInfo = new EurekaConfigBasedInstanceInfoProvider(instanceConfig).get();
-        return new ApplicationInfoManager(instanceConfig, instanceInfo);
+        eurekaInstanceConfig = new MyDataCenterInstanceConfig();
+        eurekaClientConfig = new DefaultEurekaClientConfig() {
+            @Override
+            public List<String> getEurekaServerServiceUrls(final String zone) {
+                return Arrays.asList(config.getServerLists().split(","));
+            }
+        };
     }
 
     @Override
     public void persistInstance(final InstanceEntity instance) {
-        EurekaHttpResponse<Void> register = eurekaHttpClient.register(generateInstanceInfo(instance));
-        LOGGER.info("eureka client register success: {}", register.getEntity());
-    }
-
-    private InstanceInfo generateInstanceInfo(final InstanceEntity instance) {
-        return InstanceInfo.Builder.newBuilder()
-                .setAppName(instance.getAppName())
-                .setIPAddr(IpUtils.getHost())
+        InstanceInfo.Builder instanceInfoBuilder = instanceInfoBuilder();
+        instanceInfoBuilder.setAppName(instance.getAppName())
+                .setIPAddr(instance.getHost())
                 .setHostName(instance.getHost())
                 .setPort(instance.getPort())
-                .setDataCenterInfo(new MyDataCenterInfo(DataCenterInfo.Name.MyOwn))
-                .build();
+                .setStatus(InstanceInfo.InstanceStatus.UP);
+        InstanceInfo instanceInfo = instanceInfoBuilder.build();
+        LeaseInfo.Builder leaseInfoBuilder = LeaseInfo.Builder.newBuilder()
+                .setRenewalIntervalInSecs(eurekaInstanceConfig.getLeaseRenewalIntervalInSeconds())
+                .setDurationInSecs(eurekaInstanceConfig.getLeaseExpirationDurationInSeconds());
+        instanceInfo.setLeaseInfo(leaseInfoBuilder.build());
+        ApplicationInfoManager applicationInfoManager = new ApplicationInfoManager(eurekaInstanceConfig, instanceInfo);
+        eurekaClient = new DiscoveryClient(applicationInfoManager, eurekaClientConfig);
+    }
+
+    /**
+     * Gets the instance information from the config instance and returns it after setting the appropriate status.
+     * ref: com.netflix.appinfo.providers.EurekaConfigBasedInstanceInfoProvider#get
+     *
+     * @return InstanceInfo instance to be registered with eureka server
+     */
+    public InstanceInfo.Builder instanceInfoBuilder() {
+        // Build the lease information to be passed to the server based on config
+        if (vipAddressResolver == null) {
+            vipAddressResolver = new Archaius1VipAddressResolver();
+        }
+
+        // Builder the instance information to be registered with eureka server
+        final InstanceInfo.Builder builder = InstanceInfo.Builder.newBuilder(vipAddressResolver);
+
+        // set the appropriate id for the InstanceInfo, falling back to datacenter Id if applicable, else hostname
+        String instanceId = eurekaInstanceConfig.getInstanceId();
+        if (instanceId == null || instanceId.isEmpty()) {

Review Comment:
   It`s done, thank you for review. :)



##########
shenyu-registry/shenyu-registry-eureka/src/main/java/org/apache/shenyu/registry/eureka/EurekaInstanceRegisterRepository.java:
##########
@@ -50,36 +50,120 @@ public class EurekaInstanceRegisterRepository implements ShenyuInstanceRegisterR
 
     private EurekaClient eurekaClient;
 
-    private EurekaHttpClient eurekaHttpClient;
+    private DefaultEurekaClientConfig eurekaClientConfig;
+
+    private EurekaInstanceConfig eurekaInstanceConfig;
+
+    @Inject(optional = true)
+    private VipAddressResolver vipAddressResolver;
 
     @Override
     public void init(final RegisterConfig config) {
-        ConfigurationManager.getConfigInstance().setProperty("eureka.client.service-url.defaultZone", config.getServerLists());
-        ConfigurationManager.getConfigInstance().setProperty("eureka.serviceUrl.default", config.getServerLists());
-        ApplicationInfoManager applicationInfoManager = initializeApplicationInfoManager(new MyDataCenterInstanceConfig());
-        eurekaClient = new DiscoveryClient(applicationInfoManager, new DefaultEurekaClientConfig());
-        eurekaHttpClient = new JerseyApplicationClient(new ApacheHttpClient4(), config.getServerLists(), null);
-    }
-
-    private ApplicationInfoManager initializeApplicationInfoManager(final EurekaInstanceConfig instanceConfig) {
-        InstanceInfo instanceInfo = new EurekaConfigBasedInstanceInfoProvider(instanceConfig).get();
-        return new ApplicationInfoManager(instanceConfig, instanceInfo);
+        eurekaInstanceConfig = new MyDataCenterInstanceConfig();
+        eurekaClientConfig = new DefaultEurekaClientConfig() {
+            @Override
+            public List<String> getEurekaServerServiceUrls(final String zone) {
+                return Arrays.asList(config.getServerLists().split(","));
+            }
+        };
     }
 
     @Override
     public void persistInstance(final InstanceEntity instance) {
-        EurekaHttpResponse<Void> register = eurekaHttpClient.register(generateInstanceInfo(instance));
-        LOGGER.info("eureka client register success: {}", register.getEntity());
-    }
-
-    private InstanceInfo generateInstanceInfo(final InstanceEntity instance) {
-        return InstanceInfo.Builder.newBuilder()
-                .setAppName(instance.getAppName())
-                .setIPAddr(IpUtils.getHost())
+        InstanceInfo.Builder instanceInfoBuilder = instanceInfoBuilder();
+        instanceInfoBuilder.setAppName(instance.getAppName())
+                .setIPAddr(instance.getHost())
                 .setHostName(instance.getHost())
                 .setPort(instance.getPort())
-                .setDataCenterInfo(new MyDataCenterInfo(DataCenterInfo.Name.MyOwn))
-                .build();
+                .setStatus(InstanceInfo.InstanceStatus.UP);
+        InstanceInfo instanceInfo = instanceInfoBuilder.build();
+        LeaseInfo.Builder leaseInfoBuilder = LeaseInfo.Builder.newBuilder()
+                .setRenewalIntervalInSecs(eurekaInstanceConfig.getLeaseRenewalIntervalInSeconds())
+                .setDurationInSecs(eurekaInstanceConfig.getLeaseExpirationDurationInSeconds());
+        instanceInfo.setLeaseInfo(leaseInfoBuilder.build());
+        ApplicationInfoManager applicationInfoManager = new ApplicationInfoManager(eurekaInstanceConfig, instanceInfo);
+        eurekaClient = new DiscoveryClient(applicationInfoManager, eurekaClientConfig);
+    }
+
+    /**
+     * Gets the instance information from the config instance and returns it after setting the appropriate status.
+     * ref: com.netflix.appinfo.providers.EurekaConfigBasedInstanceInfoProvider#get
+     *
+     * @return InstanceInfo instance to be registered with eureka server
+     */
+    public InstanceInfo.Builder instanceInfoBuilder() {
+        // Build the lease information to be passed to the server based on config
+        if (vipAddressResolver == null) {
+            vipAddressResolver = new Archaius1VipAddressResolver();
+        }
+
+        // Builder the instance information to be registered with eureka server
+        final InstanceInfo.Builder builder = InstanceInfo.Builder.newBuilder(vipAddressResolver);
+
+        // set the appropriate id for the InstanceInfo, falling back to datacenter Id if applicable, else hostname
+        String instanceId = eurekaInstanceConfig.getInstanceId();
+        if (instanceId == null || instanceId.isEmpty()) {
+            DataCenterInfo dataCenterInfo = eurekaInstanceConfig.getDataCenterInfo();
+            if (dataCenterInfo instanceof UniqueIdentifier) {
+                instanceId = ((UniqueIdentifier) dataCenterInfo).getId();
+            } else {
+                instanceId = eurekaInstanceConfig.getHostName(false);
+            }
+        }
+
+        String defaultAddress;
+        if (eurekaInstanceConfig instanceof RefreshableInstanceConfig) {
+            // Refresh AWS data center info, and return up to date address
+            defaultAddress = ((RefreshableInstanceConfig) eurekaInstanceConfig).resolveDefaultAddress(false);
+        } else {
+            defaultAddress = eurekaInstanceConfig.getHostName(false);
+        }
+
+        // fail safe
+        if (defaultAddress == null || defaultAddress.isEmpty()) {

Review Comment:
   done.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [BUG #5268] Fix bug when registering with Eureka through EurekaInstanceRegisterRepository#persistInstance. [shenyu]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #5269:
URL: https://github.com/apache/shenyu/pull/5269#issuecomment-1790406466

   ## [Codecov](https://app.codecov.io/gh/apache/shenyu/pull/5269?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   > Merging [#5269](https://app.codecov.io/gh/apache/shenyu/pull/5269?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (c67ee80) into [master](https://app.codecov.io/gh/apache/shenyu/commit/8a2a23dc17bdbbad9b8fb57a1f24ff0553e483f4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (8a2a23d) will **decrease** coverage by `0.11%`.
   > The diff coverage is `73.33%`.
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5269      +/-   ##
   ============================================
   - Coverage     61.12%   61.02%   -0.11%     
   + Complexity     8659     8653       -6     
   ============================================
     Files          1252     1252              
     Lines         38544    38588      +44     
     Branches       3685     3688       +3     
   ============================================
   - Hits          23560    23547      -13     
   - Misses        12915    12962      +47     
   - Partials       2069     2079      +10     
   ```
   
   
   | [Files](https://app.codecov.io/gh/apache/shenyu/pull/5269?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...istry/eureka/EurekaInstanceRegisterRepository.java](https://app.codecov.io/gh/apache/shenyu/pull/5269?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hlbnl1LXJlZ2lzdHJ5L3NoZW55dS1yZWdpc3RyeS1ldXJla2Evc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9yZWdpc3RyeS9ldXJla2EvRXVyZWthSW5zdGFuY2VSZWdpc3RlclJlcG9zaXRvcnkuamF2YQ==) | `75.67% <73.33%> (+10.15%)` | :arrow_up: |
   
   ... and [13 files with indirect coverage changes](https://app.codecov.io/gh/apache/shenyu/pull/5269/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [BUG #5268] Fix bug when registering with Eureka through EurekaInstanceRegisterRepository#persistInstance. [shenyu]

Posted by "moremind (via GitHub)" <gi...@apache.org>.
moremind commented on code in PR #5269:
URL: https://github.com/apache/shenyu/pull/5269#discussion_r1381259898


##########
shenyu-registry/shenyu-registry-eureka/src/main/java/org/apache/shenyu/registry/eureka/EurekaInstanceRegisterRepository.java:
##########
@@ -50,36 +50,120 @@ public class EurekaInstanceRegisterRepository implements ShenyuInstanceRegisterR
 
     private EurekaClient eurekaClient;
 
-    private EurekaHttpClient eurekaHttpClient;
+    private DefaultEurekaClientConfig eurekaClientConfig;
+
+    private EurekaInstanceConfig eurekaInstanceConfig;
+
+    @Inject(optional = true)
+    private VipAddressResolver vipAddressResolver;
 
     @Override
     public void init(final RegisterConfig config) {
-        ConfigurationManager.getConfigInstance().setProperty("eureka.client.service-url.defaultZone", config.getServerLists());
-        ConfigurationManager.getConfigInstance().setProperty("eureka.serviceUrl.default", config.getServerLists());
-        ApplicationInfoManager applicationInfoManager = initializeApplicationInfoManager(new MyDataCenterInstanceConfig());
-        eurekaClient = new DiscoveryClient(applicationInfoManager, new DefaultEurekaClientConfig());
-        eurekaHttpClient = new JerseyApplicationClient(new ApacheHttpClient4(), config.getServerLists(), null);
-    }
-
-    private ApplicationInfoManager initializeApplicationInfoManager(final EurekaInstanceConfig instanceConfig) {
-        InstanceInfo instanceInfo = new EurekaConfigBasedInstanceInfoProvider(instanceConfig).get();
-        return new ApplicationInfoManager(instanceConfig, instanceInfo);
+        eurekaInstanceConfig = new MyDataCenterInstanceConfig();
+        eurekaClientConfig = new DefaultEurekaClientConfig() {
+            @Override
+            public List<String> getEurekaServerServiceUrls(final String zone) {
+                return Arrays.asList(config.getServerLists().split(","));
+            }
+        };
     }
 
     @Override
     public void persistInstance(final InstanceEntity instance) {
-        EurekaHttpResponse<Void> register = eurekaHttpClient.register(generateInstanceInfo(instance));
-        LOGGER.info("eureka client register success: {}", register.getEntity());
-    }
-
-    private InstanceInfo generateInstanceInfo(final InstanceEntity instance) {
-        return InstanceInfo.Builder.newBuilder()
-                .setAppName(instance.getAppName())
-                .setIPAddr(IpUtils.getHost())
+        InstanceInfo.Builder instanceInfoBuilder = instanceInfoBuilder();
+        instanceInfoBuilder.setAppName(instance.getAppName())
+                .setIPAddr(instance.getHost())
                 .setHostName(instance.getHost())
                 .setPort(instance.getPort())
-                .setDataCenterInfo(new MyDataCenterInfo(DataCenterInfo.Name.MyOwn))
-                .build();
+                .setStatus(InstanceInfo.InstanceStatus.UP);
+        InstanceInfo instanceInfo = instanceInfoBuilder.build();
+        LeaseInfo.Builder leaseInfoBuilder = LeaseInfo.Builder.newBuilder()
+                .setRenewalIntervalInSecs(eurekaInstanceConfig.getLeaseRenewalIntervalInSeconds())
+                .setDurationInSecs(eurekaInstanceConfig.getLeaseExpirationDurationInSeconds());
+        instanceInfo.setLeaseInfo(leaseInfoBuilder.build());
+        ApplicationInfoManager applicationInfoManager = new ApplicationInfoManager(eurekaInstanceConfig, instanceInfo);
+        eurekaClient = new DiscoveryClient(applicationInfoManager, eurekaClientConfig);
+    }
+
+    /**
+     * Gets the instance information from the config instance and returns it after setting the appropriate status.
+     * ref: com.netflix.appinfo.providers.EurekaConfigBasedInstanceInfoProvider#get
+     *
+     * @return InstanceInfo instance to be registered with eureka server
+     */
+    public InstanceInfo.Builder instanceInfoBuilder() {
+        // Build the lease information to be passed to the server based on config
+        if (vipAddressResolver == null) {
+            vipAddressResolver = new Archaius1VipAddressResolver();
+        }
+
+        // Builder the instance information to be registered with eureka server
+        final InstanceInfo.Builder builder = InstanceInfo.Builder.newBuilder(vipAddressResolver);
+
+        // set the appropriate id for the InstanceInfo, falling back to datacenter Id if applicable, else hostname
+        String instanceId = eurekaInstanceConfig.getInstanceId();
+        if (instanceId == null || instanceId.isEmpty()) {

Review Comment:
   use StringUtils.isEmpty



##########
shenyu-registry/shenyu-registry-eureka/src/main/java/org/apache/shenyu/registry/eureka/EurekaInstanceRegisterRepository.java:
##########
@@ -50,36 +50,120 @@ public class EurekaInstanceRegisterRepository implements ShenyuInstanceRegisterR
 
     private EurekaClient eurekaClient;
 
-    private EurekaHttpClient eurekaHttpClient;
+    private DefaultEurekaClientConfig eurekaClientConfig;
+
+    private EurekaInstanceConfig eurekaInstanceConfig;
+
+    @Inject(optional = true)
+    private VipAddressResolver vipAddressResolver;
 
     @Override
     public void init(final RegisterConfig config) {
-        ConfigurationManager.getConfigInstance().setProperty("eureka.client.service-url.defaultZone", config.getServerLists());
-        ConfigurationManager.getConfigInstance().setProperty("eureka.serviceUrl.default", config.getServerLists());
-        ApplicationInfoManager applicationInfoManager = initializeApplicationInfoManager(new MyDataCenterInstanceConfig());
-        eurekaClient = new DiscoveryClient(applicationInfoManager, new DefaultEurekaClientConfig());
-        eurekaHttpClient = new JerseyApplicationClient(new ApacheHttpClient4(), config.getServerLists(), null);
-    }
-
-    private ApplicationInfoManager initializeApplicationInfoManager(final EurekaInstanceConfig instanceConfig) {
-        InstanceInfo instanceInfo = new EurekaConfigBasedInstanceInfoProvider(instanceConfig).get();
-        return new ApplicationInfoManager(instanceConfig, instanceInfo);
+        eurekaInstanceConfig = new MyDataCenterInstanceConfig();
+        eurekaClientConfig = new DefaultEurekaClientConfig() {
+            @Override
+            public List<String> getEurekaServerServiceUrls(final String zone) {
+                return Arrays.asList(config.getServerLists().split(","));
+            }
+        };
     }
 
     @Override
     public void persistInstance(final InstanceEntity instance) {
-        EurekaHttpResponse<Void> register = eurekaHttpClient.register(generateInstanceInfo(instance));
-        LOGGER.info("eureka client register success: {}", register.getEntity());
-    }
-
-    private InstanceInfo generateInstanceInfo(final InstanceEntity instance) {
-        return InstanceInfo.Builder.newBuilder()
-                .setAppName(instance.getAppName())
-                .setIPAddr(IpUtils.getHost())
+        InstanceInfo.Builder instanceInfoBuilder = instanceInfoBuilder();
+        instanceInfoBuilder.setAppName(instance.getAppName())
+                .setIPAddr(instance.getHost())
                 .setHostName(instance.getHost())
                 .setPort(instance.getPort())
-                .setDataCenterInfo(new MyDataCenterInfo(DataCenterInfo.Name.MyOwn))
-                .build();
+                .setStatus(InstanceInfo.InstanceStatus.UP);
+        InstanceInfo instanceInfo = instanceInfoBuilder.build();
+        LeaseInfo.Builder leaseInfoBuilder = LeaseInfo.Builder.newBuilder()
+                .setRenewalIntervalInSecs(eurekaInstanceConfig.getLeaseRenewalIntervalInSeconds())
+                .setDurationInSecs(eurekaInstanceConfig.getLeaseExpirationDurationInSeconds());
+        instanceInfo.setLeaseInfo(leaseInfoBuilder.build());
+        ApplicationInfoManager applicationInfoManager = new ApplicationInfoManager(eurekaInstanceConfig, instanceInfo);
+        eurekaClient = new DiscoveryClient(applicationInfoManager, eurekaClientConfig);
+    }
+
+    /**
+     * Gets the instance information from the config instance and returns it after setting the appropriate status.
+     * ref: com.netflix.appinfo.providers.EurekaConfigBasedInstanceInfoProvider#get
+     *
+     * @return InstanceInfo instance to be registered with eureka server
+     */
+    public InstanceInfo.Builder instanceInfoBuilder() {
+        // Build the lease information to be passed to the server based on config
+        if (vipAddressResolver == null) {
+            vipAddressResolver = new Archaius1VipAddressResolver();
+        }
+
+        // Builder the instance information to be registered with eureka server
+        final InstanceInfo.Builder builder = InstanceInfo.Builder.newBuilder(vipAddressResolver);
+
+        // set the appropriate id for the InstanceInfo, falling back to datacenter Id if applicable, else hostname
+        String instanceId = eurekaInstanceConfig.getInstanceId();
+        if (instanceId == null || instanceId.isEmpty()) {
+            DataCenterInfo dataCenterInfo = eurekaInstanceConfig.getDataCenterInfo();
+            if (dataCenterInfo instanceof UniqueIdentifier) {
+                instanceId = ((UniqueIdentifier) dataCenterInfo).getId();
+            } else {
+                instanceId = eurekaInstanceConfig.getHostName(false);
+            }
+        }
+
+        String defaultAddress;
+        if (eurekaInstanceConfig instanceof RefreshableInstanceConfig) {
+            // Refresh AWS data center info, and return up to date address
+            defaultAddress = ((RefreshableInstanceConfig) eurekaInstanceConfig).resolveDefaultAddress(false);
+        } else {
+            defaultAddress = eurekaInstanceConfig.getHostName(false);
+        }
+
+        // fail safe
+        if (defaultAddress == null || defaultAddress.isEmpty()) {

Review Comment:
   same



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [BUG #5268] Fix bug when registering with Eureka through EurekaInstanceRegisterRepository#persistInstance. [shenyu]

Posted by "moremind (via GitHub)" <gi...@apache.org>.
moremind merged PR #5269:
URL: https://github.com/apache/shenyu/pull/5269


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org