[GitHub] [flink] tillrohrmann commented on a change in pull request #18191: [FLINK-25405] Let BlobServer/BlobCache check and delete corrupted blobs at start up

[GitBox <gi...@apache.org>]

tillrohrmann commented on a change in pull request #18191:
URL: https://github.com/apache/flink/pull/18191#discussion_r785893044



##########
File path: flink-architecture-tests/violations/e5126cae-f3fe-48aa-b6fb-60ae6cc3fcd5
##########
@@ -8,6 +8,7 @@ Method <org.apache.flink.orc.nohive.shim.OrcNoHiveShim.createRecordReader(org.ap
 Method <org.apache.flink.runtime.blob.BlobInputStream.read()> calls method <org.apache.flink.runtime.blob.BlobKey.getHash()> in (BlobInputStream.java:127)
 Method <org.apache.flink.runtime.blob.BlobInputStream.read([B, int, int)> calls method <org.apache.flink.runtime.blob.BlobKey.getHash()> in (BlobInputStream.java:163)
 Method <org.apache.flink.runtime.blob.BlobOutputStream.receiveAndCheckPutResponse(java.io.InputStream, java.security.MessageDigest, org.apache.flink.runtime.blob.BlobKey$BlobType)> calls method <org.apache.flink.runtime.blob.BlobKey.getHash()> in (BlobOutputStream.java:155)
+Method <org.apache.flink.runtime.blob.BlobUtils.checkAndDeleteCorruptedBlobs(java.nio.file.Path, org.slf4j.Logger)> calls method <org.apache.flink.runtime.blob.BlobKey.getHash()> in (BlobUtils.java:491)

Review comment:
       If you refer to the problem where a method's visibility is set to `public` because of testing purposes and then annotated with `@VisibleForTesting`, then yes.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org