You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "chenjian2664 (via GitHub)" <gi...@apache.org> on 2023/04/05 03:31:02 UTC

[GitHub] [ignite] chenjian2664 commented on a diff in pull request #10579: IGNITE-18964 Fix sql with consecutive wildcard to java regex translation

chenjian2664 commented on code in PR #10579:
URL: https://github.com/apache/ignite/pull/10579#discussion_r1157983878


##########
modules/core/src/test/java/org/apache/ignite/internal/processors/odbc/SqlListenerUtilsTest.java:
##########
@@ -48,6 +48,9 @@ public void translateWildchar() {
         check(".ome", "_ome");
 
         check("so_e", "so\\_e");
+        check("so__e", "so\\_\\_e");
+        check("so__e___f", "so\\_\\_e\\_\\_\\_f");

Review Comment:
   @AMashenkov  I updated the impl, please help to review, thanks. The things need to discuss is that the test cases about the `translateSeriesOfBackslashes`, that would fail currently



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org