You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@zookeeper.apache.org by ha...@apache.org on 2018/03/26 01:49:20 UTC

zookeeper git commit: ZOOKEEPER-3001: Incorrect log message when try to delete container node

Repository: zookeeper
Updated Branches:
  refs/heads/master 99c9bbb0a -> 8cfca3add


ZOOKEEPER-3001: Incorrect log message when try to delete container node

Missing `String.format`.

Author: sel-fish <fq...@hotmail.com>

Reviewers: Edward Ribeiro <ed...@gmail.com>, Andor Molnár <an...@cloudera.com>, Michael Han <ha...@apache.org>, maoling <ma...@sina.com>

Closes #492 from sel-fish/ZOOKEEPER-3001


Project: http://git-wip-us.apache.org/repos/asf/zookeeper/repo
Commit: http://git-wip-us.apache.org/repos/asf/zookeeper/commit/8cfca3ad
Tree: http://git-wip-us.apache.org/repos/asf/zookeeper/tree/8cfca3ad
Diff: http://git-wip-us.apache.org/repos/asf/zookeeper/diff/8cfca3ad

Branch: refs/heads/master
Commit: 8cfca3add9c7fd705f9114daf4adaac9fc90f040
Parents: 99c9bbb
Author: sel-fish <fq...@hotmail.com>
Authored: Sun Mar 25 18:49:14 2018 -0700
Committer: Michael Han <ha...@apache.org>
Committed: Sun Mar 25 18:49:14 2018 -0700

----------------------------------------------------------------------
 .../main/org/apache/zookeeper/server/ContainerManager.java     | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/zookeeper/blob/8cfca3ad/src/java/main/org/apache/zookeeper/server/ContainerManager.java
----------------------------------------------------------------------
diff --git a/src/java/main/org/apache/zookeeper/server/ContainerManager.java b/src/java/main/org/apache/zookeeper/server/ContainerManager.java
index fb1cb66..db86e89 100644
--- a/src/java/main/org/apache/zookeeper/server/ContainerManager.java
+++ b/src/java/main/org/apache/zookeeper/server/ContainerManager.java
@@ -116,12 +116,12 @@ public class ContainerManager {
             Request request = new Request(null, 0, 0,
                     ZooDefs.OpCode.deleteContainer, path, null);
             try {
-                LOG.info("Attempting to delete candidate container: %s",
+                LOG.info("Attempting to delete candidate container: {}",
                         containerPath);
                 requestProcessor.processRequest(request);
             } catch (Exception e) {
-                LOG.error(String.format("Could not delete container: %s" ,
-                        containerPath), e);
+                LOG.error("Could not delete container: {}",
+                        containerPath, e);
             }
 
             long elapsedMs = Time.currentElapsedTime() - startMs;