You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/08/02 01:16:00 UTC
[jira] [Commented] (BEAM-1584) Support clean-up step in integration
test
[ https://issues.apache.org/jira/browse/BEAM-1584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16110089#comment-16110089 ]
ASF GitHub Bot commented on BEAM-1584:
--------------------------------------
GitHub user markflyhigh opened a pull request:
https://github.com/apache/beam/pull/3673
[BEAM-1584] Add clean up for bigquery integration test in Python
Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
Add clean up util for bigquery integration test and enable it for BigqueryTornadoesIT. Clean up will be executed no matter whether pipeline job is successful or verification is passed.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/markflyhigh/incubator-beam cleanup
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/3673.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3673
----
commit f0c916fec5641ba576c47838dadf75ffa300221d
Author: Mark Liu <ma...@google.com>
Date: 2017-08-02T00:46:05Z
[BEAM-1584] Add clean up in bigquery integration test
----
> Support clean-up step in integration test
> -----------------------------------------
>
> Key: BEAM-1584
> URL: https://issues.apache.org/jira/browse/BEAM-1584
> Project: Beam
> Issue Type: Task
> Components: testing
> Reporter: Mark Liu
> Assignee: Mark Liu
>
> Idea comes from: https://github.com/apache/beam/pull/2064/files/628fafed098ac5550356a201c6ccdcdcc2e9604e
> Integration tests in all sdks should be able to do clean-up at the end of each run.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)