[GitHub] metron pull request #1263: METRON-1870: Intermittent Stellar REST test failu...

[merrimanr <gi...@git.apache.org>]

GitHub user merrimanr opened a pull request:

    https://github.com/apache/metron/pull/1263

    METRON-1870: Intermittent Stellar REST test failures

    ## Contributor Comments
    This PR attempts to fix the intermittent test failures reported in the Jira.
    
    For this failure:
    ```
    restGetShouldTimeoutWithSuppliedTimeout(org.apache.metron.stellar.dsl.functions.RestFunctionsTest) Time elapsed: 0.336 sec <<< ERROR! org.apache.metron.stellar.dsl.ParseException: Unable to parse: REST_GET('http://localhost:41396/get', { "timeout": 1 } ) due to: Connection is not open
    ```
    I believe the root cause is that we're getting an IllegalStateException in some cases where we're expecting an IOException.  The HttpGet.abort() method is called within an ScheduledExecutorService so it's unpredictable when exactly the request is aborted.  I changed the caught exception to be general so hopefully this gives us the result we expect.
    
    For this failure:
    ```
    restGetShouldHandleIOException(org.apache.metron.stellar.dsl.functions.RestFunctionsTest) Time elapsed: 0.314 sec <<< FAILURE! java.lang.AssertionError: expected null, but was:<{get=success}>
    ``` 
    An IOException is being simulated by setting the socket timeout really low and executing a request against the mock server.  Looks like this is not enough to make it consistently fail.  I changed the test to spy on the doGet method and throw an IOException so that it fails every time.
    
    I was not able to reproduce these problems locally but I think they will resolve the issues.
    
    ## Pull Request Checklist
    
    Thank you for submitting a contribution to Apache Metron.  
    Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions.  
    Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides.  
    
    
    In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
    - [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    
    ### For code changes:
    - [ ] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
    - [ ] Have you included steps or a guide to how the change may be verified and tested manually?
    - [ ] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
      ```
      mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh 
      ```
    
    - [x] Have you written or updated unit tests and or integration tests to verify your changes?
    - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
    - [ ] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`:
    
      ```
      cd site-book
      mvn site
      ```
    
    #### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
    It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/merrimanr/incubator-metron METRON-1870

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/metron/pull/1263.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1263
    
----
commit b2dd4232e997eef23d0ba7350caa49d52ce5e929
Author: merrimanr <me...@...>
Date:   2018-11-14T15:09:21Z

    initial commit

----


---

[GitHub] metron issue #1263: METRON-1870: Intermittent Stellar REST test failures

[nickwallen <gi...@git.apache.org>]

Github user nickwallen commented on the issue:

    https://github.com/apache/metron/pull/1263
  
    +1 pending successful Travis run.  Thanks


---

[GitHub] metron pull request #1263: METRON-1870: Intermittent Stellar REST test failu...

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/metron/pull/1263


---