[GitHub] [cloudstack] weizhouapache commented on pull request #4037: Document cidrlist parameter deprecation

[GitBox <gi...@apache.org>]

weizhouapache commented on pull request #4037:
URL: https://github.com/apache/cloudstack/pull/4037#issuecomment-877472558


   @sureshanaparti @DaanHoogland @onitake 
   I think cidrlist is not deprecated in CreateFirewallRuleCmd.java. 
   Please revert this merge.
   
   @onitake could you please create another pr for CreatePortForwardingRuleCmd.java which cidrlist is deprecated ?
   
   ```
   (localcloud) SBCM5> > create firewallrule ipaddressid=997f8efd-2ec7-46f4-a054-de837e196cc2 startport=22 endport=22 cidrlist=10.10.10.0/24 protocol=tcp
   {
     "firewallrule": {
       "cidrlist": "10.10.10.0/24",
       "endport": 22,
       "fordisplay": true,
       "id": "f0b7270d-77b0-4d97-8c02-d95a0e774561",
       "ipaddress": "10.0.52.5",
       "ipaddressid": "997f8efd-2ec7-46f4-a054-de837e196cc2",
       "networkid": "5528f815-c365-4702-8a6b-b59a1d33e8c5",
       "protocol": "tcp",
       "startport": 22,
       "state": "Active",
       "tags": []
     }
   }
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org