[GitHub] [lucene-solr] madrob commented on a change in pull request #1050: SOLR-13990: Switch out woodstox-core-asl with aalto-xml and upgrade woodstox stax-2 API

[GitBox <gi...@apache.org>]

madrob commented on a change in pull request #1050: SOLR-13990: Switch out woodstox-core-asl with aalto-xml and upgrade woodstox stax-2 API
URL: https://github.com/apache/lucene-solr/pull/1050#discussion_r353937782
 
 

 ##########
 File path: solr/core/src/java/org/apache/solr/handler/tagger/XmlOffsetCorrector.java
 ##########
 @@ -45,21 +43,12 @@
  */
 public class XmlOffsetCorrector extends OffsetCorrector {
 
-  //TODO use StAX without hard requirement on woodstox.   xmlStreamReader.getLocation().getCharacterOffset()
+  //TODO use StAX without hard requirement on woodstox. xmlStreamReader.getLocation().getCharacterOffset()
 
-  private static final XMLInputFactory2 XML_INPUT_FACTORY;
+  private static final XMLInputFactory XML_INPUT_FACTORY;
   static {
-    // note: similar code in Solr's EmptyEntityResolver
-    XML_INPUT_FACTORY = new WstxInputFactory();
-    XML_INPUT_FACTORY.setXMLResolver(new XMLResolver() {
-      @Override
-      public InputStream resolveEntity(String publicId, String systemId, String baseURI, String namespace) {
-        return ClosedInputStream.CLOSED_INPUT_STREAM;
-      }
-    });
-    // TODO disable DTD?
 
 Review comment:
   Is this TODO still applicable? Is this now disabled by default? If not, leave the TODO comment in.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org