You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/04/12 09:18:37 UTC

[GitHub] [incubator-nuttx-apps] Ouss4 opened a new pull request #682: wireless/wapi/src/wapi.c: When executing a command return it's error code on failure.

Ouss4 opened a new pull request #682:
URL: https://github.com/apache/incubator-nuttx-apps/pull/682


   ## Summary
   When a command was executed `EXIT_SUCCESS` was always returned even if the command failed.  This made the `echo $?` return not reliable.
   ## Impact
   Fix return of WAPI commands
   ## Testing
   Tested with ESP32.
   
   Before:
   ```
   nsh> wapi essid wlan0 wrongssid 1
   ioctl(SIOCSIWESSID): 1
   ERROR: Process command (essid) failed.
   nsh> echo $?
   0
   ```
   After
   
   ```
   nsh> wapi essid wlan0 wrongssid 1
   ioctl(SIOCSIWESSID): 1
   ERROR: Process command (essid) failed.
   nsh> echo $?
   1
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #682: wireless/wapi/src/wapi.c: When executing a command return it's error code on failure.

Posted by GitBox <gi...@apache.org>.

xiaoxiang781216 merged pull request #682:
URL: https://github.com/apache/incubator-nuttx-apps/pull/682


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org