You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by "Brett Porter (JIRA)" <ji...@codehaus.org> on 2005/09/07 15:58:02 UTC

[jira] Created: (MNG-845) get rid of "originalModel"

get rid of "originalModel"
--------------------------

         Key: MNG-845
         URL: http://jira.codehaus.org/browse/MNG-845
     Project: Maven 2
        Type: Task
  Components: maven-project  
 Reporter: Brett Porter
     Fix For: 2.0-beta-2


this seems to have polluted the api for the release plugin, and should be able to be done as a separate instantiation of the project (and seems to be happening anyway).

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Commented: (MNG-845) get rid of "originalModel"

Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MNG-845?page=comments#action_46813 ] 

Brett Porter commented on MNG-845:
----------------------------------

ok, no need to get rid of it. But in that case, the release plugin shouldn't be modifying the original model (possibly something I just made worse by copying a mistake already in there). So can we just clone the original model and work from that?


> get rid of "originalModel"
> --------------------------
>
>          Key: MNG-845
>          URL: http://jira.codehaus.org/browse/MNG-845
>      Project: Maven 2
>         Type: Task
>   Components: maven-project
>     Reporter: Brett Porter
>      Fix For: 2.0-beta-2

>
>
> this seems to have polluted the api for the release plugin, and should be able to be done as a separate instantiation of the project (and seems to be happening anyway).

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Closed: (MNG-845) get rid of "originalModel"

Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-845?page=all ]
     
John Casey closed MNG-845:
--------------------------

     Assign To: John Casey
    Resolution: Won't Fix

release plugin is working off of cloned project and model instances. we should be ok from here.

> get rid of "originalModel"
> --------------------------
>
>          Key: MNG-845
>          URL: http://jira.codehaus.org/browse/MNG-845
>      Project: Maven 2
>         Type: Task
>   Components: maven-project
>     Reporter: Brett Porter
>     Assignee: John Casey
>      Fix For: 2.0-beta-3

>
>
> this seems to have polluted the api for the release plugin, and should be able to be done as a separate instantiation of the project (and seems to be happening anyway).

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Commented: (MNG-845) get rid of "originalModel"

Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MNG-845?page=comments#action_46766 ] 

John Casey commented on MNG-845:
--------------------------------

I don't see how else you'll be able to get at the un-inherited, in-injected POM without originalModel. We're dependent on this to rewrite pom.xml, unless you were to read in the xml and apply some sort of transform, which definitely seems like the greater of the two evils.

Also, it eliminates the need to perform the read/transform logic for other plugins that may want to simply make a slightly tweaked version of the pom.xml, not to mention transferring it to a database instance or something else, eventually.

> get rid of "originalModel"
> --------------------------
>
>          Key: MNG-845
>          URL: http://jira.codehaus.org/browse/MNG-845
>      Project: Maven 2
>         Type: Task
>   Components: maven-project
>     Reporter: Brett Porter
>      Fix For: 2.0-beta-2

>
>
> this seems to have polluted the api for the release plugin, and should be able to be done as a separate instantiation of the project (and seems to be happening anyway).

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org