[GitHub] [james-project] chibenwa commented on a change in pull request #715: ability to assert mock emails without possible race condition

[GitBox <gi...@apache.org>]

chibenwa commented on a change in pull request #715:
URL: https://github.com/apache/james-project/pull/715#discussion_r738152744



##########
File path: server/mailet/mock-smtp-server/src/main/java/org/apache/james/mock/smtp/server/HTTPConfigurationServer.java
##########
@@ -232,4 +242,17 @@ public RunningStage start() {
             return res.status(INTERNAL_SERVER_ERROR).send();
         }
     }
+
+    private Publisher<Void> getMailsCount(HttpServerRequest req, HttpServerResponse res) {
+        var count = receivedMailRepository.list().stream().count();

Review comment:
       Can we use the real type here to? We tend to not use `var` on this project.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org