You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/07/12 06:20:14 UTC
[GitHub] [airflow] morrme commented on a change in pull request #9775: improve typing for datadog provider
morrme commented on a change in pull request #9775:
URL: https://github.com/apache/airflow/pull/9775#discussion_r453273914
##########
File path: airflow/providers/datadog/hooks/datadog.py
##########
@@ -90,9 +92,9 @@ def send_metric(self, metric_name, datapoint, tags=None, type_=None, interval=No
return response
def query_metric(self,
- query,
- from_seconds_ago,
- to_seconds_ago):
+ query: str,
+ from_seconds_ago: int,
+ to_seconds_ago: int) - > Dict[str, Any]:
Review comment:
This function returns a `response` -- would this indeed be a `Dict` type or a custom object?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org