You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/08/01 02:54:40 UTC

[GitHub] [pulsar] nodece commented on a diff in pull request #16836: [feat]: support check PR name and automatically add labels based on PR title

nodece commented on code in PR #16836:
URL: https://github.com/apache/pulsar/pull/16836#discussion_r934100793


##########
.github/workflows/semantic.yaml:
##########
@@ -0,0 +1,35 @@
+name: "PR Lint"
+
+on:
+  pull_request_target:
+    types:
+      - opened
+      - edited
+      - synchronize
+
+jobs:
+  main:
+    name: Validate PR title
+    runs-on: ubuntu-latest
+    steps:
+      - name: Check out repository code
+        uses: actions/checkout@v3
+        with:
+          submodules: recursive
+      - uses: amannn/action-semantic-pull-request@v4
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        with:
+          types: |
+            [feat]
+            [fix]
+            [docs]

Review Comment:
   The current standard is similar to the convention message, it should be a variant.  
   
   If we use the convention message, we can focus on other things, and reduce time on these tools, but the developer gets used to the current standard. If we don't consider these, I suggest using the convention message.
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org