You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/12/15 18:34:07 UTC

[GitHub] [superset] villebro commented on pull request #21066: fix(Trino): create `PrestoBaseEngineSpec` base class to share common code between Trino and Presto

villebro commented on PR #21066:
URL: https://github.com/apache/superset/pull/21066#issuecomment-1353537469

   @john-bodley the problem is that PyHive and the new Trino connector are diverging at a rapid pace right now, so extending the Trino spec from the old Presto spec is IMO not a good idea (that actually created a few regressions of its own when we did that). I'm fine moving everything that's known to work on both to `PrestoBaseEngineSpec` (I can chip in with adding tests when I have some spare time).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org