You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "vishesh92 (via GitHub)" <gi...@apache.org> on 2025/07/02 08:28:13 UTC
[PR] Upgrade noVNC from 1.4.0 to 1.6.0 [cloudstack]
vishesh92 opened a new pull request, #11119:
URL: https://github.com/apache/cloudstack/pull/11119
### Description
This PR upgrades noVNC from 1.4.0 to 1.6.0. Followed the same steps as in https://github.com/apache/cloudstack/pull/7281.
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ******************************************************************************* -->
<!--- NOTE: AUTOMATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ******************************************************************************* -->
### Types of changes
- [x] Breaking change (fix or feature that would cause existing functionality to change)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
- [ ] test (unit or integration test code)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [x] Major
- [ ] Minor
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
#### How did you try to break this feature and the system with this change?
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade noVNC from 1.4.0 to 1.6.0 [cloudstack]
Posted by "vishesh92 (via GitHub)" <gi...@apache.org>.
vishesh92 commented on PR #11119:
URL: https://github.com/apache/cloudstack/pull/11119#issuecomment-3067968626
Changes doesn't seem to be working and require some investigation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade noVNC from 1.4.0 to 1.6.0 [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11119:
URL: https://github.com/apache/cloudstack/pull/11119#issuecomment-3070295668
@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade noVNC from 1.4.0 to 1.6.0 [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11119:
URL: https://github.com/apache/cloudstack/pull/11119#issuecomment-3126740159
@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade noVNC from 1.4.0 to 1.6.0 [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11119:
URL: https://github.com/apache/cloudstack/pull/11119#issuecomment-3075982144
<b>[SF] Trillian test result (tid-13772)</b>
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 63124 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11119-t13772-kvm-ol8.zip
Smoke tests completed. 142 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade noVNC from 1.4.0 to 1.6.0 [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11119:
URL: https://github.com/apache/cloudstack/pull/11119#issuecomment-3070592038
Packaging result [SF]: ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 14181
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade noVNC from 1.4.0 to 1.6.0 [cloudstack]
Posted by "vishesh92 (via GitHub)" <gi...@apache.org>.
vishesh92 commented on PR #11119:
URL: https://github.com/apache/cloudstack/pull/11119#issuecomment-3070292612
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade noVNC from 1.4.0 to 1.6.0 [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11119:
URL: https://github.com/apache/cloudstack/pull/11119#issuecomment-3070616758
@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade noVNC from 1.4.0 to 1.6.0 [cloudstack]
Posted by "vishesh92 (via GitHub)" <gi...@apache.org>.
vishesh92 commented on PR #11119:
URL: https://github.com/apache/cloudstack/pull/11119#issuecomment-3126735620
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade noVNC from 1.4.0 to 1.6.0 [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11119:
URL: https://github.com/apache/cloudstack/pull/11119#issuecomment-3131158135
@borisstoyanov a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade noVNC from 1.4.0 to 1.6.0 [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #11119:
URL: https://github.com/apache/cloudstack/pull/11119#issuecomment-3028890282
@blueorangutan test keepEnv
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade noVNC from 1.4.0 to 1.6.0 [cloudstack]
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #11119:
URL: https://github.com/apache/cloudstack/pull/11119#issuecomment-3073438423
Tested noVNC 1.6.0 by manually applying the file changes to a ACS 4.20.1 env CPVM and restarting cloud service.
Post this, the noVNC 1.6 based console appeared slightly faster: (with VNC/TLS disabled)
https://github.com/user-attachments/assets/2da5bcfb-8aee-4937-8e47-c79104c67f28
Also tested the same env with noVNC 1.6 based console & VNC/TLS enabled:
https://github.com/user-attachments/assets/b802c128-2a0e-4e1a-920b-11f553c6f8ef
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade noVNC from 1.4.0 to 1.6.0 [cloudstack]
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #11119:
URL: https://github.com/apache/cloudstack/pull/11119#issuecomment-3069194161
@weizhouapache @nvazquez let's also review if this creates any regression for keystore/keyboard related changes we had done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade noVNC from 1.4.0 to 1.6.0 [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11119:
URL: https://github.com/apache/cloudstack/pull/11119#issuecomment-3071848955
@rohityadavcloud a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade noVNC from 1.4.0 to 1.6.0 [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #11119:
URL: https://github.com/apache/cloudstack/pull/11119#issuecomment-3028622288
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade noVNC from 1.4.0 to 1.6.0 [cloudstack]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #11119:
URL: https://github.com/apache/cloudstack/pull/11119#discussion_r2185236353
##########
systemvm/agent/noVNC/core/rfb.js:
##########
@@ -865,25 +869,48 @@ export default class RFB extends EventTargetMixin {
// Requests a change of remote desktop size. This message is an extension
// and may only be sent if we have received an ExtendedDesktopSize message
_requestRemoteResize() {
- clearTimeout(this._resizeTimeout);
- this._resizeTimeout = null;
+ if (!this._resizeSession) {
+ return;
+ }
+ if (this._viewOnly) {
+ return;
+ }
+ if (!this._supportsSetDesktopSize) {
+ return;
+ }
- if (!this._resizeSession || this._viewOnly ||
- !this._supportsSetDesktopSize) {
+ // Rate limit to one pending resize at a time
+ if (this._pendingRemoteResize) {
return;
}
+ // And no more than once every 100ms
+ if ((Date.now() - this._lastResize) < 100) {
+ clearTimeout(this._resizeTimeout);
+ this._resizeTimeout = setTimeout(this._requestRemoteResize.bind(this),
+ 100 - (Date.now() - this._lastResize));
+ return;
+ }
+ this._resizeTimeout = null;
+
const size = this._screenSize();
+ // Do we actually change anything?
+ if (size.w === this._fbWidth && size.h === this._fbHeight) {
+ return;
+ }
+
+ this._pendingRemoteResize = true;
+ this._lastResize = Date.now();
RFB.messages.setDesktopSize(this._sock,
- Math.floor(size.w), Math.floor(size.h),
- this._screenID, this._screenFlags);
+ Math.floor(size.w), Math.floor(size.h),
+ this._screenID, this._screenFlags);
Log.Debug('Requested new desktop size: ' +
- size.w + 'x' + size.h);
+ size.w + 'x' + size.h);
}
- // Gets the size of the available screen
+ // Gets the the size of the available screen
Review Comment:
There's a duplicated word 'the' in the comment. It should read 'Gets the size of the available screen'.
```suggestion
// Gets the size of the available screen
```
##########
systemvm/agent/noVNC/core/decoders/h264.js:
##########
@@ -0,0 +1,321 @@
+/*
+ * noVNC: HTML5 VNC client
+ * Copyright (C) 2024 The noVNC authors
+ * Licensed under MPL 2.0 (see LICENSE.txt)
+ *
+ * See README.md for usage and integration instructions.
+ *
+ */
+
+import * as Log from '../util/logging.js';
+
+export class H264Parser {
+ constructor(data) {
+ this._data = data;
+ this._index = 0;
+ this.profileIdc = null;
+ this.constraintSet = null;
+ this.levelIdc = null;
+ }
+
+ _getStartSequenceLen(index) {
+ let data = this._data;
+ if (data[index + 0] == 0 && data[index + 1] == 0 && data[index + 2] == 0 && data[index + 3] == 1) {
+ return 4;
+ }
+ if (data[index + 0] == 0 && data[index + 1] == 0 && data[index + 2] == 1) {
+ return 3;
+ }
+ return 0;
+ }
+
+ _indexOfNextNalUnit(index) {
+ let data = this._data;
+ for (let i = index; i < data.length; ++i) {
+ if (this._getStartSequenceLen(i) != 0) {
+ return i;
+ }
+ }
+ return -1;
+ }
+
+ _parseSps(index) {
+ this.profileIdc = this._data[index];
+ this.constraintSet = this._data[index + 1];
+ this.levelIdc = this._data[index + 2];
+ }
+
+ _parseNalUnit(index) {
+ const firstByte = this._data[index];
+ if (firstByte & 0x80) {
+ throw new Error('H264 parsing sanity check failed, forbidden zero bit is set');
+ }
+ const unitType = firstByte & 0x1f;
+
+ switch (unitType) {
+ case 1: // coded slice, non-idr
+ return { slice: true };
+ case 5: // coded slice, idr
+ return { slice: true, key: true };
+ case 6: // sei
+ return {};
+ case 7: // sps
+ this._parseSps(index + 1);
+ return {};
+ case 8: // pps
+ return {};
+ default:
+ Log.Warn("Unhandled unit type: ", unitType);
+ break;
+ }
+ return {};
+ }
+
+ parse() {
+ const startIndex = this._index;
+ let isKey = false;
+
+ while (this._index < this._data.length) {
+ const startSequenceLen = this._getStartSequenceLen(this._index);
+ if (startSequenceLen == 0) {
+ throw new Error('Invalid start sequence in bit stream');
+ }
+
+ const { slice, key } = this._parseNalUnit(this._index + startSequenceLen);
+
+ let nextIndex = this._indexOfNextNalUnit(this._index + startSequenceLen);
+ if (nextIndex == -1) {
+ this._index = this._data.length;
+ } else {
+ this._index = nextIndex;
+ }
+
+ if (key) {
+ isKey = true;
+ }
+ if (slice) {
+ break;
+ }
+ }
+
+ if (startIndex === this._index) {
+ return null;
+ }
+
+ return {
+ frame: this._data.subarray(startIndex, this._index),
+ key: isKey,
+ };
+ }
+}
+
+export class H264Context {
+ constructor(width, height) {
+ this.lastUsed = 0;
+ this._width = width;
+ this._height = height;
+ this._profileIdc = null;
+ this._constraintSet = null;
+ this._levelIdc = null;
+ this._decoder = null;
+ this._pendingFrames = [];
+ }
+
+ _handleFrame(frame) {
+ let pending = this._pendingFrames.shift();
+ if (pending === undefined) {
+ throw new Error("Pending frame queue empty when receiving frame from decoder");
+ }
+
+ if (pending.timestamp != frame.timestamp) {
+ throw new Error("Video frame timestamp mismatch. Expected " +
+ frame.timestamp + " but but got " + pending.timestamp);
+ }
+
+ pending.frame = frame;
+ pending.ready = true;
+ pending.resolve();
+
+ if (!pending.keep) {
+ frame.close();
+ }
+ }
+
+ _handleError(e) {
+ throw new Error("Failed to decode frame: " + e.message);
+ }
+
+ _configureDecoder(profileIdc, constraintSet, levelIdc) {
+ if (this._decoder === null || this._decoder.state === 'closed') {
+ this._decoder = new VideoDecoder({
+ output: frame => this._handleFrame(frame),
+ error: e => this._handleError(e),
+ });
+ }
+ const codec = 'avc1.' +
+ profileIdc.toString(16).padStart(2, '0') +
+ constraintSet.toString(16).padStart(2, '0') +
+ levelIdc.toString(16).padStart(2, '0');
+ this._decoder.configure({
+ codec: codec,
+ codedWidth: this._width,
+ codedHeight: this._height,
+ optimizeForLatency: true,
+ });
+ }
+
+ _preparePendingFrame(timestamp) {
+ let pending = {
+ timestamp: timestamp,
+ promise: null,
+ resolve: null,
+ frame: null,
+ ready: false,
+ keep: false,
+ };
+ pending.promise = new Promise((resolve) => {
+ pending.resolve = resolve;
+ });
+ this._pendingFrames.push(pending);
+
+ return pending;
+ }
+
+ decode(payload) {
+ let parser = new H264Parser(payload);
+ let result = null;
+
+ // Ideally, this timestamp should come from the server, but we'll just
+ // approximate it instead.
+ let timestamp = Math.round(window.performance.now() * 1e3);
+
+ while (true) {
+ let encodedFrame = parser.parse();
+ if (encodedFrame === null) {
+ break;
+ }
+
+ if (parser.profileIdc !== null) {
+ self._profileIdc = parser.profileIdc;
+ self._constraintSet = parser.constraintSet;
+ self._levelIdc = parser.levelIdc;
Review Comment:
Using `self` instead of `this` will cause a ReferenceError at runtime. Replace `self._profileIdc`, `self._constraintSet`, and `self._levelIdc` with `this._profileIdc`, `this._constraintSet`, and `this._levelIdc` respectively.
```suggestion
this._profileIdc = parser.profileIdc;
this._constraintSet = parser.constraintSet;
this._levelIdc = parser.levelIdc;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade noVNC from 1.4.0 to 1.6.0 [cloudstack]
Posted by "vishesh92 (via GitHub)" <gi...@apache.org>.
vishesh92 commented on PR #11119:
URL: https://github.com/apache/cloudstack/pull/11119#issuecomment-3070612328
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade noVNC from 1.4.0 to 1.6.0 [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #11119:
URL: https://github.com/apache/cloudstack/pull/11119#issuecomment-3073912995
I think we should go ahead with this PR but,
- in xen special keys get very confused if you break connection to the console and re-attach
- in vmware special keys get broken if you break connection to the console and re-attach
- in kvm I could switch between local keyboard and screen settings with no problem
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade noVNC from 1.4.0 to 1.6.0 [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #11119:
URL: https://github.com/apache/cloudstack/pull/11119#issuecomment-3108253578
@nvazquez @weizhouapache can you please review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade noVNC from 1.4.0 to 1.6.0 [cloudstack]
Posted by "vishesh92 (via GitHub)" <gi...@apache.org>.
vishesh92 commented on PR #11119:
URL: https://github.com/apache/cloudstack/pull/11119#issuecomment-3127024924
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade noVNC from 1.4.0 to 1.6.0 [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11119:
URL: https://github.com/apache/cloudstack/pull/11119#issuecomment-3127358611
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14423
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade noVNC from 1.4.0 to 1.6.0 [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #11119:
URL: https://github.com/apache/cloudstack/pull/11119#issuecomment-3072875977
looks good, will do some extra testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade noVNC from 1.4.0 to 1.6.0 [cloudstack]
Posted by "borisstoyanov (via GitHub)" <gi...@apache.org>.
borisstoyanov commented on PR #11119:
URL: https://github.com/apache/cloudstack/pull/11119#issuecomment-3131154560
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade noVNC from 1.4.0 to 1.6.0 [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11119:
URL: https://github.com/apache/cloudstack/pull/11119#issuecomment-3027211302
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13981
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade noVNC from 1.4.0 to 1.6.0 [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11119:
URL: https://github.com/apache/cloudstack/pull/11119#issuecomment-3028670187
UI build: :heavy_check_mark:
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11119 (QA-JID-657)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade noVNC from 1.4.0 to 1.6.0 [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11119:
URL: https://github.com/apache/cloudstack/pull/11119#issuecomment-3031826790
<b>[SF] Trillian test result (tid-13664)</b>
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 56520 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11119-t13664-kvm-ol8.zip
Smoke tests completed. 139 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_isolate_network_FW_PF_default_routes_egress_true | `Failure` | 114.80 | test_routers_network_ops.py
test_01_vpc_site2site_vpn_multiple_options | `Failure` | 407.88 | test_vpc_vpn.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade noVNC from 1.4.0 to 1.6.0 [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11119:
URL: https://github.com/apache/cloudstack/pull/11119#issuecomment-3070811680
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14184
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade noVNC from 1.4.0 to 1.6.0 [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11119:
URL: https://github.com/apache/cloudstack/pull/11119#issuecomment-3028895393
@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade noVNC from 1.4.0 to 1.6.0 [cloudstack]
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #11119:
URL: https://github.com/apache/cloudstack/pull/11119#issuecomment-3073292309
I've public rpm repo here for anyone wanting to try/test this https://build.yadav.cloud/cloudstack/pr/11119/el8/4.21/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade noVNC from 1.4.0 to 1.6.0 [cloudstack]
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #11119:
URL: https://github.com/apache/cloudstack/pull/11119#issuecomment-3071847915
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade noVNC from 1.4.0 to 1.6.0 [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11119:
URL: https://github.com/apache/cloudstack/pull/11119#issuecomment-3127021573
Packaging result [SF]: ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 14420
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade noVNC from 1.4.0 to 1.6.0 [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #11119:
URL: https://github.com/apache/cloudstack/pull/11119#issuecomment-3132501714
@vishesh92 @borisstoyanov @sureshanaparti , I marked this `waiting-for-smoketest-results` but actually think it is not going to give us extra information about the changes here. merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade noVNC from 1.4.0 to 1.6.0 [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland merged PR #11119:
URL: https://github.com/apache/cloudstack/pull/11119
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade noVNC from 1.4.0 to 1.6.0 [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11119:
URL: https://github.com/apache/cloudstack/pull/11119#issuecomment-3028624663
@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade noVNC from 1.4.0 to 1.6.0 [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11119:
URL: https://github.com/apache/cloudstack/pull/11119#issuecomment-3026954776
@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade noVNC from 1.4.0 to 1.6.0 [cloudstack]
Posted by "vishesh92 (via GitHub)" <gi...@apache.org>.
vishesh92 commented on PR #11119:
URL: https://github.com/apache/cloudstack/pull/11119#issuecomment-3026947089
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade noVNC from 1.4.0 to 1.6.0 [cloudstack]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #11119:
URL: https://github.com/apache/cloudstack/pull/11119#issuecomment-3026966038
## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/11119?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 3.90%. Comparing base [(`16c60c7`)](https://app.codecov.io/gh/apache/cloudstack/commit/16c60c7528a3ee731bceaa9113d5e6a76b22a246?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`95ceffe`)](https://app.codecov.io/gh/apache/cloudstack/commit/95ceffe8b9672e59c3c9ec1a845fb7cf19cad50f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> :exclamation: There is a different number of reports uploaded between BASE (16c60c7) and HEAD (95ceffe). Click for more details.
>
> <details><summary>HEAD has 1 upload less than BASE</summary>
>
>| Flag | BASE (16c60c7) | HEAD (95ceffe) |
>|------|------|------|
>|unittests|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #11119 +/- ##
=============================================
- Coverage 16.57% 3.90% -12.68%
=============================================
Files 5743 414 -5329
Lines 510494 33746 -476748
Branches 62075 6075 -56000
=============================================
- Hits 84617 1317 -83300
+ Misses 416415 32273 -384142
+ Partials 9462 156 -9306
```
| [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/11119/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/11119/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `3.90% <ø> (ø)` | |
| [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/11119/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/11119?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade noVNC from 1.4.0 to 1.6.0 [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11119:
URL: https://github.com/apache/cloudstack/pull/11119#issuecomment-3127026465
@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade noVNC from 1.4.0 to 1.6.0 [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11119:
URL: https://github.com/apache/cloudstack/pull/11119#issuecomment-3134442333
<b>[SF] Trillian test result (tid-13955)</b>
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 55206 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11119-t13955-kvm-ol8.zip
Smoke tests completed. 145 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org