You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "clolov (via GitHub)" <gi...@apache.org> on 2023/02/06 14:04:18 UTC

[GitHub] [kafka] clolov commented on a diff in pull request #13198: MINOR: Rename IBP_3_4_IV1 as added for KIP-405 to IBP_3_5_IV0

clolov commented on code in PR #13198:
URL: https://github.com/apache/kafka/pull/13198#discussion_r1097417323


##########
core/src/test/scala/unit/kafka/admin/FeatureCommandTest.scala:
##########
@@ -174,7 +174,7 @@ class FeatureCommandUnitTest {
   @Test
   def testMetadataVersionsToString(): Unit = {
     assertEquals("3.3-IV0, 3.3-IV1, 3.3-IV2, 3.3-IV3, 3.4-IV0, 3.4-IV1",

Review Comment:
   Already pointed out by @fvaleri, but I believe changing 3.4-IV1 here will make the test pass.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org