You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/06/29 01:15:52 UTC

[GitHub] [tvm] zackcquic commented on a change in pull request #8352: [Relay][Parser] Support slash in identifier.

zackcquic commented on a change in pull request #8352:
URL: https://github.com/apache/tvm/pull/8352#discussion_r660212089



##########
File path: tests/python/relay/test_ir_text_printer.py
##########
@@ -284,5 +284,12 @@ def test_optional_info():
     assert txt.count("/* ty=int32 */") == 3
 
 
+def test_slash_in_identifier():
+    x = relay.var("base/x")
+    y = relay.var("base/y")
+    z = x + y
+    txt = astext(z)

Review comment:
       Yes, inside `astext()` it is tested. 
   [test_ir_text_printer.py#L39](https://github.com/apache/tvm/blob/f82cf36c12d964052bf11830b5180bcee051266c/tests/python/relay/test_ir_text_printer.py#L39)
   I just reuse it here.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org