You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tika.apache.org by ti...@apache.org on 2022/05/17 03:43:50 UTC
[tika] branch main updated: TIKA-3766: delete temporary directories immediately, rename variable
This is an automated email from the ASF dual-hosted git repository.
tilman pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tika.git
The following commit(s) were added to refs/heads/main by this push:
new 3fa217103 TIKA-3766: delete temporary directories immediately, rename variable
3fa217103 is described below
commit 3fa217103b38f18bb0904729b9068f52bdd6b08a
Author: THausherr <ti...@snafu.de>
AuthorDate: Tue May 17 05:43:36 2022 +0200
TIKA-3766: delete temporary directories immediately, rename variable
---
.../test/java/org/apache/tika/cli/TikaCLITest.java | 34 +++++++++++-----------
1 file changed, 17 insertions(+), 17 deletions(-)
diff --git a/tika-app/src/test/java/org/apache/tika/cli/TikaCLITest.java b/tika-app/src/test/java/org/apache/tika/cli/TikaCLITest.java
index e7ffb2267..5d0bdd07a 100644
--- a/tika-app/src/test/java/org/apache/tika/cli/TikaCLITest.java
+++ b/tika-app/src/test/java/org/apache/tika/cli/TikaCLITest.java
@@ -365,47 +365,47 @@ public class TikaCLITest {
private void testExtract(String targetFile, String[] expectedChildrenFileNames,
int expectedLength) throws Exception {
- File tempFile = Files.createTempDirectory("tika-test-").toFile();
+ File tempDir = Files.createTempDirectory("tika-cli-test-").toFile();
try {
- String[] params = {"--extract-dir=" + tempFile.getAbsolutePath(), "-z",
+ String[] params = {"--extract-dir=" + tempDir.getAbsolutePath(), "-z",
resourcePrefix + "/" + targetFile};
TikaCLI.main(params);
- String[] tempFileNames = tempFile.list();
+ String[] tempFileNames = tempDir.list();
assertNotNull(tempFileNames);
assertEquals(expectedLength, tempFileNames.length);
String allFiles = String.join(" : ", tempFileNames);
for (String expectedChildName : expectedChildrenFileNames) {
- assertExtracted(new File(tempFile, expectedChildName), allFiles);
+ assertExtracted(new File(tempDir, expectedChildName), allFiles);
}
} finally {
- FileUtils.forceDeleteOnExit(tempFile);
+ FileUtils.deleteDirectory(tempDir);
}
}
@Test
public void testExtractTgz() throws Exception {
//TIKA-2564
- File tempFile = Files.createTempDirectory("tika-test-").toFile();
+ File tempDir = Files.createTempDirectory("tika-cli-test-").toFile();
try {
- String[] params = {"--extract-dir=" + tempFile.getAbsolutePath(), "-z",
+ String[] params = {"--extract-dir=" + tempDir.getAbsolutePath(), "-z",
resourcePrefix + "/test-documents.tgz"};
TikaCLI.main(params);
- String[] tempFileNames = tempFile.list();
+ String[] tempFileNames = tempDir.list();
assertNotNull(tempFileNames);
String allFiles = String.join(" : ", tempFileNames);
- File expectedTAR = new File(tempFile, "test-documents.tar");
+ File expectedTAR = new File(tempDir, "test-documents.tar");
assertExtracted(expectedTAR, allFiles);
} finally {
- FileUtils.forceDeleteOnExit(tempFile);
+ FileUtils.deleteDirectory(tempDir);
}
}
@@ -434,29 +434,29 @@ public class TikaCLITest {
@Test
public void testExtractInlineImages() throws Exception {
- File tempFile = Files.createTempDirectory("tika-test-").toFile();
+ File tempDir = Files.createTempDirectory("tika-cli-test-").toFile();
try {
- String[] params = {"--extract-dir=" + tempFile.getAbsolutePath(), "-z",
+ String[] params = {"--extract-dir=" + tempDir.getAbsolutePath(), "-z",
resourcePrefix + "/testPDF_childAttachments.pdf"};
TikaCLI.main(params);
- String[] tempFileNames = tempFile.list();
+ String[] tempFileNames = tempDir.list();
assertNotNull(tempFileNames);
String allFiles = String.join(" : ", tempFileNames);
- File jpeg = new File(tempFile, "image0.jpg");
+ File jpeg = new File(tempDir, "image0.jpg");
//tiff isn't extracted without optional image dependency
// File tiff = new File(tempFile, "image1.tif");
- File jobOptions = new File(tempFile, "Press Quality(1).joboptions");
- File doc = new File(tempFile, "Unit10.doc");
+ File jobOptions = new File(tempDir, "Press Quality(1).joboptions");
+ File doc = new File(tempDir, "Unit10.doc");
assertExtracted(jpeg, allFiles);
assertExtracted(jobOptions, allFiles);
assertExtracted(doc, allFiles);
} finally {
- FileUtils.forceDeleteOnExit(tempFile);
+ FileUtils.deleteDirectory(tempDir);
}
}