You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@cxf.apache.org by Benson Margulies <bi...@basistech.com> on 2007/09/04 16:54:24 UTC
Please review and commit patch to cxf-959
This patch consists of installing the namespace map into the XmlSchema
object. Apparently, the author of AegisDatabinding thought that the
commons code would do this sensible thing for itself.
I would be most grateful for a snapshot with this fix in it.
I did not propose any change to target namespace handling. I'll open a
separate JIRA since I'm not sure what is right.
The patch does not include the test case. That's new files, which is
more complex.
RE: Please review and commit patch to cxf-959
Posted by Benson Margulies <bi...@basistech.com>.
Dan,
Whoops. I'm sorry. That was stupid of me not to rerun the full
regression. I apologize.
I will be preparing a patch adding my test case as penance.
--benson
> -----Original Message-----
> From: Daniel Kulp [mailto:dkulp@apache.org]
> Sent: Tuesday, September 04, 2007 1:37 PM
> To: cxf-user@incubator.apache.org
> Cc: Benson Margulies
> Subject: Re: Please review and commit patch to cxf-959
>
>
> Benson,
>
> On Tuesday 04 September 2007, Benson Margulies wrote:
> > This patch consists of installing the namespace map into the
XmlSchema
> > object. Apparently, the author of AegisDatabinding thought that the
> > commons code would do this sensible thing for itself.
>
> I've applied the patch and committed it. I'll try and get a snapshot
up
> later tonight.
>
> One note for the future though: the patch ended up breaking a couple
of
> unit tests in the aegis databinding. The patch should have also
> included fixes for those tests. I went ahead and fixed the tests.
>
>
>
> > I would be most grateful for a snapshot with this fix in it.
> >
> >
> >
> > I did not propose any change to target namespace handling. I'll open
a
> > separate JIRA since I'm not sure what is right.
> >
> >
> >
> > The patch does not include the test case. That's new files, which is
> > more complex.
>
>
>
> --
> J. Daniel Kulp
> Principal Engineer
> IONA
> P: 781-902-8727 C: 508-380-7194
> daniel.kulp@iona.com
> http://www.dankulp.com/blog
Re: Please review and commit patch to cxf-959
Posted by Daniel Kulp <dk...@apache.org>.
Benson,
On Tuesday 04 September 2007, Benson Margulies wrote:
> This patch consists of installing the namespace map into the XmlSchema
> object. Apparently, the author of AegisDatabinding thought that the
> commons code would do this sensible thing for itself.
I've applied the patch and committed it. I'll try and get a snapshot up
later tonight.
One note for the future though: the patch ended up breaking a couple of
unit tests in the aegis databinding. The patch should have also
included fixes for those tests. I went ahead and fixed the tests.
> I would be most grateful for a snapshot with this fix in it.
>
>
>
> I did not propose any change to target namespace handling. I'll open a
> separate JIRA since I'm not sure what is right.
>
>
>
> The patch does not include the test case. That's new files, which is
> more complex.
--
J. Daniel Kulp
Principal Engineer
IONA
P: 781-902-8727 C: 508-380-7194
daniel.kulp@iona.com
http://www.dankulp.com/blog