[jira] Commented: (PIVOT-458) Add a "split" property to ListButton, CalendarButton, and ColorPickerButton

["Greg Brown (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PIVOT-458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12859460#action_12859460 ] 

Greg Brown commented on PIVOT-458:
----------------------------------

Note that this change will require some additional changes to how events are handled in these components. Button press isn't currently fired until after the click event, which isn't consistent with most other UI toolkits (which show the popup on mouse down). 

Also, button press invokes the button's action, which we don't necessarily want to do: 

- ListButton, CalendarButton, and ColorPickerButton should only fire button press when split and the content area is clicked, or a list item is selected. 
- MenuButton should never fire button press. 

Finally, we may want to draw a divider between the content area and the trigger when "split" is true, as well as show a hover state like we do in Spinner.


> Add a "split" property to ListButton, CalendarButton, and ColorPickerButton
> ---------------------------------------------------------------------------
>
>                 Key: PIVOT-458
>                 URL: https://issues.apache.org/jira/browse/PIVOT-458
>             Project: Pivot
>          Issue Type: New Feature
>          Components: wtk
>            Reporter: Dirk Moebius
>            Priority: Minor
>             Fix For: 1.5.1
>
>         Attachments: listbutton-popup-splitpaint.patch, listbutton-popup.patch, menubutton-popup.patch, office-listbutton-hovered.png, office-listbutton-normal.png, office-listbutton-pressed.png, office-listbutton-triggerclicked.png
>
>
> I found this to be a requirement in my application: if the user clicks the label part of a LinkButton, the button should fire immediately without showing the popup, thus invoking the action with the currently selected entry. If the user clicks the triangle part, the popup should be shown.
> I patched LinkButton to add a new boolean property called "showPopupOnTriggerClickOnly" to TerraListButtonSkin (I couldn't think of a better name, sorry). If set to true, the ListButton popup will only show up if the user clicks the triangle, but not if the user clicks the rest of the button. However, ButtonPressListeners fire as usual, if the user clicks any part of the button. If the property is false, the behavior is as it was before. The default value of the property is false.
> I tested the patch in my application and ComponentExplorer and it works good.
> It would be nice if you integrate the patch. Otherwise I'd still have the option to write a custom skin, but I think this patch could be interesting to other developers as well.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.