You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tuscany.apache.org by Greg Dritschler <gr...@gmail.com> on 2012/02/20 20:03:20 UTC

TUSCANY-4005 is in error

I believe the fix for TUSCANY-4005 is in error.  The goal of the fix was to
comply with this requirement:

The target component has multiple services. According to the following text
in the assembly specification, the target component must have one and only
one service with a compatible interface.

 1844 If <service-name> is not present, the target component MUST have one
and only
 1845 one service with an interface that is a compatible superset of the
wire source's
 1845 interface and satisifies the policy requirements of the wire source,
and the SCA
 1846 runtime MUST use this service for the wire. [ASM60048]

The fix checks if there are multiple candidate targets BEFORE DOING ANY
FILTERING for interface compatibility or policy matching.  If the target
does have one and only one service with a compatible interface and policy,
you now get the error introduced by the fix.  This was not the intention.

Re: TUSCANY-4005 is in error

Posted by Simon Laws <si...@googlemail.com>.
On Tue, Feb 21, 2012 at 10:04 AM, Simon Laws <si...@googlemail.com> wrote:
> On Mon, Feb 20, 2012 at 7:03 PM, Greg Dritschler
> <gr...@gmail.com> wrote:
>> I believe the fix for TUSCANY-4005 is in error.  The goal of the fix was to
>> comply with this requirement:
>>
>> The target component has multiple services. According to the following text
>> in the assembly specification, the target component must have one and only
>> one service with a compatible interface.
>>
>>  1844 If <service-name> is not present, the target component MUST have one
>> and only
>>  1845 one service with an interface that is a compatible superset of the
>> wire source's
>>  1845 interface and satisifies the policy requirements of the wire source,
>> and the SCA
>>  1846 runtime MUST use this service for the wire. [ASM60048]
>>
>> The fix checks if there are multiple candidate targets BEFORE DOING ANY
>> FILTERING for interface compatibility or policy matching.  If the target
>> does have one and only one service with a compatible interface and policy,
>> you now get the error introduced by the fix.  This was not the intention.
>
> My mistake, let me switch the test around.
>
> Simon
>
> --
> Apache Tuscany committer: tuscany.apache.org
> Co-author of a book about Tuscany and SCA: tuscanyinaction.com

Change applied at r1291714

Simon

-- 
Apache Tuscany committer: tuscany.apache.org
Co-author of a book about Tuscany and SCA: tuscanyinaction.com

Re: TUSCANY-4005 is in error

Posted by Simon Laws <si...@googlemail.com>.
On Mon, Feb 20, 2012 at 7:03 PM, Greg Dritschler
<gr...@gmail.com> wrote:
> I believe the fix for TUSCANY-4005 is in error.  The goal of the fix was to
> comply with this requirement:
>
> The target component has multiple services. According to the following text
> in the assembly specification, the target component must have one and only
> one service with a compatible interface.
>
>  1844 If <service-name> is not present, the target component MUST have one
> and only
>  1845 one service with an interface that is a compatible superset of the
> wire source's
>  1845 interface and satisifies the policy requirements of the wire source,
> and the SCA
>  1846 runtime MUST use this service for the wire. [ASM60048]
>
> The fix checks if there are multiple candidate targets BEFORE DOING ANY
> FILTERING for interface compatibility or policy matching.  If the target
> does have one and only one service with a compatible interface and policy,
> you now get the error introduced by the fix.  This was not the intention.

My mistake, let me switch the test around.

Simon

-- 
Apache Tuscany committer: tuscany.apache.org
Co-author of a book about Tuscany and SCA: tuscanyinaction.com