You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by jo...@apache.org on 2018/11/28 22:26:50 UTC
[1/4] impala git commit: IMPALA-7823: Clean up unused Java imports
Repository: impala
Updated Branches:
refs/heads/master af7476d55 -> 96f976534
IMPALA-7823: Clean up unused Java imports
Cleans up unused Java imports.
Testing: This is only a source-level change. Verified that the FE builds
correctly. Ran FE tests.
Change-Id: Ic1820a7f9e55dc168510987520949026169f445e
Reviewed-on: http://gerrit.cloudera.org:8080/11987
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Project: http://git-wip-us.apache.org/repos/asf/impala/repo
Commit: http://git-wip-us.apache.org/repos/asf/impala/commit/a39c8472
Tree: http://git-wip-us.apache.org/repos/asf/impala/tree/a39c8472
Diff: http://git-wip-us.apache.org/repos/asf/impala/diff/a39c8472
Branch: refs/heads/master
Commit: a39c8472adc5bd832b0fdd0469f8152356708974
Parents: af7476d
Author: Paul Rogers <pr...@cloudera.com>
Authored: Mon Nov 26 12:13:00 2018 -0800
Committer: Impala Public Jenkins <im...@cloudera.com>
Committed: Wed Nov 28 01:17:36 2018 +0000
----------------------------------------------------------------------
.../org/apache/impala/analysis/AlterTableStmt.java | 1 -
.../apache/impala/analysis/ColumnLineageGraph.java | 1 -
.../impala/analysis/CreateFunctionStmtBase.java | 1 -
.../org/apache/impala/analysis/ParquetHelper.java | 1 -
.../java/org/apache/impala/analysis/PlanHint.java | 2 --
.../org/apache/impala/analysis/PrivilegeSpec.java | 1 -
.../impala/authorization/SentryAuthProvider.java | 10 +++-------
.../org/apache/impala/catalog/CatalogDeltaLog.java | 1 -
.../org/apache/impala/catalog/CatalogObjectCache.java | 2 --
.../java/org/apache/impala/catalog/FeFsTable.java | 1 -
.../java/org/apache/impala/catalog/HdfsPartition.java | 1 -
.../catalog/HdfsPartitionLocationCompressor.java | 2 --
.../org/apache/impala/catalog/ImpaladCatalog.java | 1 -
.../org/apache/impala/catalog/PartitionStatsUtil.java | 1 -
.../apache/impala/catalog/local/LocalFsPartition.java | 3 ---
.../java/org/apache/impala/common/FileSystemUtil.java | 1 -
.../main/java/org/apache/impala/common/JniUtil.java | 1 -
.../java/org/apache/impala/planner/DataPartition.java | 3 ---
.../java/org/apache/impala/planner/HdfsScanNode.java | 1 -
.../java/org/apache/impala/planner/JoinBuildSink.java | 1 -
.../java/org/apache/impala/planner/KuduScanNode.java | 1 -
.../java/org/apache/impala/planner/ValueRange.java | 3 ---
.../org/apache/impala/rewrite/FoldConstantsRule.java | 1 -
.../impala/rewrite/RemoveRedundantStringCast.java | 1 -
.../java/org/apache/impala/service/FeSupport.java | 2 --
.../main/java/org/apache/impala/service/Frontend.java | 2 --
.../java/org/apache/impala/service/JniCatalog.java | 4 ----
.../java/org/apache/impala/service/JniFrontend.java | 1 -
.../java/org/apache/impala/util/NativeLogger.java | 3 ---
.../impala/analysis/StmtMetadataLoaderTest.java | 1 -
.../java/org/apache/impala/catalog/CatalogTest.java | 8 --------
.../datagenerator/HBaseTestDataRegionAssignment.java | 8 --------
.../apache/impala/hive/executor/UdfExecutorTest.java | 1 -
.../java/org/apache/impala/planner/S3PlannerTest.java | 2 --
.../impala/testutil/CatalogServiceTestCatalog.java | 2 --
.../apache/impala/testutil/ImpaladTestCatalog.java | 1 -
.../org/apache/impala/testutil/TestFileParser.java | 1 -
.../test/java/org/apache/impala/util/JniUtilTest.java | 14 +++-----------
.../java/org/apache/impala/util/TestTopNCache.java | 1 -
39 files changed, 6 insertions(+), 87 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/impala/blob/a39c8472/fe/src/main/java/org/apache/impala/analysis/AlterTableStmt.java
----------------------------------------------------------------------
diff --git a/fe/src/main/java/org/apache/impala/analysis/AlterTableStmt.java b/fe/src/main/java/org/apache/impala/analysis/AlterTableStmt.java
index 0089f0d..6304678 100644
--- a/fe/src/main/java/org/apache/impala/analysis/AlterTableStmt.java
+++ b/fe/src/main/java/org/apache/impala/analysis/AlterTableStmt.java
@@ -20,7 +20,6 @@ package org.apache.impala.analysis;
import java.util.List;
import org.apache.impala.authorization.Privilege;
-import org.apache.impala.catalog.DataSourceTable;
import org.apache.impala.catalog.FeDataSourceTable;
import org.apache.impala.catalog.FeTable;
import org.apache.impala.common.AnalysisException;
http://git-wip-us.apache.org/repos/asf/impala/blob/a39c8472/fe/src/main/java/org/apache/impala/analysis/ColumnLineageGraph.java
----------------------------------------------------------------------
diff --git a/fe/src/main/java/org/apache/impala/analysis/ColumnLineageGraph.java b/fe/src/main/java/org/apache/impala/analysis/ColumnLineageGraph.java
index 7df6e29..28d7674 100644
--- a/fe/src/main/java/org/apache/impala/analysis/ColumnLineageGraph.java
+++ b/fe/src/main/java/org/apache/impala/analysis/ColumnLineageGraph.java
@@ -17,7 +17,6 @@
package org.apache.impala.analysis;
-import java.util.Arrays;
import java.util.Collection;
import java.util.LinkedHashMap;
import java.util.List;
http://git-wip-us.apache.org/repos/asf/impala/blob/a39c8472/fe/src/main/java/org/apache/impala/analysis/CreateFunctionStmtBase.java
----------------------------------------------------------------------
diff --git a/fe/src/main/java/org/apache/impala/analysis/CreateFunctionStmtBase.java b/fe/src/main/java/org/apache/impala/analysis/CreateFunctionStmtBase.java
index ea48b3b..0d4d9bb 100644
--- a/fe/src/main/java/org/apache/impala/analysis/CreateFunctionStmtBase.java
+++ b/fe/src/main/java/org/apache/impala/analysis/CreateFunctionStmtBase.java
@@ -25,7 +25,6 @@ import org.apache.hadoop.fs.permission.FsAction;
import org.apache.impala.authorization.AuthorizeableFn;
import org.apache.impala.authorization.Privilege;
import org.apache.impala.authorization.PrivilegeRequest;
-import org.apache.impala.catalog.ImpaladCatalog;
import org.apache.impala.catalog.FeDb;
import org.apache.impala.catalog.Function;
import org.apache.impala.catalog.Type;
http://git-wip-us.apache.org/repos/asf/impala/blob/a39c8472/fe/src/main/java/org/apache/impala/analysis/ParquetHelper.java
----------------------------------------------------------------------
diff --git a/fe/src/main/java/org/apache/impala/analysis/ParquetHelper.java b/fe/src/main/java/org/apache/impala/analysis/ParquetHelper.java
index e3d5554..dad2420 100644
--- a/fe/src/main/java/org/apache/impala/analysis/ParquetHelper.java
+++ b/fe/src/main/java/org/apache/impala/analysis/ParquetHelper.java
@@ -27,7 +27,6 @@ import com.google.common.base.Preconditions;
import com.google.common.collect.Maps;
import org.apache.hadoop.fs.FileSystem;
import org.apache.hadoop.fs.Path;
-import org.apache.hadoop.fs.permission.FsAction;
import org.apache.parquet.hadoop.metadata.ParquetMetadata;
import org.apache.parquet.hadoop.ParquetFileReader;
import org.apache.parquet.schema.OriginalType;
http://git-wip-us.apache.org/repos/asf/impala/blob/a39c8472/fe/src/main/java/org/apache/impala/analysis/PlanHint.java
----------------------------------------------------------------------
diff --git a/fe/src/main/java/org/apache/impala/analysis/PlanHint.java b/fe/src/main/java/org/apache/impala/analysis/PlanHint.java
index d16919f..595bc47 100644
--- a/fe/src/main/java/org/apache/impala/analysis/PlanHint.java
+++ b/fe/src/main/java/org/apache/impala/analysis/PlanHint.java
@@ -18,11 +18,9 @@
package org.apache.impala.analysis;
-import java.util.ArrayList;
import java.util.List;
import com.google.common.base.Joiner;
-import com.google.common.base.Preconditions;
import com.google.common.collect.Lists;
/**
http://git-wip-us.apache.org/repos/asf/impala/blob/a39c8472/fe/src/main/java/org/apache/impala/analysis/PrivilegeSpec.java
----------------------------------------------------------------------
diff --git a/fe/src/main/java/org/apache/impala/analysis/PrivilegeSpec.java b/fe/src/main/java/org/apache/impala/analysis/PrivilegeSpec.java
index f14b304..2984c4c 100644
--- a/fe/src/main/java/org/apache/impala/analysis/PrivilegeSpec.java
+++ b/fe/src/main/java/org/apache/impala/analysis/PrivilegeSpec.java
@@ -23,7 +23,6 @@ import org.apache.impala.authorization.Privilege;
import org.apache.impala.catalog.FeDataSourceTable;
import org.apache.impala.catalog.FeTable;
import org.apache.impala.catalog.FeView;
-import org.apache.impala.catalog.PrincipalPrivilege;
import org.apache.impala.catalog.TableLoadingException;
import org.apache.impala.common.AnalysisException;
import org.apache.impala.thrift.TPrivilege;
http://git-wip-us.apache.org/repos/asf/impala/blob/a39c8472/fe/src/main/java/org/apache/impala/authorization/SentryAuthProvider.java
----------------------------------------------------------------------
diff --git a/fe/src/main/java/org/apache/impala/authorization/SentryAuthProvider.java b/fe/src/main/java/org/apache/impala/authorization/SentryAuthProvider.java
index a4f0743..dc30dff 100644
--- a/fe/src/main/java/org/apache/impala/authorization/SentryAuthProvider.java
+++ b/fe/src/main/java/org/apache/impala/authorization/SentryAuthProvider.java
@@ -17,14 +17,8 @@
package org.apache.impala.authorization;
-import com.google.common.base.Preconditions;
-
-import org.apache.impala.catalog.AuthorizationPolicy;
-
import org.apache.commons.lang.reflect.ConstructorUtils;
-import org.apache.sentry.core.common.Model;
-import org.apache.sentry.core.model.db.HivePrivilegeModel;
-import org.apache.sentry.policy.common.PolicyEngine;
+import org.apache.impala.catalog.AuthorizationPolicy;
import org.apache.sentry.policy.engine.common.CommonPolicyEngine;
import org.apache.sentry.provider.cache.SimpleCacheProviderBackend;
import org.apache.sentry.provider.common.ProviderBackend;
@@ -32,6 +26,8 @@ import org.apache.sentry.provider.common.ProviderBackendContext;
import org.apache.sentry.provider.common.ResourceAuthorizationProvider;
import org.apache.sentry.provider.file.SimpleFileProviderBackend;
+import com.google.common.base.Preconditions;
+
/**
* Wrapper to facilitate differences in Sentry APIs across Sentry versions.
*/
http://git-wip-us.apache.org/repos/asf/impala/blob/a39c8472/fe/src/main/java/org/apache/impala/catalog/CatalogDeltaLog.java
----------------------------------------------------------------------
diff --git a/fe/src/main/java/org/apache/impala/catalog/CatalogDeltaLog.java b/fe/src/main/java/org/apache/impala/catalog/CatalogDeltaLog.java
index 1a5e2ec..b4267c0 100644
--- a/fe/src/main/java/org/apache/impala/catalog/CatalogDeltaLog.java
+++ b/fe/src/main/java/org/apache/impala/catalog/CatalogDeltaLog.java
@@ -23,7 +23,6 @@ import java.util.SortedMap;
import java.util.TreeMap;
import org.apache.impala.thrift.TCatalogObject;
-import org.apache.impala.thrift.TTable;
import com.google.common.base.Preconditions;
import com.google.common.collect.ImmutableList;
http://git-wip-us.apache.org/repos/asf/impala/blob/a39c8472/fe/src/main/java/org/apache/impala/catalog/CatalogObjectCache.java
----------------------------------------------------------------------
diff --git a/fe/src/main/java/org/apache/impala/catalog/CatalogObjectCache.java b/fe/src/main/java/org/apache/impala/catalog/CatalogObjectCache.java
index 38698c5..e92c070 100644
--- a/fe/src/main/java/org/apache/impala/catalog/CatalogObjectCache.java
+++ b/fe/src/main/java/org/apache/impala/catalog/CatalogObjectCache.java
@@ -22,8 +22,6 @@ import java.util.List;
import java.util.Set;
import java.util.concurrent.ConcurrentHashMap;
-import org.apache.log4j.Logger;
-
import com.google.common.base.Preconditions;
import com.google.common.collect.Lists;
http://git-wip-us.apache.org/repos/asf/impala/blob/a39c8472/fe/src/main/java/org/apache/impala/catalog/FeFsTable.java
----------------------------------------------------------------------
diff --git a/fe/src/main/java/org/apache/impala/catalog/FeFsTable.java b/fe/src/main/java/org/apache/impala/catalog/FeFsTable.java
index 0c861af..5c619a2 100644
--- a/fe/src/main/java/org/apache/impala/catalog/FeFsTable.java
+++ b/fe/src/main/java/org/apache/impala/catalog/FeFsTable.java
@@ -28,7 +28,6 @@ import java.util.TreeMap;
import org.apache.hadoop.hive.metastore.api.FieldSchema;
import org.apache.impala.analysis.Expr;
import org.apache.impala.analysis.LiteralExpr;
-import org.apache.impala.analysis.NullLiteral;
import org.apache.impala.analysis.PartitionKeyValue;
import org.apache.impala.catalog.HdfsPartition.FileDescriptor;
import org.apache.impala.common.AnalysisException;
http://git-wip-us.apache.org/repos/asf/impala/blob/a39c8472/fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java
----------------------------------------------------------------------
diff --git a/fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java b/fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java
index 0a356ae..cd52b5b 100644
--- a/fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java
+++ b/fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java
@@ -21,7 +21,6 @@ import java.io.IOException;
import java.nio.ByteBuffer;
import java.util.Collection;
import java.util.Comparator;
-import java.util.Iterator;
import java.util.List;
import java.util.Map;
import java.util.Set;
http://git-wip-us.apache.org/repos/asf/impala/blob/a39c8472/fe/src/main/java/org/apache/impala/catalog/HdfsPartitionLocationCompressor.java
----------------------------------------------------------------------
diff --git a/fe/src/main/java/org/apache/impala/catalog/HdfsPartitionLocationCompressor.java b/fe/src/main/java/org/apache/impala/catalog/HdfsPartitionLocationCompressor.java
index 94b9e4d..939bcf6 100644
--- a/fe/src/main/java/org/apache/impala/catalog/HdfsPartitionLocationCompressor.java
+++ b/fe/src/main/java/org/apache/impala/catalog/HdfsPartitionLocationCompressor.java
@@ -17,8 +17,6 @@
package org.apache.impala.catalog;
-import java.util.ArrayList;
-import java.util.HashMap;
import java.util.List;
import org.apache.impala.common.Pair;
http://git-wip-us.apache.org/repos/asf/impala/blob/a39c8472/fe/src/main/java/org/apache/impala/catalog/ImpaladCatalog.java
----------------------------------------------------------------------
diff --git a/fe/src/main/java/org/apache/impala/catalog/ImpaladCatalog.java b/fe/src/main/java/org/apache/impala/catalog/ImpaladCatalog.java
index cd31279..8f97486 100644
--- a/fe/src/main/java/org/apache/impala/catalog/ImpaladCatalog.java
+++ b/fe/src/main/java/org/apache/impala/catalog/ImpaladCatalog.java
@@ -19,7 +19,6 @@ package org.apache.impala.catalog;
import java.nio.ByteBuffer;
import java.util.ArrayDeque;
-import java.util.List;
import java.util.Set;
import java.util.concurrent.atomic.AtomicLong;
http://git-wip-us.apache.org/repos/asf/impala/blob/a39c8472/fe/src/main/java/org/apache/impala/catalog/PartitionStatsUtil.java
----------------------------------------------------------------------
diff --git a/fe/src/main/java/org/apache/impala/catalog/PartitionStatsUtil.java b/fe/src/main/java/org/apache/impala/catalog/PartitionStatsUtil.java
index d3299f5..c93b245 100644
--- a/fe/src/main/java/org/apache/impala/catalog/PartitionStatsUtil.java
+++ b/fe/src/main/java/org/apache/impala/catalog/PartitionStatsUtil.java
@@ -25,7 +25,6 @@ import org.apache.impala.common.ImpalaRuntimeException;
import org.apache.impala.util.CompressionUtil;
import org.apache.impala.util.MetaStoreUtil;
-import java.util.Iterator;
import java.util.List;
import java.util.Map;
import org.apache.commons.codec.binary.Base64;
http://git-wip-us.apache.org/repos/asf/impala/blob/a39c8472/fe/src/main/java/org/apache/impala/catalog/local/LocalFsPartition.java
----------------------------------------------------------------------
diff --git a/fe/src/main/java/org/apache/impala/catalog/local/LocalFsPartition.java b/fe/src/main/java/org/apache/impala/catalog/local/LocalFsPartition.java
index c594873..522e984 100644
--- a/fe/src/main/java/org/apache/impala/catalog/local/LocalFsPartition.java
+++ b/fe/src/main/java/org/apache/impala/catalog/local/LocalFsPartition.java
@@ -17,7 +17,6 @@
package org.apache.impala.catalog.local;
-import java.io.IOException;
import java.util.List;
import java.util.Map;
@@ -30,7 +29,6 @@ import org.apache.impala.catalog.FeCatalogUtils;
import org.apache.impala.catalog.FeFsPartition;
import org.apache.impala.catalog.FeFsTable;
import org.apache.impala.catalog.HdfsFileFormat;
-import org.apache.impala.catalog.HdfsPartition;
import org.apache.impala.catalog.HdfsPartition.FileDescriptor;
import org.apache.impala.catalog.HdfsStorageDescriptor;
import org.apache.impala.catalog.HdfsStorageDescriptor.InvalidStorageDescriptorException;
@@ -41,7 +39,6 @@ import org.apache.impala.thrift.TPartitionStats;
import com.google.common.base.Preconditions;
import com.google.common.collect.ImmutableList;
-import com.google.common.collect.Maps;
public class LocalFsPartition implements FeFsPartition {
private final LocalFsTable table_;
http://git-wip-us.apache.org/repos/asf/impala/blob/a39c8472/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java
----------------------------------------------------------------------
diff --git a/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java b/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java
index 43d164b..21e30ac 100644
--- a/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java
+++ b/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java
@@ -43,7 +43,6 @@ import org.apache.impala.catalog.HdfsCompression;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
-import com.google.common.base.Objects;
import com.google.common.base.Preconditions;
/**
http://git-wip-us.apache.org/repos/asf/impala/blob/a39c8472/fe/src/main/java/org/apache/impala/common/JniUtil.java
----------------------------------------------------------------------
diff --git a/fe/src/main/java/org/apache/impala/common/JniUtil.java b/fe/src/main/java/org/apache/impala/common/JniUtil.java
index 37e2769..edfcd8c 100644
--- a/fe/src/main/java/org/apache/impala/common/JniUtil.java
+++ b/fe/src/main/java/org/apache/impala/common/JniUtil.java
@@ -41,7 +41,6 @@ import org.apache.thrift.protocol.TBinaryProtocol;
import org.apache.thrift.protocol.TProtocolFactory;
import com.google.common.base.Joiner;
-import com.google.common.base.Strings;
import org.apache.impala.thrift.TGetJvmMemoryMetricsResponse;
import org.apache.impala.thrift.TGetJvmThreadsInfoRequest;
http://git-wip-us.apache.org/repos/asf/impala/blob/a39c8472/fe/src/main/java/org/apache/impala/planner/DataPartition.java
----------------------------------------------------------------------
diff --git a/fe/src/main/java/org/apache/impala/planner/DataPartition.java b/fe/src/main/java/org/apache/impala/planner/DataPartition.java
index 67a411a..62019ae 100644
--- a/fe/src/main/java/org/apache/impala/planner/DataPartition.java
+++ b/fe/src/main/java/org/apache/impala/planner/DataPartition.java
@@ -19,9 +19,6 @@ package org.apache.impala.planner;
import java.util.List;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
-
import org.apache.impala.analysis.Analyzer;
import org.apache.impala.analysis.Expr;
import org.apache.impala.analysis.ExprSubstitutionMap;
http://git-wip-us.apache.org/repos/asf/impala/blob/a39c8472/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java
----------------------------------------------------------------------
diff --git a/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java b/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java
index 1f4c2bd..4cdfbeb 100644
--- a/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java
+++ b/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java
@@ -39,7 +39,6 @@ import org.apache.impala.analysis.FunctionParams;
import org.apache.impala.analysis.InPredicate;
import org.apache.impala.analysis.IsNotEmptyPredicate;
import org.apache.impala.analysis.LiteralExpr;
-import org.apache.impala.analysis.NullLiteral;
import org.apache.impala.analysis.SlotDescriptor;
import org.apache.impala.analysis.SlotId;
import org.apache.impala.analysis.SlotRef;
http://git-wip-us.apache.org/repos/asf/impala/blob/a39c8472/fe/src/main/java/org/apache/impala/planner/JoinBuildSink.java
----------------------------------------------------------------------
diff --git a/fe/src/main/java/org/apache/impala/planner/JoinBuildSink.java b/fe/src/main/java/org/apache/impala/planner/JoinBuildSink.java
index 192602a..a9bea59 100644
--- a/fe/src/main/java/org/apache/impala/planner/JoinBuildSink.java
+++ b/fe/src/main/java/org/apache/impala/planner/JoinBuildSink.java
@@ -21,7 +21,6 @@ import java.util.List;
import org.apache.impala.analysis.BinaryPredicate;
import org.apache.impala.analysis.Expr;
-import org.apache.impala.analysis.ToSqlOptions;
import org.apache.impala.thrift.TDataSink;
import org.apache.impala.thrift.TDataSinkType;
import org.apache.impala.thrift.TExplainLevel;
http://git-wip-us.apache.org/repos/asf/impala/blob/a39c8472/fe/src/main/java/org/apache/impala/planner/KuduScanNode.java
----------------------------------------------------------------------
diff --git a/fe/src/main/java/org/apache/impala/planner/KuduScanNode.java b/fe/src/main/java/org/apache/impala/planner/KuduScanNode.java
index 3bb7b6f..aa18f15 100644
--- a/fe/src/main/java/org/apache/impala/planner/KuduScanNode.java
+++ b/fe/src/main/java/org/apache/impala/planner/KuduScanNode.java
@@ -29,7 +29,6 @@ import org.apache.impala.analysis.Expr;
import org.apache.impala.analysis.InPredicate;
import org.apache.impala.analysis.IsNullPredicate;
import org.apache.impala.analysis.LiteralExpr;
-import org.apache.impala.analysis.NullLiteral;
import org.apache.impala.analysis.NumericLiteral;
import org.apache.impala.analysis.SlotDescriptor;
import org.apache.impala.analysis.SlotRef;
http://git-wip-us.apache.org/repos/asf/impala/blob/a39c8472/fe/src/main/java/org/apache/impala/planner/ValueRange.java
----------------------------------------------------------------------
diff --git a/fe/src/main/java/org/apache/impala/planner/ValueRange.java b/fe/src/main/java/org/apache/impala/planner/ValueRange.java
index 4b8f252..97edfb8 100644
--- a/fe/src/main/java/org/apache/impala/planner/ValueRange.java
+++ b/fe/src/main/java/org/apache/impala/planner/ValueRange.java
@@ -17,9 +17,6 @@
package org.apache.impala.planner;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
-
import org.apache.impala.analysis.Analyzer;
import org.apache.impala.analysis.BinaryPredicate;
import org.apache.impala.analysis.CompoundPredicate;
http://git-wip-us.apache.org/repos/asf/impala/blob/a39c8472/fe/src/main/java/org/apache/impala/rewrite/FoldConstantsRule.java
----------------------------------------------------------------------
diff --git a/fe/src/main/java/org/apache/impala/rewrite/FoldConstantsRule.java b/fe/src/main/java/org/apache/impala/rewrite/FoldConstantsRule.java
index dd0052f..9a0e714 100644
--- a/fe/src/main/java/org/apache/impala/rewrite/FoldConstantsRule.java
+++ b/fe/src/main/java/org/apache/impala/rewrite/FoldConstantsRule.java
@@ -20,7 +20,6 @@ package org.apache.impala.rewrite;
import org.apache.impala.analysis.Analyzer;
import org.apache.impala.analysis.Expr;
import org.apache.impala.analysis.LiteralExpr;
-import org.apache.impala.analysis.NullLiteral;
import org.apache.impala.analysis.CastExpr;
import org.apache.impala.common.AnalysisException;
http://git-wip-us.apache.org/repos/asf/impala/blob/a39c8472/fe/src/main/java/org/apache/impala/rewrite/RemoveRedundantStringCast.java
----------------------------------------------------------------------
diff --git a/fe/src/main/java/org/apache/impala/rewrite/RemoveRedundantStringCast.java b/fe/src/main/java/org/apache/impala/rewrite/RemoveRedundantStringCast.java
index 97dcdbb..24f34ba 100644
--- a/fe/src/main/java/org/apache/impala/rewrite/RemoveRedundantStringCast.java
+++ b/fe/src/main/java/org/apache/impala/rewrite/RemoveRedundantStringCast.java
@@ -23,7 +23,6 @@ import org.apache.impala.analysis.CastExpr;
import org.apache.impala.analysis.Expr;
import org.apache.impala.analysis.LiteralExpr;
import org.apache.impala.analysis.TypeDef;
-import org.apache.impala.catalog.Type;
import org.apache.impala.common.AnalysisException;
/**
http://git-wip-us.apache.org/repos/asf/impala/blob/a39c8472/fe/src/main/java/org/apache/impala/service/FeSupport.java
----------------------------------------------------------------------
diff --git a/fe/src/main/java/org/apache/impala/service/FeSupport.java b/fe/src/main/java/org/apache/impala/service/FeSupport.java
index e67bf9d..261f0bd 100644
--- a/fe/src/main/java/org/apache/impala/service/FeSupport.java
+++ b/fe/src/main/java/org/apache/impala/service/FeSupport.java
@@ -24,7 +24,6 @@ import java.util.Set;
import org.apache.impala.analysis.BoolLiteral;
import org.apache.impala.analysis.Expr;
-import org.apache.impala.analysis.NullLiteral;
import org.apache.impala.analysis.SlotRef;
import org.apache.impala.analysis.TableName;
import org.apache.impala.common.InternalException;
@@ -47,7 +46,6 @@ import org.apache.impala.thrift.TResultRow;
import org.apache.impala.thrift.TSymbolLookupParams;
import org.apache.impala.thrift.TSymbolLookupResult;
import org.apache.impala.thrift.TTable;
-import org.apache.impala.thrift.TUniqueId;
import org.apache.impala.util.NativeLibUtil;
import org.apache.thrift.TDeserializer;
import org.apache.thrift.TException;
http://git-wip-us.apache.org/repos/asf/impala/blob/a39c8472/fe/src/main/java/org/apache/impala/service/Frontend.java
----------------------------------------------------------------------
diff --git a/fe/src/main/java/org/apache/impala/service/Frontend.java b/fe/src/main/java/org/apache/impala/service/Frontend.java
index f6aa123..d67d1e0 100644
--- a/fe/src/main/java/org/apache/impala/service/Frontend.java
+++ b/fe/src/main/java/org/apache/impala/service/Frontend.java
@@ -100,7 +100,6 @@ import org.apache.impala.planner.HdfsScanNode;
import org.apache.impala.planner.PlanFragment;
import org.apache.impala.planner.Planner;
import org.apache.impala.planner.ScanNode;
-import org.apache.impala.thrift.TAdminRequest;
import org.apache.impala.thrift.TAlterDbParams;
import org.apache.impala.thrift.TCatalogOpRequest;
import org.apache.impala.thrift.TCatalogOpType;
@@ -136,7 +135,6 @@ import org.apache.impala.thrift.TResultSet;
import org.apache.impala.thrift.TResultSetMetadata;
import org.apache.impala.thrift.TShowFilesParams;
import org.apache.impala.thrift.TShowStatsOp;
-import org.apache.impala.thrift.TShutdownParams;
import org.apache.impala.thrift.TStmtType;
import org.apache.impala.thrift.TTableName;
import org.apache.impala.thrift.TUpdateCatalogCacheRequest;
http://git-wip-us.apache.org/repos/asf/impala/blob/a39c8472/fe/src/main/java/org/apache/impala/service/JniCatalog.java
----------------------------------------------------------------------
diff --git a/fe/src/main/java/org/apache/impala/service/JniCatalog.java b/fe/src/main/java/org/apache/impala/service/JniCatalog.java
index 2a709e8..457aa78 100644
--- a/fe/src/main/java/org/apache/impala/service/JniCatalog.java
+++ b/fe/src/main/java/org/apache/impala/service/JniCatalog.java
@@ -23,10 +23,7 @@ import com.google.common.collect.ImmutableList;
import com.google.common.collect.Lists;
import java.util.ArrayList;
-import java.util.Collections;
-import java.util.HashMap;
import java.util.List;
-import java.util.Map;
import java.util.UUID;
import org.apache.impala.authorization.SentryConfig;
@@ -58,7 +55,6 @@ import org.apache.impala.thrift.TGetTablesParams;
import org.apache.impala.thrift.TGetTableMetricsParams;
import org.apache.impala.thrift.TGetTablesResult;
import org.apache.impala.thrift.TLogLevel;
-import org.apache.impala.thrift.TPartitionStats;
import org.apache.impala.thrift.TPrioritizeLoadRequest;
import org.apache.impala.thrift.TResetMetadataRequest;
import org.apache.impala.thrift.TSentryAdminCheckRequest;
http://git-wip-us.apache.org/repos/asf/impala/blob/a39c8472/fe/src/main/java/org/apache/impala/service/JniFrontend.java
----------------------------------------------------------------------
diff --git a/fe/src/main/java/org/apache/impala/service/JniFrontend.java b/fe/src/main/java/org/apache/impala/service/JniFrontend.java
index db2ad29..6a1d7e9 100644
--- a/fe/src/main/java/org/apache/impala/service/JniFrontend.java
+++ b/fe/src/main/java/org/apache/impala/service/JniFrontend.java
@@ -87,7 +87,6 @@ import org.apache.impala.thrift.TLoadDataReq;
import org.apache.impala.thrift.TLoadDataResp;
import org.apache.impala.thrift.TLogLevel;
import org.apache.impala.thrift.TMetadataOpRequest;
-import org.apache.impala.thrift.TPrincipalType;
import org.apache.impala.thrift.TQueryCtx;
import org.apache.impala.thrift.TResultSet;
import org.apache.impala.thrift.TShowFilesParams;
http://git-wip-us.apache.org/repos/asf/impala/blob/a39c8472/fe/src/main/java/org/apache/impala/util/NativeLogger.java
----------------------------------------------------------------------
diff --git a/fe/src/main/java/org/apache/impala/util/NativeLogger.java b/fe/src/main/java/org/apache/impala/util/NativeLogger.java
index fc5b169..fd95d4b 100644
--- a/fe/src/main/java/org/apache/impala/util/NativeLogger.java
+++ b/fe/src/main/java/org/apache/impala/util/NativeLogger.java
@@ -17,9 +17,6 @@
package org.apache.impala.util;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
-
/**
* Class that manages loading and calling the native logging library to forward
* log4j log messages to be logged by glog.
http://git-wip-us.apache.org/repos/asf/impala/blob/a39c8472/fe/src/test/java/org/apache/impala/analysis/StmtMetadataLoaderTest.java
----------------------------------------------------------------------
diff --git a/fe/src/test/java/org/apache/impala/analysis/StmtMetadataLoaderTest.java b/fe/src/test/java/org/apache/impala/analysis/StmtMetadataLoaderTest.java
index 29eddfe..91aa72f 100644
--- a/fe/src/test/java/org/apache/impala/analysis/StmtMetadataLoaderTest.java
+++ b/fe/src/test/java/org/apache/impala/analysis/StmtMetadataLoaderTest.java
@@ -23,7 +23,6 @@ import org.apache.impala.analysis.StmtMetadataLoader.StmtTableCache;
import org.apache.impala.authorization.AuthorizationConfig;
import org.apache.impala.catalog.Catalog;
import org.apache.impala.catalog.FeTable;
-import org.apache.impala.catalog.Table;
import org.apache.impala.common.ImpalaException;
import org.apache.impala.common.InternalException;
import org.apache.impala.service.Frontend;
http://git-wip-us.apache.org/repos/asf/impala/blob/a39c8472/fe/src/test/java/org/apache/impala/catalog/CatalogTest.java
----------------------------------------------------------------------
diff --git a/fe/src/test/java/org/apache/impala/catalog/CatalogTest.java b/fe/src/test/java/org/apache/impala/catalog/CatalogTest.java
index b726af7..6b47bda 100644
--- a/fe/src/test/java/org/apache/impala/catalog/CatalogTest.java
+++ b/fe/src/test/java/org/apache/impala/catalog/CatalogTest.java
@@ -48,36 +48,28 @@ import org.apache.hadoop.hive.metastore.api.ColumnStatisticsData;
import org.apache.impala.analysis.FunctionName;
import org.apache.impala.analysis.LiteralExpr;
import org.apache.impala.analysis.NumericLiteral;
-import org.apache.impala.analysis.TableName;
import org.apache.impala.catalog.MetaStoreClientPool.MetaStoreClient;
-import org.apache.impala.common.FrontendTestBase;
import org.apache.impala.common.ImpalaException;
import org.apache.impala.common.Reference;
import org.apache.impala.service.BackendConfig;
import org.apache.impala.testutil.CatalogServiceTestCatalog;
-import org.apache.impala.thrift.CatalogObjectsConstants;
import org.apache.impala.thrift.TBackendGflags;
import org.apache.impala.thrift.TFunctionBinaryType;
import org.apache.impala.thrift.TGetPartitionStatsRequest;
-import org.apache.impala.thrift.TGetPartitionStatsResponse;
import org.apache.impala.thrift.TPartitionStats;
import org.apache.impala.thrift.TPrincipalType;
import org.apache.impala.thrift.TPrivilege;
import org.apache.impala.thrift.TPrivilegeLevel;
import org.apache.impala.thrift.TPrivilegeScope;
import org.apache.impala.thrift.TTableName;
-import org.apache.impala.thrift.TUniqueId;
import org.junit.Before;
import org.junit.Test;
-import com.google.common.base.Preconditions;
import com.google.common.base.Strings;
import com.google.common.collect.Lists;
import com.google.common.collect.Maps;
import com.google.common.collect.Sets;
-import junit.framework.AssertionFailedError;
-
public class CatalogTest {
private CatalogServiceCatalog catalog_;
http://git-wip-us.apache.org/repos/asf/impala/blob/a39c8472/fe/src/test/java/org/apache/impala/datagenerator/HBaseTestDataRegionAssignment.java
----------------------------------------------------------------------
diff --git a/fe/src/test/java/org/apache/impala/datagenerator/HBaseTestDataRegionAssignment.java b/fe/src/test/java/org/apache/impala/datagenerator/HBaseTestDataRegionAssignment.java
index 85f8510..0b13566 100644
--- a/fe/src/test/java/org/apache/impala/datagenerator/HBaseTestDataRegionAssignment.java
+++ b/fe/src/test/java/org/apache/impala/datagenerator/HBaseTestDataRegionAssignment.java
@@ -25,23 +25,15 @@ import java.util.List;
import org.apache.hadoop.conf.Configuration;
import org.apache.hadoop.hbase.ClusterStatus;
-import org.apache.hadoop.hbase.HRegionLocation;
import org.apache.hadoop.hbase.MetaTableAccessor;
import org.apache.hadoop.hbase.ServerName;
import org.apache.hadoop.hbase.TableName;
import org.apache.hadoop.hbase.client.Admin;
import org.apache.hadoop.hbase.client.Connection;
import org.apache.hadoop.hbase.client.ConnectionFactory;
-import org.apache.hadoop.hbase.client.Get;
import org.apache.hadoop.hbase.client.RegionInfo;
-import org.apache.hadoop.hbase.client.Result;
-import org.apache.hadoop.hbase.client.Table;
-import org.apache.hadoop.hbase.util.Bytes;
import org.apache.hadoop.hbase.util.Pair;
-import org.apache.hadoop.hbase.util.PairOfSameType;
-import org.apache.hadoop.hbase.util.Threads;
import org.apache.impala.planner.HBaseScanNode;
-
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
http://git-wip-us.apache.org/repos/asf/impala/blob/a39c8472/fe/src/test/java/org/apache/impala/hive/executor/UdfExecutorTest.java
----------------------------------------------------------------------
diff --git a/fe/src/test/java/org/apache/impala/hive/executor/UdfExecutorTest.java b/fe/src/test/java/org/apache/impala/hive/executor/UdfExecutorTest.java
index dad04a6..7ca7f4b 100644
--- a/fe/src/test/java/org/apache/impala/hive/executor/UdfExecutorTest.java
+++ b/fe/src/test/java/org/apache/impala/hive/executor/UdfExecutorTest.java
@@ -71,7 +71,6 @@ import org.apache.thrift.protocol.TBinaryProtocol;
import org.junit.Assert;
import org.junit.Test;
-import com.google.common.base.Joiner;
import com.google.common.base.Preconditions;
import com.google.common.base.Strings;
import com.google.common.collect.Lists;
http://git-wip-us.apache.org/repos/asf/impala/blob/a39c8472/fe/src/test/java/org/apache/impala/planner/S3PlannerTest.java
----------------------------------------------------------------------
diff --git a/fe/src/test/java/org/apache/impala/planner/S3PlannerTest.java b/fe/src/test/java/org/apache/impala/planner/S3PlannerTest.java
index 49f0188..364eea3 100644
--- a/fe/src/test/java/org/apache/impala/planner/S3PlannerTest.java
+++ b/fe/src/test/java/org/apache/impala/planner/S3PlannerTest.java
@@ -21,8 +21,6 @@ import static org.junit.Assume.assumeTrue;
import java.net.URI;
-import org.apache.commons.lang.StringUtils;
-import org.apache.hadoop.conf.Configuration;
import org.apache.hadoop.fs.Path;
import org.junit.Assert;
import org.junit.Before;
http://git-wip-us.apache.org/repos/asf/impala/blob/a39c8472/fe/src/test/java/org/apache/impala/testutil/CatalogServiceTestCatalog.java
----------------------------------------------------------------------
diff --git a/fe/src/test/java/org/apache/impala/testutil/CatalogServiceTestCatalog.java b/fe/src/test/java/org/apache/impala/testutil/CatalogServiceTestCatalog.java
index 3b61028..3310ecf 100644
--- a/fe/src/test/java/org/apache/impala/testutil/CatalogServiceTestCatalog.java
+++ b/fe/src/test/java/org/apache/impala/testutil/CatalogServiceTestCatalog.java
@@ -21,9 +21,7 @@ import org.apache.impala.authorization.SentryConfig;
import org.apache.impala.catalog.AuthorizationPolicy;
import org.apache.impala.catalog.CatalogServiceCatalog;
import org.apache.impala.common.ImpalaException;
-import org.apache.impala.service.BackendConfig;
import org.apache.impala.service.FeSupport;
-import org.apache.impala.thrift.TBackendGflags;
import org.apache.impala.thrift.TUniqueId;
/**
http://git-wip-us.apache.org/repos/asf/impala/blob/a39c8472/fe/src/test/java/org/apache/impala/testutil/ImpaladTestCatalog.java
----------------------------------------------------------------------
diff --git a/fe/src/test/java/org/apache/impala/testutil/ImpaladTestCatalog.java b/fe/src/test/java/org/apache/impala/testutil/ImpaladTestCatalog.java
index 0734ee0..60bbaeb 100644
--- a/fe/src/test/java/org/apache/impala/testutil/ImpaladTestCatalog.java
+++ b/fe/src/test/java/org/apache/impala/testutil/ImpaladTestCatalog.java
@@ -27,7 +27,6 @@ import org.apache.impala.catalog.FeDb;
import org.apache.impala.catalog.HdfsCachePool;
import org.apache.impala.catalog.HdfsTable;
import org.apache.impala.catalog.ImpaladCatalog;
-import org.apache.impala.catalog.Principal;
import org.apache.impala.catalog.PrincipalPrivilege;
import org.apache.impala.catalog.Role;
import org.apache.impala.catalog.Table;
http://git-wip-us.apache.org/repos/asf/impala/blob/a39c8472/fe/src/test/java/org/apache/impala/testutil/TestFileParser.java
----------------------------------------------------------------------
diff --git a/fe/src/test/java/org/apache/impala/testutil/TestFileParser.java b/fe/src/test/java/org/apache/impala/testutil/TestFileParser.java
index 0c62666..fb04704 100644
--- a/fe/src/test/java/org/apache/impala/testutil/TestFileParser.java
+++ b/fe/src/test/java/org/apache/impala/testutil/TestFileParser.java
@@ -30,7 +30,6 @@ import java.util.Scanner;
import org.apache.impala.common.InternalException;
import org.apache.impala.service.FeSupport;
-import org.apache.impala.thrift.TErrorCode;
import org.apache.impala.thrift.TQueryOptions;
import org.apache.log4j.Logger;
http://git-wip-us.apache.org/repos/asf/impala/blob/a39c8472/fe/src/test/java/org/apache/impala/util/JniUtilTest.java
----------------------------------------------------------------------
diff --git a/fe/src/test/java/org/apache/impala/util/JniUtilTest.java b/fe/src/test/java/org/apache/impala/util/JniUtilTest.java
index 6166179..a11b57e 100644
--- a/fe/src/test/java/org/apache/impala/util/JniUtilTest.java
+++ b/fe/src/test/java/org/apache/impala/util/JniUtilTest.java
@@ -17,21 +17,13 @@
package org.apache.impala.util;
-import static org.junit.Assert.*;
-
-import com.fasterxml.jackson.databind.JsonNode;
-import com.fasterxml.jackson.databind.ObjectMapper;
-import com.google.common.base.Preconditions;
-import org.apache.impala.thrift.TGetJMXJsonResponse;
-import org.junit.Test;
+import static org.junit.Assert.assertEquals;
import org.apache.impala.common.ImpalaException;
import org.apache.impala.common.JniUtil;
-import org.apache.thrift.protocol.TBinaryProtocol;
-import org.apache.thrift.protocol.TProtocolFactory;
import org.apache.impala.thrift.TCacheJarParams;
-
-import java.io.IOException;
+import org.apache.thrift.protocol.TBinaryProtocol;
+import org.junit.Test;
/**
* Unit tests for JniUtil functions.
http://git-wip-us.apache.org/repos/asf/impala/blob/a39c8472/fe/src/test/java/org/apache/impala/util/TestTopNCache.java
----------------------------------------------------------------------
diff --git a/fe/src/test/java/org/apache/impala/util/TestTopNCache.java b/fe/src/test/java/org/apache/impala/util/TestTopNCache.java
index 1b34599..159a14f 100644
--- a/fe/src/test/java/org/apache/impala/util/TestTopNCache.java
+++ b/fe/src/test/java/org/apache/impala/util/TestTopNCache.java
@@ -23,7 +23,6 @@ import org.junit.Test;
import com.google.common.base.Function;
-import java.util.Arrays;
import java.util.List;
/**
[2/4] impala git commit: IMPALA-7790: Skip some Kudu tests if
use_hybrid_clock=false
Posted by jo...@apache.org.
IMPALA-7790: Skip some Kudu tests if use_hybrid_clock=false
Since IMPALA-6812, we've run many of our tests against Kudu at the
READ_AT_SNAPSHOT scan level, which ensures consistent results. This
scan level is only supported if Kudu is run with the flag
--use_hybrid_clock=true (which is the default).
This patch uses the Kudu master webui to detect when use_hybrid_clock
is false and skips these tests.
Follow up work will address allowing these tests to run regardless of
the value of the flag.
Testing:
- Ran a full exhaustive build with use_hybrid_clock=false set in the
minicluster.
Change-Id: I4c9ed4a4ea0720760d65c98acfc394247ab2f1a2
Reviewed-on: http://gerrit.cloudera.org:8080/11851
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Project: http://git-wip-us.apache.org/repos/asf/impala/repo
Commit: http://git-wip-us.apache.org/repos/asf/impala/commit/a1407adf
Tree: http://git-wip-us.apache.org/repos/asf/impala/tree/a1407adf
Diff: http://git-wip-us.apache.org/repos/asf/impala/diff/a1407adf
Branch: refs/heads/master
Commit: a1407adf61cec9bdd2ebb5bb7a7ccbbf5d2edd41
Parents: a39c847
Author: Thomas Tauber-Marshall <tm...@cloudera.com>
Authored: Mon Oct 29 17:04:17 2018 -0700
Committer: Impala Public Jenkins <im...@cloudera.com>
Committed: Wed Nov 28 02:48:09 2018 +0000
----------------------------------------------------------------------
bin/impala-config.sh | 1 +
tests/common/kudu_test_suite.py | 28 ++++++++++++++++++++++++++--
tests/common/skip.py | 4 ++++
tests/custom_cluster/test_kudu.py | 2 ++
tests/metadata/test_ddl.py | 3 ++-
tests/query_test/test_kudu.py | 19 +++++++++++++++++--
6 files changed, 52 insertions(+), 5 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/impala/blob/a1407adf/bin/impala-config.sh
----------------------------------------------------------------------
diff --git a/bin/impala-config.sh b/bin/impala-config.sh
index 32df25d..ff13919 100755
--- a/bin/impala-config.sh
+++ b/bin/impala-config.sh
@@ -438,6 +438,7 @@ export NUM_CONCURRENT_TESTS="${NUM_CONCURRENT_TESTS-${CORES}}"
export KUDU_MASTER_HOSTS="${KUDU_MASTER_HOSTS:-127.0.0.1}"
export KUDU_MASTER_PORT="${KUDU_MASTER_PORT:-7051}"
+export KUDU_MASTER_WEBUI_PORT="${KUDU_MASTER_WEBUI_PORT:-8051}"
export IMPALA_FE_DIR="$IMPALA_HOME/fe"
export IMPALA_BE_DIR="$IMPALA_HOME/be"
http://git-wip-us.apache.org/repos/asf/impala/blob/a1407adf/tests/common/kudu_test_suite.py
----------------------------------------------------------------------
diff --git a/tests/common/kudu_test_suite.py b/tests/common/kudu_test_suite.py
index 876752b..5826c74 100644
--- a/tests/common/kudu_test_suite.py
+++ b/tests/common/kudu_test_suite.py
@@ -16,8 +16,9 @@
# under the License.
import os
-import string
import pytest
+import requests
+import string
from contextlib import contextmanager
from kudu.schema import (
BOOL,
@@ -36,9 +37,32 @@ from random import choice, sample
from string import ascii_lowercase, digits
from tests.common.impala_test_suite import ImpalaTestSuite
-from tests.common.skip import SkipIf
from tests.common.test_dimensions import create_uncompressed_text_dimension
+DEFAULT_KUDU_MASTER_WEBUI_PORT = os.getenv('KUDU_MASTER_WEBUI_PORT', '8051')
+
+
+def get_kudu_master_webpage(page_name):
+ kudu_master = pytest.config.option.kudu_master_hosts
+
+ if "," in kudu_master:
+ raise NotImplementedError("Multi-master not supported yet")
+ if ":" in kudu_master:
+ kudu_master_host = kudu_master.split(":")[0]
+ else:
+ kudu_master_host = kudu_master
+ url = "http://%s:%s/%s" % (kudu_master_host, DEFAULT_KUDU_MASTER_WEBUI_PORT, page_name)
+ return requests.get(url).text
+
+
+def get_kudu_master_flag(flag):
+ varz = get_kudu_master_webpage("varz")
+ for line in varz.split("\n"):
+ split = line.split("=")
+ if len(split) == 2 and split[0] == flag:
+ return split[1]
+ assert False, "Failed to find Kudu master flag: %s" % flag
+
class KuduTestSuite(ImpalaTestSuite):
# Lazily set.
http://git-wip-us.apache.org/repos/asf/impala/blob/a1407adf/tests/common/skip.py
----------------------------------------------------------------------
diff --git a/tests/common/skip.py b/tests/common/skip.py
index 41e119a..8ba7a06 100644
--- a/tests/common/skip.py
+++ b/tests/common/skip.py
@@ -25,6 +25,7 @@ import pytest
from functools import partial
from tests.common.environ import IMPALA_TEST_CLUSTER_PROPERTIES
+from tests.common.kudu_test_suite import get_kudu_master_flag
from tests.util.filesystem_utils import (
IS_ABFS,
IS_ADLS,
@@ -100,6 +101,9 @@ class SkipIfADLS:
class SkipIfKudu:
unsupported_env = pytest.mark.skipif(os.environ["KUDU_IS_SUPPORTED"] == "false",
reason="Kudu is not supported in this environment")
+ no_hybrid_clock = pytest.mark.skipif(
+ get_kudu_master_flag("--use_hybrid_clock") == "false",
+ reason="Test relies on --use_hybrid_clock=true in Kudu.")
class SkipIf:
skip_hbase = pytest.mark.skipif(pytest.config.option.skip_hbase,
http://git-wip-us.apache.org/repos/asf/impala/blob/a1407adf/tests/custom_cluster/test_kudu.py
----------------------------------------------------------------------
diff --git a/tests/custom_cluster/test_kudu.py b/tests/custom_cluster/test_kudu.py
index d79703d..ce86f3c 100644
--- a/tests/custom_cluster/test_kudu.py
+++ b/tests/custom_cluster/test_kudu.py
@@ -21,6 +21,7 @@ from kudu.schema import INT32
from tests.common.custom_cluster_test_suite import CustomClusterTestSuite
from tests.common.kudu_test_suite import KuduTestSuite
+from tests.common.skip import SkipIfKudu
from tests.common.test_dimensions import add_exec_option_dimension
KUDU_MASTER_HOSTS = pytest.config.option.kudu_master_hosts
@@ -42,6 +43,7 @@ class TestKuduOperations(CustomClusterTestSuite, KuduTestSuite):
@pytest.mark.execute_serially
@CustomClusterTestSuite.with_args(impalad_args=\
"--use_local_tz_for_unix_timestamp_conversions=true")
+ @SkipIfKudu.no_hybrid_clock
def test_local_tz_conversion_ops(self, vector, unique_database):
"""IMPALA-5539: Test Kudu timestamp reads/writes are correct with the
use_local_tz_for_unix_timestamp_conversions flag."""
http://git-wip-us.apache.org/repos/asf/impala/blob/a1407adf/tests/metadata/test_ddl.py
----------------------------------------------------------------------
diff --git a/tests/metadata/test_ddl.py b/tests/metadata/test_ddl.py
index b510af1..9d35f32 100644
--- a/tests/metadata/test_ddl.py
+++ b/tests/metadata/test_ddl.py
@@ -25,7 +25,7 @@ from test_ddl_base import TestDdlBase
from tests.beeswax.impala_beeswax import ImpalaBeeswaxException
from tests.common.impala_test_suite import LOG
from tests.common.parametrize import UniqueDatabase
-from tests.common.skip import SkipIf, SkipIfABFS, SkipIfADLS, SkipIfLocal
+from tests.common.skip import SkipIf, SkipIfABFS, SkipIfADLS, SkipIfKudu, SkipIfLocal
from tests.common.test_dimensions import create_single_exec_option_dimension
from tests.util.filesystem_utils import WAREHOUSE, IS_HDFS, IS_S3, IS_ADLS
from tests.common.impala_cluster import ImpalaCluster
@@ -282,6 +282,7 @@ class TestDdlStatements(TestDdlBase):
@SkipIf.kudu_not_supported
@UniqueDatabase.parametrize(sync_ddl=True)
+ @SkipIfKudu.no_hybrid_clock
def test_create_kudu(self, vector, unique_database):
vector.get_value('exec_option')['abort_on_error'] = False
vector.get_value('exec_option')['kudu_read_mode'] = "READ_AT_SNAPSHOT"
http://git-wip-us.apache.org/repos/asf/impala/blob/a1407adf/tests/query_test/test_kudu.py
----------------------------------------------------------------------
diff --git a/tests/query_test/test_kudu.py b/tests/query_test/test_kudu.py
index 5936649..f5edac4 100644
--- a/tests/query_test/test_kudu.py
+++ b/tests/query_test/test_kudu.py
@@ -39,7 +39,7 @@ from pytz import utc
from tests.common.kudu_test_suite import KuduTestSuite
from tests.common.impala_cluster import ImpalaCluster
-from tests.common.skip import SkipIfNotHdfsMinicluster
+from tests.common.skip import SkipIfNotHdfsMinicluster, SkipIfKudu
from tests.common.test_dimensions import add_exec_option_dimension
from tests.verifiers.metric_verifier import MetricVerifier
@@ -59,6 +59,7 @@ class TestKuduOperations(KuduTestSuite):
# these tests.
add_exec_option_dimension(cls, "kudu_read_mode", "READ_AT_SNAPSHOT")
+ @SkipIfKudu.no_hybrid_clock
def test_out_of_range_timestamps(self, vector, cursor, kudu_client, unique_database):
"""Test timestamp values that are outside of Impala's supported date range."""
cursor.execute("""CREATE TABLE %s.times (a INT PRIMARY KEY, ts TIMESTAMP)
@@ -86,40 +87,51 @@ class TestKuduOperations(KuduTestSuite):
self.run_test_case('QueryTest/kudu-overflow-ts-abort-on-error', vector,
use_db=unique_database)
+ @SkipIfKudu.no_hybrid_clock
def test_kudu_scan_node(self, vector, unique_database):
self.run_test_case('QueryTest/kudu-scan-node', vector, use_db=unique_database)
+ @SkipIfKudu.no_hybrid_clock
def test_kudu_insert(self, vector, unique_database):
self.run_test_case('QueryTest/kudu_insert', vector, use_db=unique_database)
@SkipIfNotHdfsMinicluster.tuned_for_minicluster
+ @SkipIfKudu.no_hybrid_clock
def test_kudu_insert_mem_limit(self, vector, unique_database):
self.run_test_case('QueryTest/kudu_insert_mem_limit', vector, use_db=unique_database)
+ @SkipIfKudu.no_hybrid_clock
def test_kudu_update(self, vector, unique_database):
self.run_test_case('QueryTest/kudu_update', vector, use_db=unique_database)
+ @SkipIfKudu.no_hybrid_clock
def test_kudu_upsert(self, vector, unique_database):
self.run_test_case('QueryTest/kudu_upsert', vector, use_db=unique_database)
+ @SkipIfKudu.no_hybrid_clock
def test_kudu_delete(self, vector, unique_database):
self.run_test_case('QueryTest/kudu_delete', vector, use_db=unique_database)
+ @SkipIfKudu.no_hybrid_clock
def test_kudu_partition_ddl(self, vector, unique_database):
self.run_test_case('QueryTest/kudu_partition_ddl', vector, use_db=unique_database)
@pytest.mark.skipif(pytest.config.option.testing_remote_cluster,
reason="Test references hardcoded hostnames: IMPALA-4873")
@pytest.mark.execute_serially
+ @SkipIfKudu.no_hybrid_clock
def test_kudu_alter_table(self, vector, unique_database):
self.run_test_case('QueryTest/kudu_alter', vector, use_db=unique_database)
+ @SkipIfKudu.no_hybrid_clock
def test_kudu_stats(self, vector, unique_database):
self.run_test_case('QueryTest/kudu_stats', vector, use_db=unique_database)
+ @SkipIfKudu.no_hybrid_clock
def test_kudu_describe(self, vector, unique_database):
self.run_test_case('QueryTest/kudu_describe', vector, use_db=unique_database)
+ @SkipIfKudu.no_hybrid_clock
def test_kudu_limit(self, vector, unique_database):
self.run_test_case('QueryTest/kudu_limit', vector, use_db=unique_database)
@@ -305,6 +317,7 @@ class TestKuduOperations(KuduTestSuite):
cursor.execute("SELECT * FROM %s.foo" % (unique_database))
assert cursor.fetchall() == [(0, 0)]
+ @SkipIfKudu.no_hybrid_clock
def test_kudu_col_removed(self, cursor, kudu_client, unique_database):
"""Test removing a Kudu column outside of Impala."""
cursor.execute("set kudu_read_mode=READ_AT_SNAPSHOT")
@@ -365,7 +378,7 @@ class TestKuduOperations(KuduTestSuite):
if kudu_client.table_exists(name):
kudu_client.delete_table(name)
-
+ @SkipIfKudu.no_hybrid_clock
def test_column_storage_attributes(self, cursor, unique_database):
"""Tests that for every valid combination of column type, encoding, and compression,
we can insert a value and scan it back from Kudu."""
@@ -642,6 +655,7 @@ class TestCreateExternalTable(KuduTestSuite):
except Exception as e:
assert "Table does not exist in Kudu: '%s'" % table_name in str(e)
+ @SkipIfKudu.no_hybrid_clock
def test_table_without_partitioning(self, cursor, kudu_client, unique_database):
"""Test a Kudu table created without partitioning (i.e. equivalent to a single
unbounded partition). It is not possible to create such a table in Impala, but
@@ -676,6 +690,7 @@ class TestCreateExternalTable(KuduTestSuite):
if kudu_client.table_exists(name):
kudu_client.delete_table(name)
+ @SkipIfKudu.no_hybrid_clock
def test_column_name_case(self, cursor, kudu_client, unique_database):
"""IMPALA-5286: Tests that an external Kudu table that was created with a column name
containing upper case letters is handled correctly."""
[4/4] impala git commit: IMPALA-7893: Correctly handle Ctrl+C for
cancelling a non-running query
Posted by jo...@apache.org.
IMPALA-7893: Correctly handle Ctrl+C for cancelling a non-running query
This patch fixes the issue with Ctrl+C handling for cancelling a
non-running query to behave similar to Linux shell.
Before (pressing Ctrl+C does not do anything):
[localhost:21000] default> select
After (pressing Ctrl+C cancels the query and starts a new prompt):
[localhost:21000] default> select^C
[localhost:21000] default>
Testing:
- Added a new cancellation test
- Ran all shell E2E tests
Change-Id: I80d7b2c2350224d88d0bfeb1745d9ed76e83cf6d
Reviewed-on: http://gerrit.cloudera.org:8080/11990
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Project: http://git-wip-us.apache.org/repos/asf/impala/repo
Commit: http://git-wip-us.apache.org/repos/asf/impala/commit/96f97653
Tree: http://git-wip-us.apache.org/repos/asf/impala/tree/96f97653
Diff: http://git-wip-us.apache.org/repos/asf/impala/diff/96f97653
Branch: refs/heads/master
Commit: 96f976534837dde6d3fb87ea02019b67d9c3ea78
Parents: e546e52
Author: Fredy Wijaya <fw...@cloudera.com>
Authored: Mon Nov 26 16:12:58 2018 -0800
Committer: Impala Public Jenkins <im...@cloudera.com>
Committed: Wed Nov 28 10:28:39 2018 +0000
----------------------------------------------------------------------
shell/impala_shell.py | 4 ++--
tests/custom_cluster/test_client_ssl.py | 1 -
tests/shell/test_shell_interactive.py | 6 ++++++
3 files changed, 8 insertions(+), 3 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/impala/blob/96f97653/shell/impala_shell.py
----------------------------------------------------------------------
diff --git a/shell/impala_shell.py b/shell/impala_shell.py
index 4f09bd8..340c3e7 100755
--- a/shell/impala_shell.py
+++ b/shell/impala_shell.py
@@ -523,7 +523,7 @@ class ImpalaShell(object, cmd.Cmd):
def _signal_handler(self, signal, frame):
"""Handles query cancellation on a Ctrl+C event"""
if self.last_query_handle is None or self.query_handle_closed:
- return
+ raise KeyboardInterrupt()
# Create a new connection to the impalad and cancel the query.
for cancel_try in xrange(ImpalaShell.CANCELLATION_TRIES):
try:
@@ -1733,7 +1733,7 @@ if __name__ == "__main__":
try:
shell.cmdloop(intro)
except KeyboardInterrupt:
- intro = '\n'
+ print_to_stderr('^C')
# A last measure against any exceptions thrown by an rpc
# not caught in the shell
except socket.error, (code, e):
http://git-wip-us.apache.org/repos/asf/impala/blob/96f97653/tests/custom_cluster/test_client_ssl.py
----------------------------------------------------------------------
diff --git a/tests/custom_cluster/test_client_ssl.py b/tests/custom_cluster/test_client_ssl.py
index edea640..f5ada13 100644
--- a/tests/custom_cluster/test_client_ssl.py
+++ b/tests/custom_cluster/test_client_ssl.py
@@ -107,7 +107,6 @@ class TestClientSsl(CustomClusterTestSuite):
result = p.get_result()
print result.stderr
- assert result.rc == 0
assert "Query Status: Cancelled" in result.stdout
assert impalad.wait_for_num_in_flight_queries(0)
http://git-wip-us.apache.org/repos/asf/impala/blob/96f97653/tests/shell/test_shell_interactive.py
----------------------------------------------------------------------
diff --git a/tests/shell/test_shell_interactive.py b/tests/shell/test_shell_interactive.py
index 4d071de..5067bf9 100755
--- a/tests/shell/test_shell_interactive.py
+++ b/tests/shell/test_shell_interactive.py
@@ -180,6 +180,12 @@ class TestImpalaShellInteractive(object):
assert "Cancelled" not in result.stderr
assert impalad.wait_for_num_in_flight_queries(0)
+ p = ImpalaShell()
+ sleep(3)
+ os.kill(p.pid(), signal.SIGINT)
+ result = p.get_result()
+ assert "^C" in result.stderr
+
def test_unicode_input(self):
"Test queries containing non-ascii input"
# test a unicode query spanning multiple lines
[3/4] impala git commit: IMPALA-7870: Increase the timeout in
test_v1_catalog
Posted by jo...@apache.org.
IMPALA-7870: Increase the timeout in test_v1_catalog
TestAutomaticCatalogInvalidation.test_v1_catalog need to wait for a
predefined time for the invalidation to take effect. The test is flaky
recently because of it. This patch increates the timeout by 2.5x.
Change-Id: If7d37a6109b2e8de1473d42d699b8c7057d0b29b
Reviewed-on: http://gerrit.cloudera.org:8080/11997
Reviewed-by: Todd Lipcon <to...@apache.org>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Project: http://git-wip-us.apache.org/repos/asf/impala/repo
Commit: http://git-wip-us.apache.org/repos/asf/impala/commit/e546e523
Tree: http://git-wip-us.apache.org/repos/asf/impala/tree/e546e523
Diff: http://git-wip-us.apache.org/repos/asf/impala/diff/e546e523
Branch: refs/heads/master
Commit: e546e5234444f491166a052667aeb8fddebd6873
Parents: a1407ad
Author: Tianyi Wang <tw...@cloudera.com>
Authored: Tue Nov 27 14:38:36 2018 -0800
Committer: Impala Public Jenkins <im...@cloudera.com>
Committed: Wed Nov 28 04:25:54 2018 +0000
----------------------------------------------------------------------
tests/custom_cluster/test_automatic_invalidation.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/impala/blob/e546e523/tests/custom_cluster/test_automatic_invalidation.py
----------------------------------------------------------------------
diff --git a/tests/custom_cluster/test_automatic_invalidation.py b/tests/custom_cluster/test_automatic_invalidation.py
index e82217b..a9aba66 100644
--- a/tests/custom_cluster/test_automatic_invalidation.py
+++ b/tests/custom_cluster/test_automatic_invalidation.py
@@ -55,8 +55,8 @@ class TestAutomaticCatalogInvalidation(CustomClusterTestSuite):
cursor.fetchall()
# The table is cached after usage.
assert self.metadata_cache_string in self._get_catalog_object()
- # Wait 2 * table TTL for the invalidation to take effect.
- max_wait_time = time.time() + self.timeout * 2
+ # Wait 5 * table TTL for the invalidation to take effect.
+ max_wait_time = time.time() + self.timeout * 5
while True:
time.sleep(1)
# The table is eventually evicted.