You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/09/16 16:17:07 UTC

[GitHub] [incubator-tvm] areusch commented on pull request #6395: [BYOC][TensorRT] TensorRT BYOC integration

areusch commented on pull request #6395:
URL: https://github.com/apache/incubator-tvm/pull/6395#issuecomment-693512582


   looks like we are on cpplint 1.4.5. I tried running it at 1.5.4, latest release, but no change. There is an option in clang-format (AlignAfterOpenBracket) to control bracket alignment style, but the google style-guide setting it's at right now I think is the most reasonable. Further, I don't think cpplint can differentiate between #define continuations and regular code, so we can't configure that there.
   
   you could try manually fixing the line to make cpplint happy, then add on surrounding lines:
   `// clang-format off`
   `// clang-format on`
   
   this seems like an edge case in cpplint, so i'd vote for that.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org