You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2019/03/20 02:20:47 UTC
Review Request 70242: Tracked operation IDs in the agent.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70242/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier, Gastón Kleiman, and Joseph Wu.
Bugs: MESOS-9648
https://issues.apache.org/jira/browse/MESOS-9648
Repository: mesos
Description
-------
This patch updates the agent to track operation IDs in a
hashmap. This map will be used to satisfy some reconciliation
requests which are forwarded from the master, when the agent
must be able to find the internal operation UUID for an
operation which the master did not recognize.
Diffs
-----
src/slave/slave.hpp 271593460b0aaeb8dfa0b1659e4365919e0c32d5
src/slave/slave.cpp 36424f89a8c1f183febabcc9582975dd21213c25
Diff: https://reviews.apache.org/r/70242/diff/1/
Testing
-------
Testing details at the end of this chain.
Thanks,
Greg Mann
Re: Review Request 70242: Tracked operation IDs in the agent.
Posted by Greg Mann <gr...@mesosphere.io>.
> On March 21, 2019, 8:27 p.m., Joseph Wu wrote:
> > src/slave/slave.hpp
> > Lines 875-878 (patched)
> > <https://reviews.apache.org/r/70242/diff/1/?file=2132873#file2132873line875>
> >
> > Aren't these IDs only unique within a Framework's scope?
> >
> > Two frameworks could presumably launch an operation with the same ID, on the same agent.
> >
> > Looks like the master stores a similar mapping in the Framework struct, so there is no possibility of overwrite there.
Whoops :D Thanks Joseph!!! I'll try changing this to a `hashmap<std::pair<FrameworkID, OperationID>, UUID>`, with a note to put the map in the framework struct once MESOS-8582 is resolved.
- Greg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70242/#review213891
-----------------------------------------------------------
On March 20, 2019, 2:21 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70242/
> -----------------------------------------------------------
>
> (Updated March 20, 2019, 2:21 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Gastón Kleiman, and Joseph Wu.
>
>
> Bugs: MESOS-9318
> https://issues.apache.org/jira/browse/MESOS-9318
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch updates the agent to track operation IDs in a
> hashmap. This map will be used to satisfy some reconciliation
> requests which are forwarded from the master, when the agent
> must be able to find the internal operation UUID for an
> operation which the master did not recognize.
>
>
> Diffs
> -----
>
> src/slave/slave.hpp 271593460b0aaeb8dfa0b1659e4365919e0c32d5
> src/slave/slave.cpp 36424f89a8c1f183febabcc9582975dd21213c25
>
>
> Diff: https://reviews.apache.org/r/70242/diff/1/
>
>
> Testing
> -------
>
> Testing details at the end of this chain.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 70242: Tracked operation IDs in the agent.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70242/#review213891
-----------------------------------------------------------
src/slave/slave.hpp
Lines 875-878 (patched)
<https://reviews.apache.org/r/70242/#comment300001>
Aren't these IDs only unique within a Framework's scope?
Two frameworks could presumably launch an operation with the same ID, on the same agent.
Looks like the master stores a similar mapping in the Framework struct, so there is no possibility of overwrite there.
- Joseph Wu
On March 19, 2019, 7:21 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70242/
> -----------------------------------------------------------
>
> (Updated March 19, 2019, 7:21 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Gastón Kleiman, and Joseph Wu.
>
>
> Bugs: MESOS-9318
> https://issues.apache.org/jira/browse/MESOS-9318
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch updates the agent to track operation IDs in a
> hashmap. This map will be used to satisfy some reconciliation
> requests which are forwarded from the master, when the agent
> must be able to find the internal operation UUID for an
> operation which the master did not recognize.
>
>
> Diffs
> -----
>
> src/slave/slave.hpp 271593460b0aaeb8dfa0b1659e4365919e0c32d5
> src/slave/slave.cpp 36424f89a8c1f183febabcc9582975dd21213c25
>
>
> Diff: https://reviews.apache.org/r/70242/diff/1/
>
>
> Testing
> -------
>
> Testing details at the end of this chain.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 70242: Tracked operation IDs in the agent.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70242/#review213813
-----------------------------------------------------------
PASS: Mesos patch 70242 was successfully built and tested.
Reviews applied: `['70200', '70208', '70221', '70242']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2980/mesos-review-70242
- Mesos Reviewbot Windows
On March 19, 2019, 7:21 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70242/
> -----------------------------------------------------------
>
> (Updated March 19, 2019, 7:21 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Gastón Kleiman, and Joseph Wu.
>
>
> Bugs: MESOS-9318
> https://issues.apache.org/jira/browse/MESOS-9318
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch updates the agent to track operation IDs in a
> hashmap. This map will be used to satisfy some reconciliation
> requests which are forwarded from the master, when the agent
> must be able to find the internal operation UUID for an
> operation which the master did not recognize.
>
>
> Diffs
> -----
>
> src/slave/slave.hpp 271593460b0aaeb8dfa0b1659e4365919e0c32d5
> src/slave/slave.cpp 36424f89a8c1f183febabcc9582975dd21213c25
>
>
> Diff: https://reviews.apache.org/r/70242/diff/1/
>
>
> Testing
> -------
>
> Testing details at the end of this chain.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 70242: Tracked operation IDs in the agent.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70242/#review214012
-----------------------------------------------------------
Ship it!
Ship It!
- Joseph Wu
On March 21, 2019, 3:23 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70242/
> -----------------------------------------------------------
>
> (Updated March 21, 2019, 3:23 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Gastón Kleiman, and Joseph Wu.
>
>
> Bugs: MESOS-9318
> https://issues.apache.org/jira/browse/MESOS-9318
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch updates the agent to track operation IDs in a
> hashmap. This map will be used to satisfy some reconciliation
> requests which are forwarded from the master, when the agent
> must be able to find the internal operation UUID for an
> operation which the master did not recognize.
>
>
> Diffs
> -----
>
> include/mesos/type_utils.hpp acf5ba8e4db85bcb5e9370ed23d7d16260905e01
> src/slave/slave.hpp 271593460b0aaeb8dfa0b1659e4365919e0c32d5
> src/slave/slave.cpp 36424f89a8c1f183febabcc9582975dd21213c25
>
>
> Diff: https://reviews.apache.org/r/70242/diff/2/
>
>
> Testing
> -------
>
> Testing details at the end of this chain.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 70242: Tracked operation IDs in the agent.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70242/
-----------------------------------------------------------
(Updated March 21, 2019, 10:23 p.m.)
Review request for mesos, Benjamin Bannier, Gastón Kleiman, and Joseph Wu.
Bugs: MESOS-9318
https://issues.apache.org/jira/browse/MESOS-9318
Repository: mesos
Description
-------
This patch updates the agent to track operation IDs in a
hashmap. This map will be used to satisfy some reconciliation
requests which are forwarded from the master, when the agent
must be able to find the internal operation UUID for an
operation which the master did not recognize.
Diffs (updated)
-----
include/mesos/type_utils.hpp acf5ba8e4db85bcb5e9370ed23d7d16260905e01
src/slave/slave.hpp 271593460b0aaeb8dfa0b1659e4365919e0c32d5
src/slave/slave.cpp 36424f89a8c1f183febabcc9582975dd21213c25
Diff: https://reviews.apache.org/r/70242/diff/2/
Changes: https://reviews.apache.org/r/70242/diff/1-2/
Testing
-------
Testing details at the end of this chain.
Thanks,
Greg Mann
Re: Review Request 70242: Tracked operation IDs in the agent.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70242/
-----------------------------------------------------------
(Updated March 20, 2019, 2:21 a.m.)
Review request for mesos, Benjamin Bannier, Gastón Kleiman, and Joseph Wu.
Bugs: MESOS-9318
https://issues.apache.org/jira/browse/MESOS-9318
Repository: mesos
Description
-------
This patch updates the agent to track operation IDs in a
hashmap. This map will be used to satisfy some reconciliation
requests which are forwarded from the master, when the agent
must be able to find the internal operation UUID for an
operation which the master did not recognize.
Diffs
-----
src/slave/slave.hpp 271593460b0aaeb8dfa0b1659e4365919e0c32d5
src/slave/slave.cpp 36424f89a8c1f183febabcc9582975dd21213c25
Diff: https://reviews.apache.org/r/70242/diff/1/
Testing
-------
Testing details at the end of this chain.
Thanks,
Greg Mann