You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "divijvaidya (via GitHub)" <gi...@apache.org> on 2023/06/19 08:32:12 UTC

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13872: KAFKA-15085: Make Timer.java implement AutoCloseable

divijvaidya commented on code in PR #13872:
URL: https://github.com/apache/kafka/pull/13872#discussion_r1233709886


##########
server-common/src/main/java/org/apache/kafka/server/util/timer/SystemTimer.java:
##########
@@ -106,7 +106,7 @@ public int size() {
         return taskCounter.get();
     }
 
-    public void shutdown() {
+    public void close() {

Review Comment:
   nit
   
   please add `@Override`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org