You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/12/22 03:24:49 UTC
[GitHub] [flink] wangxlong commented on a change in pull request #14387: [FLINK-19691][Connector][jdbc] Expose `CONNECTION_CHECK_TIMEOUT_SECONDS` as a configurable option in Jdbc connector
wangxlong commented on a change in pull request #14387:
URL: https://github.com/apache/flink/pull/14387#discussion_r547045729
##########
File path: flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/internal/JdbcBatchingOutputFormat.java
##########
@@ -179,11 +178,9 @@ public synchronized void flush() throws IOException {
throw new IOException(e);
}
try {
- if (!connection.isValid(CONNECTION_CHECK_TIMEOUT_SECONDS)) {
Review comment:
I think we should keep this. Putting field `connectionCheckTimeoutSeconds ` in the `jdbcOptions` object maybe some unreasonable, for `jdbcOptions` holds information about database connections. I think it is better to put it in `JdbcLookupOptions` and `JdbcExecutionOptions`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org