You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Jorge Costa (JIRA)" <ji...@codehaus.org> on 2013/04/09 19:01:53 UTC

[jira] (SCM-681) Git blame fails to report line authors on windows with core.autocrlf = true

    [ https://jira.codehaus.org/browse/SCM-681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=323446#comment-323446 ] 

Jorge Costa commented on SCM-681:
---------------------------------

Hi Olivier,

I was looking into the implementation of this feature, and at least for git i found difficult to understand how the parameter is passed to the command executor.

This is the implementation of the command:

        Commandline cl = createCommandLine( workingDirectory.getBasedir(), filename,
                                            parameters.getBoolean( CommandParameter.IGNORE_WHITESPACE, false ) );

As i understand in the new BlameScmRequest is only setting an internal boolean ignoreWhitespace to true and not the property. So i see that the ignore whitespaces is always ignored. 

Is this the intended implementation, or am i not seeing everything?

Thanks in advance

Br,

Jorge Costa

                
> Git blame fails to report line authors on windows with core.autocrlf = true
> ---------------------------------------------------------------------------
>
>                 Key: SCM-681
>                 URL: https://jira.codehaus.org/browse/SCM-681
>             Project: Maven SCM
>          Issue Type: Bug
>          Components: maven-scm-provider-git
>    Affects Versions: 1.7
>         Environment: Windows
> git configured with core.autocrlf = true
>            Reporter: David Gageot
>            Assignee: Olivier Lamy
>             Fix For: 1.8
>
>
> Git blame cannot report line authors when each line is modified locally by the autocrlf parameter. It thinks every line is Not Yet Committed.
> The fix is to use git blame -w instead of plain git blame, to ignore whitespaces.
> See discussion here: http://stackoverflow.com/questions/4638500/git-blame-showing-no-history

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira