You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by te...@apache.org on 2014/04/19 00:43:10 UTC

svn commit: r1588587 - /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestLogRolling.java

Author: tedyu
Date: Fri Apr 18 22:43:09 2014
New Revision: 1588587

URL: http://svn.apache.org/r1588587
Log:
HBASE-11031 Some HTable's are not closed in TestLogRolling


Modified:
    hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestLogRolling.java

Modified: hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestLogRolling.java
URL: http://svn.apache.org/viewvc/hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestLogRolling.java?rev=1588587&r1=1588586&r2=1588587&view=diff
==============================================================================
--- hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestLogRolling.java (original)
+++ hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestLogRolling.java Fri Apr 18 22:43:09 2014
@@ -172,7 +172,8 @@ public class TestLogRolling  {
 
   private void startAndWriteData() throws IOException, InterruptedException {
     // When the hbase:meta table can be opened, the region servers are running
-    new HTable(TEST_UTIL.getConfiguration(), TableName.META_TABLE_NAME);
+    HTable ht = new HTable(TEST_UTIL.getConfiguration(), TableName.META_TABLE_NAME);
+    ht.close();
     this.server = cluster.getRegionServerThreads().get(0).getRegionServer();
     this.log = server.getWAL();
 
@@ -207,6 +208,7 @@ public class TestLogRolling  {
       newLog.rollWriter(true);
     } finally {
       newLog.closeAndDelete();
+      fs.close();
     }
   }
 
@@ -427,7 +429,8 @@ public class TestLogRolling  {
       fs.getDefaultReplication() > 1);
     LOG.info("Replication=" + fs.getDefaultReplication());
     // When the hbase:meta table can be opened, the region servers are running
-    new HTable(TEST_UTIL.getConfiguration(), TableName.META_TABLE_NAME);
+    HTable ht = new HTable(TEST_UTIL.getConfiguration(), TableName.META_TABLE_NAME);
+    ht.close();
 
     this.server = cluster.getRegionServer(0);
     this.log = server.getWAL();
@@ -584,7 +587,8 @@ public class TestLogRolling  {
   @Test
   public void testCompactionRecordDoesntBlockRolling() throws Exception {
     // When the hbase:meta table can be opened, the region servers are running
-    new HTable(TEST_UTIL.getConfiguration(), TableName.META_TABLE_NAME);
+    HTable ht = new HTable(TEST_UTIL.getConfiguration(), TableName.META_TABLE_NAME);
+    ht.close();
 
     String tableName = getName();
     HTable table = createTestTable(tableName);